From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01B6BC433F5 for ; Mon, 11 Oct 2021 14:45:27 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id 8C9E660EBD for ; Mon, 11 Oct 2021 14:45:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8C9E660EBD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 70CB640150; Mon, 11 Oct 2021 16:45:25 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 4A1364003C for ; Mon, 11 Oct 2021 16:45:24 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10134"; a="290383133" X-IronPort-AV: E=Sophos;i="5.85,364,1624345200"; d="scan'208";a="290383133" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Oct 2021 07:45:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,364,1624345200"; d="scan'208";a="716414623" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by fmsmga005.fm.intel.com with ESMTP; 11 Oct 2021 07:45:21 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 11 Oct 2021 07:45:21 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 11 Oct 2021 07:45:21 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Mon, 11 Oct 2021 07:45:21 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.43) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Mon, 11 Oct 2021 07:45:21 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WgCAKAH1x5B9Twoi5IQMOZn7s9/ihESR6pxcbP6PwR55RFNQM/6aE0+z6DGRiodOJDimr0JtVggcFgUIUb6HEsQmzU/yEBRchzdOuCfxo/kk4JuQK9J3r06upbU3E5WYno+JOgj3FBNLsze4q++krkC9NFfwVsDarO0o4nO7whVVf6+AamVAL8Xz9Bg3Z4Npdyl+5pA7JN+rQuQZQd3MBS3W9J2k9oJTEX7rKCDLh4D5ydcOgzhx2+JcQQjwSEIn/kL+vxud4PfeplrPvEQ+X1VDjY0rqnmS3hikRA5r6Vgw7D++aBamWmt2DF7wIxtB+y0PyrneTbj5jt1dymrilQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=D/ubLhuhm7GSgPgLTlPa3qMPqHyJL9DFU42QtSGj6h8=; b=gkB9y+RT7cmS1kkgMYelsOOEnBeiICqSeUuKITLLICIS3kBfbP2q+XtV1FpeBsEeAxOlsizGW6w1x32LwWQrZ6W8fYusko86vsxqd2//F1dyVrItgZZxAE7h+ZLalumqreTk3GzOaOFujaD/5g4HVk8+nynp2c9S0Aj7WCrIVaSa7YtbhZpjaHE8IRV8oH8SdZkKB0EF+EWtdSxNH3pw1rFIVYDYtfloTkYKdkKbfbRcVTisHoA5Poe3e2YmJvRpRA0v9P/vomYwBbaTs/2zMyWmT4ofDsSyFlQ6rkf8H4XQv/LuT167v6hNrZWDtCxP3ni0Fxp+34xp79/m9ZcAag== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=D/ubLhuhm7GSgPgLTlPa3qMPqHyJL9DFU42QtSGj6h8=; b=r+hZU+Tb1LYIpE7YAhQQPuPFpF4tvVZt6zqrRqzxN50BmgwUOJXXjEM33oP7TUk9gf7VmLqwpk9QpWvY5WEFeqx6wm41T9mQzKtb/478ZhAvlAX3BrcvO1Ne7s/niqrRMT3HIXI5buf2En9KVhxnMEKb9LIjk3AAib6vkpQPtLY= Received: from MW5PR11MB5809.namprd11.prod.outlook.com (2603:10b6:303:197::6) by CO1PR11MB5121.namprd11.prod.outlook.com (2603:10b6:303:94::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18; Mon, 11 Oct 2021 14:45:20 +0000 Received: from MW5PR11MB5809.namprd11.prod.outlook.com ([fe80::2c31:1470:3036:959b]) by MW5PR11MB5809.namprd11.prod.outlook.com ([fe80::2c31:1470:3036:959b%6]) with mapi id 15.20.4587.026; Mon, 11 Oct 2021 14:45:20 +0000 From: "Zhang, Roy Fan" To: Akhil Goyal , "dev@dpdk.org" CC: "thomas@monjalon.net" , "david.marchand@redhat.com" , "hemant.agrawal@nxp.com" , "anoobj@marvell.com" , "De Lara Guarch, Pablo" , "Trahe, Fiona" , "Doherty, Declan" , "matan@nvidia.com" , "g.singh@nxp.com" , "jianjay.zhou@huawei.com" , "asomalap@amd.com" , "ruifeng.wang@arm.com" , "Ananyev, Konstantin" , "Nicolau, Radu" , "ajit.khaparde@broadcom.com" , "rnagadheeraj@marvell.com" , "adwivedi@marvell.com" , "Power, Ciara" Thread-Topic: [PATCH v2 3/5] cryptodev: move inline APIs into separate structure Thread-Index: AQHXvp2uQqQ3SyHQDEO/uPC2NVMqNavN3ihw Date: Mon, 11 Oct 2021 14:45:19 +0000 Message-ID: References: <20210829125139.2173235-1-gakhil@marvell.com> <20211011124309.4066491-1-gakhil@marvell.com> <20211011124309.4066491-4-gakhil@marvell.com> In-Reply-To: <20211011124309.4066491-4-gakhil@marvell.com> Accept-Language: zh-Hans-HK, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.200.16 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: marvell.com; dkim=none (message not signed) header.d=none;marvell.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: fa8ad531-25e2-4710-47da-08d98cc5bfb2 x-ms-traffictypediagnostic: CO1PR11MB5121: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:289; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 8x/LUTznQHcuBLhAQSX8sNwWIf1OOHFu1aHf+M9SLaO5uVlKQ4X3hq/quTIUKYT+AwRGlQEM8m/zW3qUeFPLkHeiORwd/snHxqI2at4eepX65Ug8vSCn7tPvPOnaqxlS27VEyVgwdGPa1ySB/62NMBvzLXpdai29S9vJyHywrq/yuSnKFSsZjjCw3hO4juEPSBYTSoX1p6WtF/UUyCZy4qEQEcKyZLi9vu2UOf0OLkJiEeqXSegiQF9VlJgxqP01bQWesX0CT4C1O5m6EL0U9FOg5HEW1HqNJqRIJ/zU4X9vVhi1xhHkPwdUQ7m/UQHBuBZLmdrh+gR78hnGxiVxeZZI6r6ZDqQM6/yVBV4KvdVh/5GlPKKD35R0Xkof0BEAhRWSUEktdX7RueuKrXRIWud88HYmVwXMQyDsTvFv+gtQ9w5+SFyOiDRZHXfFh1UiAQ9oSjgZHMGCRhd0jjEn6tCRxYGshf+fM4HIyYnK7ibfS69Yr8xMvxDMuSVZCxPzjuocbfs9tMsQrLih48zhICybXaVppl95dz42eQtjCCgyNVf0d8Yh6kjlVdPWNApdOhpZSX7EveRzciHkOeFinyvdzQ0DGuj+ASP972NqCgJ0b6HyiScitSKQt+LJKcwXXyuYVls3hnOc5ORy5auQxY5N6tBMADx0RyXzOvBWAxjFFIvJaYWfdf301cxElOJksCkFZGJ2QH1pvJY2GHSfsw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW5PR11MB5809.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(86362001)(5660300002)(66446008)(53546011)(38070700005)(66556008)(6506007)(64756008)(66476007)(7696005)(4326008)(7416002)(110136005)(107886003)(2906002)(8676002)(54906003)(33656002)(83380400001)(8936002)(52536014)(316002)(508600001)(66946007)(76116006)(26005)(186003)(122000001)(38100700002)(55016002)(71200400001)(9686003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?Windows-1252?Q?kzuGLmNva+6D8Oltag8TPSL0LvRFVthFwinlLMaX7LRmMlJ0VmHqW/E5?= =?Windows-1252?Q?/kFqRu8djM0GAsIk18O8WViCtDaW1gipMtcchZcAo/EK2gGHmAWF4aIq?= =?Windows-1252?Q?SudX4Mnp+yleuPRec+HjbTx5zWotp7zbVYFe7idXEWqmk0rmCPV4ePBk?= =?Windows-1252?Q?ptKA/0N5d0wMWW4IgL1rSev0wji8keCPAQ2Mm8h7suaZdOtkz4EUA6z9?= =?Windows-1252?Q?gulhcgf+IaQjmnXSSSUORfAAo8bby/9qWLrOiTCUm+CehIiYsIV4yhTJ?= =?Windows-1252?Q?EDW47zB1u1Y2EsPUCUIpuxM2rUI5n0SbCAStijSc0FTCj+fJ0zAsL6EX?= =?Windows-1252?Q?v6+aejFpWQubAQj9W8Cts9MHrrEndJtC3A7AGbKiXBBdeVe6/87X2Bb5?= =?Windows-1252?Q?jeyf2f60Y3x8OmhytOXmTKD9JKc+1uI9H2ApJ71uSJSeDACRXgO3Vwu6?= =?Windows-1252?Q?v+6JQwBY+vf9O5sJfNsmNcJNQIIzxwjZ02nsrSi5rL83U79EvchHFUKx?= =?Windows-1252?Q?Dzn9xB6PxVuO+8GFkZ3D/KLqDGeHS9hFVveybna+kj9GKis1tEDm/yOz?= =?Windows-1252?Q?SQiyIyX4TBspZrjaw1lpkUeZCUc2o0RuWDvHMD8+bZ+xcM2a8mPTY7lr?= =?Windows-1252?Q?TprLfYVq454QwpXj3SgbptRn5zymPNsbZjo7hrOVN1f7LKI4f4uZ0em7?= =?Windows-1252?Q?BVuM+r58YZW43SPldNTgOfC2TQHJQHnuPXOrtvQimKTb5L241aWvCkxB?= =?Windows-1252?Q?MPZjc0CHMNHwAlKudPjlBWTJffiDgH1zaBcEcKR7nPWRMCgj3H679H/6?= =?Windows-1252?Q?dVBsylXxOB/R3nHH2hT87qzI9MrFc9+dcrhfzZg/tTMLJLa9RUDTlp/7?= =?Windows-1252?Q?082r6JS/hpKc+oxbQ/M4+Pa4oZqO8FzjEpeOgfKOHZIU5ZzSWWJVAiUk?= =?Windows-1252?Q?2iXzlUekacPradkLeubucoMOT2NZbdS/m2oL5W1sZhbkwtEsCLwFeULW?= =?Windows-1252?Q?5QoBvfLSqvyjpgqUr6ChJ5uI2Tl1weWWXOkqsTIMHvT4XKlvbfMzD2SP?= =?Windows-1252?Q?UV+nXOdcBq+nju+TtJBtzHlsQUPFdU7ARJVh84lWq2RrURssaMAnyVDi?= =?Windows-1252?Q?mIaHIpu0yjZW3tKORLrJ37dRCoU5nRGMNQorSUwVoQr1din8S8cObB4+?= =?Windows-1252?Q?nMRZ8JZbH+cAN+1TwdO2zR59eUb21nbkfOWjPe1dRdtobHuxo0rZZKOv?= =?Windows-1252?Q?ka3M9JB2Nht7IAq9mD6/a31f8h/olDrGmPVGyyI1EiRmJKuTjQ6bthiL?= =?Windows-1252?Q?nywmQBLizFGmUOrQvzPmO6xreX1oRHltva2xJi/wBwZrUEmxleoJFJie?= =?Windows-1252?Q?4ypPTvqlpqNpqZoCPwpMOUXuSPUVESViDdSz9b4PrOCH1ZqDv0U+d2Ic?= Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW5PR11MB5809.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fa8ad531-25e2-4710-47da-08d98cc5bfb2 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Oct 2021 14:45:19.9694 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: JKQfviskPLC5qtYor3iEUza36SYFayUVAoAafAcjUh8e+aplZtVinNARN8ME/UP0z4C2mmqM5TYsO40uw6XbIA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB5121 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2 3/5] cryptodev: move inline APIs into separate structure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Akhil, > -----Original Message----- > From: Akhil Goyal > Sent: Monday, October 11, 2021 1:43 PM > To: dev@dpdk.org > Cc: thomas@monjalon.net; david.marchand@redhat.com; > hemant.agrawal@nxp.com; anoobj@marvell.com; De Lara Guarch, Pablo > ; Trahe, Fiona ; > Doherty, Declan ; matan@nvidia.com; > g.singh@nxp.com; Zhang, Roy Fan ; > jianjay.zhou@huawei.com; asomalap@amd.com; ruifeng.wang@arm.com; > Ananyev, Konstantin ; Nicolau, Radu > ; ajit.khaparde@broadcom.com; > rnagadheeraj@marvell.com; adwivedi@marvell.com; Power, Ciara > ; Akhil Goyal > Subject: [PATCH v2 3/5] cryptodev: move inline APIs into separate structu= re >=20 > Move fastpath inline function pointers from rte_cryptodev into a > separate structure accessed via a flat array. > The intension is to make rte_cryptodev and related structures private > to avoid future API/ABI breakages. >=20 > Signed-off-by: Akhil Goyal > --- > lib/cryptodev/cryptodev_pmd.c | 51 > ++++++++++++++++++++++++++++++ > lib/cryptodev/cryptodev_pmd.h | 11 +++++++ > lib/cryptodev/rte_cryptodev.c | 29 +++++++++++++++++ > lib/cryptodev/rte_cryptodev_core.h | 29 +++++++++++++++++ > lib/cryptodev/version.map | 5 +++ > 5 files changed, 125 insertions(+) >=20 > diff --git a/lib/cryptodev/cryptodev_pmd.c > b/lib/cryptodev/cryptodev_pmd.c > index 44a70ecb35..4646708045 100644 > --- a/lib/cryptodev/cryptodev_pmd.c > +++ b/lib/cryptodev/cryptodev_pmd.c > @@ -4,6 +4,7 @@ >=20 > #include >=20 > +#include > #include > #include >=20 > @@ -160,3 +161,53 @@ rte_cryptodev_pmd_destroy(struct rte_cryptodev > *cryptodev) >=20 When a device is removed - aka when rte_pci_remove() is called=20 cryptodev_fp_ops_reset() will never be called. This may expose a problem. Looks like cryptodev_fp_ops_reset() needs to be called here too. > return 0; ...=20