From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, PDS_BAD_THREAD_QP_64,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E22B3C433E9 for ; Wed, 10 Mar 2021 10:50:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8361F64FF2 for ; Wed, 10 Mar 2021 10:50:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232484AbhCJKuY (ORCPT ); Wed, 10 Mar 2021 05:50:24 -0500 Received: from mail-bn7nam10on2057.outbound.protection.outlook.com ([40.107.92.57]:33756 "EHLO NAM10-BN7-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S232459AbhCJKuA (ORCPT ); Wed, 10 Mar 2021 05:50:00 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GScYG6ptiRA8NIras0eslyXjBjaLDKqRFFrhsVaqvF8HI6+NGk1PBhmUmmz6x95gHtKYJjMiZBlkO2zjdIpXgL5L0tM/DDdVz6AkD34ZibcId0xlfKupZdF3Zbm8NpyVPuI6ZG82LAR0HcDoUi4WtzoFiFhBa+peQ8GKeSTgE5V2oSpUlplMxoMVp/PShofJBY3veTP5WM8s2ItJiN4y0bJtkoDklDdIiJV4UBIjU2+G50UXoi7a28xT50uy5t9M75383J521lPV+a03iP3frJZO1Z1vLJO0z/OHZewxb0EwB0rRf3gk2MKVH89Z/PPMJwqoFrJaLfaRw+ZbJofw3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0ncDHrv0nPwx+g2fs3HBWT71veJK73VQr+TFIgK8q+Y=; b=iOa5KGzsnqtjrilz6toX0YrVTgSqgUb5lti9PrAYIXPSgn+COCuVRYQHZgMFEmUye12PtVEIKO1Lnp3PmJ8t9AejBqNbINtT3PEUj2W2cLMgaDvQDGKoAUqCv134lj83wDvDUQYwj1SBa0XXBwF2a5S9bXAzA4EWfYfwTg0byGAzBVu5kHB5+fj0448cO4CkyPj6BU+EK6szSsgxhKi0rP4+rjI5p2OCoFdkWsHlX6zqU+Ari2z9JeJGYfdlXJ20KUIUnABTZPMiMgCfLvDNNm9TG01RckAQBvznEL8VwsJ7kPXPYzWjDvMh7NQMvg1fqzV+HRkUOjjEaH0PJp/+Sw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=xilinx.com; dmarc=pass action=none header.from=xilinx.com; dkim=pass header.d=xilinx.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0ncDHrv0nPwx+g2fs3HBWT71veJK73VQr+TFIgK8q+Y=; b=GhNEhFjxij1LHZ6rs759QXXZiQVwGc6yliroqrJuus7eWT+GJkWvD93LfLi+hEHa9n7+pWc6toyrGo2CiX7dAkdCLokXbGHiumBpd2ll1WimYsYHCEzMyOlc6z3QZRbbioyv6PKWcLk0TW6oTfpGWI+zKbVJmgd56z3UNt8YAjI= Received: from MWHPR02MB2623.namprd02.prod.outlook.com (2603:10b6:300:44::9) by MWHPR02MB3149.namprd02.prod.outlook.com (2603:10b6:301:62::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.17; Wed, 10 Mar 2021 10:49:55 +0000 Received: from MWHPR02MB2623.namprd02.prod.outlook.com ([fe80::297d:1fb:ad07:1b26]) by MWHPR02MB2623.namprd02.prod.outlook.com ([fe80::297d:1fb:ad07:1b26%9]) with mapi id 15.20.3912.030; Wed, 10 Mar 2021 10:49:55 +0000 From: Nava kishore Manne To: Rob Herring CC: "mdf@kernel.org" , "trix@redhat.com" , Michal Simek , "gregkh@linuxfoundation.org" , Jolly Shah , Rajan Vaja , "arnd@arndb.de" , Manish Narani , Amit Sunil Dhamne , Tejas Patel , "linux-fpga@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "chinnikishore369@gmail.com" , Appana Durga Kedareswara Rao Subject: RE: [PATCH v3 2/3] dt-bindings: fpga: Add binding doc for versal fpga manager Thread-Topic: [PATCH v3 2/3] dt-bindings: fpga: Add binding doc for versal fpga manager Thread-Index: AQHXEMVdMsyP8+vbRE2oyddQhLKezap6jzYAgAKDMvA= Date: Wed, 10 Mar 2021 10:49:54 +0000 Message-ID: References: <20210304070224.22346-1-nava.manne@xilinx.com> <20210304070224.22346-3-nava.manne@xilinx.com> <20210308201944.GA2886704@robh.at.kernel.org> In-Reply-To: <20210308201944.GA2886704@robh.at.kernel.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-TNEF-Correlator: authentication-results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=xilinx.com; x-originating-ip: [149.199.50.130] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 7c492a54-356d-4f79-a8a5-08d8e3b23daf x-ms-traffictypediagnostic: MWHPR02MB3149: x-ld-processed: 657af505-d5df-48d0-8300-c31994686c5c,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6108; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: TE3m84TSrUTUiTY3kfjls8o9AF1T9aj2iEFxQm64YbCfO/AIhpbtTRW2n/OQwPMBWh1cCncRjjP2MpT1gW73zf052YFzCXAyRMSpBH+mL0Pt64jfeQ1TlyB9Uo0qfSezza1J9S4Uw2m6GRh2FfYcQVS4/EycVDXsNKD0kHQIuzmq5ATekdOw89DZyIvVEW3ppUr447HCD9NWyGJWwJMZK2UC1I1KAl4Oo8C4CL86xALmUdwXpJfr72ubxVKmiUm78i2Yz+unRH9Bas6Z32Gmx9vpctkSwV0tM3pMiKPv8vpapMHSCGJKTdYbexxjilG5QMYZqYTvWQ/a30AOrSbnVg2nRs0YyuhNbh9LIbp8jsyhLHiLUEzCO0USPgxI0BU2IAY6Nueextcqg9ECVjfqNGMBBEwfdBSM/R+5wLoBGIF9nYT1x43J2qLiVFqx/41dwEPhawNK/62mFrirnPGPLY60oHidlA6wLSeBEgQ26j9jhaWsA+wBItc5NkH1zDvmL96AGqIlCArtKv5sCuRE5g== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR02MB2623.namprd02.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(136003)(366004)(396003)(376002)(39850400004)(9686003)(8676002)(33656002)(2906002)(54906003)(4326008)(8936002)(6916009)(55016002)(64756008)(53546011)(76116006)(66556008)(66476007)(7696005)(186003)(66946007)(5660300002)(6506007)(66446008)(83380400001)(26005)(316002)(71200400001)(86362001)(52536014)(7416002)(478600001)(107886003);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?H3XmiXd2L5Ik5xsmAmRH+4dxrLTPAzt/GIUoG4szw7AKi1lP2iWGcsJzyi4J?= =?us-ascii?Q?Kh39rgVL03u+a6tm0Chk+Tf+qB3CV3lo3qZ4NRzRHS+MKcorBlLD4dwKy2n0?= =?us-ascii?Q?ZAfPtyXWIoARHaT6YAIXn/MWUr4tNA6Hor3LrdGa6B9qir6lQN+X3c7PoeEj?= =?us-ascii?Q?Ug1rCHjWXOJGHFkTG5oa3zmLerB6eZfDbjkm3ktStJPdGHfrBqQx6h8uwpmu?= =?us-ascii?Q?SKmk+q4UH0AJpMJQZi+Yd0x2T2nNefbjyWsuxnFx+R9KNAfXnPlUPuAizyCG?= =?us-ascii?Q?hdpovlWp2lnLZ5xlGAnpmCA3xcXP4GrZbAC0doUkGCR0W61nj64r0nhU47Mk?= =?us-ascii?Q?BdEoTgQ26GIAc27xuyqb41hOmaoV/WMpXvb+wlkSL3HnFvioWVQQDymiGofw?= =?us-ascii?Q?Vzmu3DRYNP9bKwBemUuJ9AiIUXuLIUwp5PrieryXTIo85fKl+1nTWloxdZ3O?= =?us-ascii?Q?hW/sOb7q6agqLvPDLkC5pB7FqA9qhVaGzrLbSR0QLKw+MdjikpX8z2vpuyZ/?= =?us-ascii?Q?ieqxx2EmB/lSX233mFgR6n9lvmzmchebPuZmqgPfM4BshpaJ3UwpABNddnXQ?= =?us-ascii?Q?d1TwsppRnlwdhOiXVYeBRSG5l9/REwj2T1rmWQDkCWibLGICm53I/q2ejQqE?= =?us-ascii?Q?dtJwHnPedssah9ppPk7+X2WPPNzTf59LdSTJdZ8fK1P1iVAST1qxE6uOlUt1?= =?us-ascii?Q?c02hQ7vaLxiKY20FKntbMLMwI6JEKJn667sIuE3ts13lJSqaI0pRbSPg4exK?= =?us-ascii?Q?pqnQvKvafBuJ7DFn4358fA6HlbDPfDkqnfOsHR7eKLBMcDi5E86LzT53ag6C?= =?us-ascii?Q?o2XUhNUXi49QfTXbP0GIAlhHdwtil7c2iCJKqa/ZbU1kGEBYZQfvUD9Lbl/5?= =?us-ascii?Q?jlrbTKZDMxahfnk7zxaRAQZbY6ccESv4mls7JP0nHjoFcG58E5fHrWFRatmG?= =?us-ascii?Q?1smcdaeKO1HElL1tM81/i3pQ3IUy5a64lN+lV08LP5XXNNzX90oc7Kr28JCE?= =?us-ascii?Q?bh1LYyukSWKQfrfNiuNnh5u51o33HkYbj/tQLBuO4aJEIj9LYvcEt/VT9dm7?= =?us-ascii?Q?RJJYODxNq3y8Ak9fJbnkUmxNU032sHt4LBW7EihYbSeGSWPrwXgTvUNtHud9?= =?us-ascii?Q?/XeUycJKY2CpLJZTUSguRPv3kZlbMQFRHqKloTt2tbqO+LuoRO9j+Caj0uGu?= =?us-ascii?Q?DQUZ1zTjT4OrVxfHbIqUQ9A336btOhaHWJgn/bkpNERwGXx3FJ4FLkYWuIH/?= =?us-ascii?Q?FJqqiAVjW+bsJu3RhAt6wffKQRO/tmUlFr8NI3ynL+wLfi6H9/Ofgy1ZZcbN?= =?us-ascii?Q?rLzlxVk6r9wQEtfzwuRmq+Rb?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR02MB2623.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7c492a54-356d-4f79-a8a5-08d8e3b23daf X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Mar 2021 10:49:54.9751 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: WMS2Fo6kaHkPg45inX/X3IskIGUc4RCVdVUiRaqnVCsl//INEG0R22x6L4V0rHooGIZS1nuwLKxHByPa4et3tQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR02MB3149 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Rob, Thanks for providing the review comments. Please find my response inline. > -----Original Message----- > From: Rob Herring > Sent: Tuesday, March 9, 2021 1:50 AM > To: Nava kishore Manne > Cc: mdf@kernel.org; trix@redhat.com; Michal Simek ; > gregkh@linuxfoundation.org; Jolly Shah ; Rajan Vaja > ; arnd@arndb.de; Manish Narani > ; Amit Sunil Dhamne ; Tejas > Patel ; linux-fpga@vger.kernel.org; > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; linux-arm- > kernel@lists.infradead.org; chinnikishore369@gmail.com; Appana Durga > Kedareswara Rao > Subject: Re: [PATCH v3 2/3] dt-bindings: fpga: Add binding doc for versal= fpga > manager >=20 > On Thu, Mar 04, 2021 at 12:32:23PM +0530, Nava kishore Manne wrote: > > From: Appana Durga Kedareswara rao > > > > This patch adds binding doc for versal fpga manager driver. >=20 > Why do you need a DT entry for this? Can't the Versal firmware driver > instantiate the fpga-mgr device? >=20 This dt entry is need to handle the fpga regions properly for both full and= Partial bitstream loading use cases and it cannot be done by Versal firmwa= re driver instantiate. Complete firmware DT node example is shown below for your reference. Example for full FPGA configuration: fpga-region0 { compatible =3D "fpga-region"; fpga-mgr =3D <&versal_fpga>; #address-cells =3D <0x1>; #size-cells =3D <0x1>; }; firmware { zynqmp_firmware: zynqmp-firmware { compatible =3D "xlnx,zynqmp-firmware"; method =3D "smc"; versal_fpga: fpga { compatible =3D "xlnx,versal-fpga"; }; }; }; Please correct me if my understanding is wrong... Regards, Navakishore. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2A9BC433E0 for ; Wed, 10 Mar 2021 10:52:04 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4C10064F7D for ; Wed, 10 Mar 2021 10:52:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4C10064F7D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=xilinx.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References:Message-ID:Date: Subject:CC:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Ina1qX+ou4d+jdjanyrGQfNxSpKsKGTbi8PQU7H/sis=; b=ZtQB6l0aix913xZUb5DMogD/c /BxzpcKyQ22gx0c9nwFKvyNuGPUjbmiUa7M53ETZIBoHpKKFphGCXN10/v4MCV5NtPuT2fntmNODP VFelxIhTKBOzMH52mJx2qkEwuGdM+59epfIBV+gKXaMH8z9/U5RsUnWVUjpkCJ25qAbRzUinXF3Cu A9tVpba2m38zGd4eYlJGXXLXmx6jcMw9ZrNFbatVCpLLmRAfj7alC/PsAxCZT64+WaT84oP0AagG1 X0koA2Xrmg1bLIMXYl9q5UVdKNJaR6zt8DvnpMf1u6S6IXAnXd3uVLNkINM9VSSrF7wmIVEhK+Py1 X0hRnnt5w==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lJwQH-006dbg-4q; Wed, 10 Mar 2021 10:50:37 +0000 Received: from mail-bn7nam10on2069.outbound.protection.outlook.com ([40.107.92.69] helo=NAM10-BN7-obe.outbound.protection.outlook.com) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lJwPi-006dWR-Qu for linux-arm-kernel@lists.infradead.org; Wed, 10 Mar 2021 10:50:04 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GScYG6ptiRA8NIras0eslyXjBjaLDKqRFFrhsVaqvF8HI6+NGk1PBhmUmmz6x95gHtKYJjMiZBlkO2zjdIpXgL5L0tM/DDdVz6AkD34ZibcId0xlfKupZdF3Zbm8NpyVPuI6ZG82LAR0HcDoUi4WtzoFiFhBa+peQ8GKeSTgE5V2oSpUlplMxoMVp/PShofJBY3veTP5WM8s2ItJiN4y0bJtkoDklDdIiJV4UBIjU2+G50UXoi7a28xT50uy5t9M75383J521lPV+a03iP3frJZO1Z1vLJO0z/OHZewxb0EwB0rRf3gk2MKVH89Z/PPMJwqoFrJaLfaRw+ZbJofw3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0ncDHrv0nPwx+g2fs3HBWT71veJK73VQr+TFIgK8q+Y=; b=iOa5KGzsnqtjrilz6toX0YrVTgSqgUb5lti9PrAYIXPSgn+COCuVRYQHZgMFEmUye12PtVEIKO1Lnp3PmJ8t9AejBqNbINtT3PEUj2W2cLMgaDvQDGKoAUqCv134lj83wDvDUQYwj1SBa0XXBwF2a5S9bXAzA4EWfYfwTg0byGAzBVu5kHB5+fj0448cO4CkyPj6BU+EK6szSsgxhKi0rP4+rjI5p2OCoFdkWsHlX6zqU+Ari2z9JeJGYfdlXJ20KUIUnABTZPMiMgCfLvDNNm9TG01RckAQBvznEL8VwsJ7kPXPYzWjDvMh7NQMvg1fqzV+HRkUOjjEaH0PJp/+Sw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=xilinx.com; dmarc=pass action=none header.from=xilinx.com; dkim=pass header.d=xilinx.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0ncDHrv0nPwx+g2fs3HBWT71veJK73VQr+TFIgK8q+Y=; b=GhNEhFjxij1LHZ6rs759QXXZiQVwGc6yliroqrJuus7eWT+GJkWvD93LfLi+hEHa9n7+pWc6toyrGo2CiX7dAkdCLokXbGHiumBpd2ll1WimYsYHCEzMyOlc6z3QZRbbioyv6PKWcLk0TW6oTfpGWI+zKbVJmgd56z3UNt8YAjI= Received: from MWHPR02MB2623.namprd02.prod.outlook.com (2603:10b6:300:44::9) by MWHPR02MB3149.namprd02.prod.outlook.com (2603:10b6:301:62::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.17; Wed, 10 Mar 2021 10:49:55 +0000 Received: from MWHPR02MB2623.namprd02.prod.outlook.com ([fe80::297d:1fb:ad07:1b26]) by MWHPR02MB2623.namprd02.prod.outlook.com ([fe80::297d:1fb:ad07:1b26%9]) with mapi id 15.20.3912.030; Wed, 10 Mar 2021 10:49:55 +0000 From: Nava kishore Manne To: Rob Herring CC: "mdf@kernel.org" , "trix@redhat.com" , Michal Simek , "gregkh@linuxfoundation.org" , Jolly Shah , Rajan Vaja , "arnd@arndb.de" , Manish Narani , Amit Sunil Dhamne , Tejas Patel , "linux-fpga@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "chinnikishore369@gmail.com" , Appana Durga Kedareswara Rao Subject: RE: [PATCH v3 2/3] dt-bindings: fpga: Add binding doc for versal fpga manager Thread-Topic: [PATCH v3 2/3] dt-bindings: fpga: Add binding doc for versal fpga manager Thread-Index: AQHXEMVdMsyP8+vbRE2oyddQhLKezap6jzYAgAKDMvA= Date: Wed, 10 Mar 2021 10:49:54 +0000 Message-ID: References: <20210304070224.22346-1-nava.manne@xilinx.com> <20210304070224.22346-3-nava.manne@xilinx.com> <20210308201944.GA2886704@robh.at.kernel.org> In-Reply-To: <20210308201944.GA2886704@robh.at.kernel.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-TNEF-Correlator: authentication-results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=xilinx.com; x-originating-ip: [149.199.50.130] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 7c492a54-356d-4f79-a8a5-08d8e3b23daf x-ms-traffictypediagnostic: MWHPR02MB3149: x-ld-processed: 657af505-d5df-48d0-8300-c31994686c5c,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6108; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: TE3m84TSrUTUiTY3kfjls8o9AF1T9aj2iEFxQm64YbCfO/AIhpbtTRW2n/OQwPMBWh1cCncRjjP2MpT1gW73zf052YFzCXAyRMSpBH+mL0Pt64jfeQ1TlyB9Uo0qfSezza1J9S4Uw2m6GRh2FfYcQVS4/EycVDXsNKD0kHQIuzmq5ATekdOw89DZyIvVEW3ppUr447HCD9NWyGJWwJMZK2UC1I1KAl4Oo8C4CL86xALmUdwXpJfr72ubxVKmiUm78i2Yz+unRH9Bas6Z32Gmx9vpctkSwV0tM3pMiKPv8vpapMHSCGJKTdYbexxjilG5QMYZqYTvWQ/a30AOrSbnVg2nRs0YyuhNbh9LIbp8jsyhLHiLUEzCO0USPgxI0BU2IAY6Nueextcqg9ECVjfqNGMBBEwfdBSM/R+5wLoBGIF9nYT1x43J2qLiVFqx/41dwEPhawNK/62mFrirnPGPLY60oHidlA6wLSeBEgQ26j9jhaWsA+wBItc5NkH1zDvmL96AGqIlCArtKv5sCuRE5g== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR02MB2623.namprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(136003)(366004)(396003)(376002)(39850400004)(9686003)(8676002)(33656002)(2906002)(54906003)(4326008)(8936002)(6916009)(55016002)(64756008)(53546011)(76116006)(66556008)(66476007)(7696005)(186003)(66946007)(5660300002)(6506007)(66446008)(83380400001)(26005)(316002)(71200400001)(86362001)(52536014)(7416002)(478600001)(107886003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?H3XmiXd2L5Ik5xsmAmRH+4dxrLTPAzt/GIUoG4szw7AKi1lP2iWGcsJzyi4J?= =?us-ascii?Q?Kh39rgVL03u+a6tm0Chk+Tf+qB3CV3lo3qZ4NRzRHS+MKcorBlLD4dwKy2n0?= =?us-ascii?Q?ZAfPtyXWIoARHaT6YAIXn/MWUr4tNA6Hor3LrdGa6B9qir6lQN+X3c7PoeEj?= =?us-ascii?Q?Ug1rCHjWXOJGHFkTG5oa3zmLerB6eZfDbjkm3ktStJPdGHfrBqQx6h8uwpmu?= =?us-ascii?Q?SKmk+q4UH0AJpMJQZi+Yd0x2T2nNefbjyWsuxnFx+R9KNAfXnPlUPuAizyCG?= =?us-ascii?Q?hdpovlWp2lnLZ5xlGAnpmCA3xcXP4GrZbAC0doUkGCR0W61nj64r0nhU47Mk?= =?us-ascii?Q?BdEoTgQ26GIAc27xuyqb41hOmaoV/WMpXvb+wlkSL3HnFvioWVQQDymiGofw?= =?us-ascii?Q?Vzmu3DRYNP9bKwBemUuJ9AiIUXuLIUwp5PrieryXTIo85fKl+1nTWloxdZ3O?= =?us-ascii?Q?hW/sOb7q6agqLvPDLkC5pB7FqA9qhVaGzrLbSR0QLKw+MdjikpX8z2vpuyZ/?= =?us-ascii?Q?ieqxx2EmB/lSX233mFgR6n9lvmzmchebPuZmqgPfM4BshpaJ3UwpABNddnXQ?= =?us-ascii?Q?d1TwsppRnlwdhOiXVYeBRSG5l9/REwj2T1rmWQDkCWibLGICm53I/q2ejQqE?= =?us-ascii?Q?dtJwHnPedssah9ppPk7+X2WPPNzTf59LdSTJdZ8fK1P1iVAST1qxE6uOlUt1?= =?us-ascii?Q?c02hQ7vaLxiKY20FKntbMLMwI6JEKJn667sIuE3ts13lJSqaI0pRbSPg4exK?= =?us-ascii?Q?pqnQvKvafBuJ7DFn4358fA6HlbDPfDkqnfOsHR7eKLBMcDi5E86LzT53ag6C?= =?us-ascii?Q?o2XUhNUXi49QfTXbP0GIAlhHdwtil7c2iCJKqa/ZbU1kGEBYZQfvUD9Lbl/5?= =?us-ascii?Q?jlrbTKZDMxahfnk7zxaRAQZbY6ccESv4mls7JP0nHjoFcG58E5fHrWFRatmG?= =?us-ascii?Q?1smcdaeKO1HElL1tM81/i3pQ3IUy5a64lN+lV08LP5XXNNzX90oc7Kr28JCE?= =?us-ascii?Q?bh1LYyukSWKQfrfNiuNnh5u51o33HkYbj/tQLBuO4aJEIj9LYvcEt/VT9dm7?= =?us-ascii?Q?RJJYODxNq3y8Ak9fJbnkUmxNU032sHt4LBW7EihYbSeGSWPrwXgTvUNtHud9?= =?us-ascii?Q?/XeUycJKY2CpLJZTUSguRPv3kZlbMQFRHqKloTt2tbqO+LuoRO9j+Caj0uGu?= =?us-ascii?Q?DQUZ1zTjT4OrVxfHbIqUQ9A336btOhaHWJgn/bkpNERwGXx3FJ4FLkYWuIH/?= =?us-ascii?Q?FJqqiAVjW+bsJu3RhAt6wffKQRO/tmUlFr8NI3ynL+wLfi6H9/Ofgy1ZZcbN?= =?us-ascii?Q?rLzlxVk6r9wQEtfzwuRmq+Rb?= MIME-Version: 1.0 X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR02MB2623.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7c492a54-356d-4f79-a8a5-08d8e3b23daf X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Mar 2021 10:49:54.9751 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: WMS2Fo6kaHkPg45inX/X3IskIGUc4RCVdVUiRaqnVCsl//INEG0R22x6L4V0rHooGIZS1nuwLKxHByPa4et3tQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR02MB3149 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210310_105003_218037_C9F201C8 X-CRM114-Status: GOOD ( 14.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Rob, Thanks for providing the review comments. Please find my response inline. > -----Original Message----- > From: Rob Herring > Sent: Tuesday, March 9, 2021 1:50 AM > To: Nava kishore Manne > Cc: mdf@kernel.org; trix@redhat.com; Michal Simek ; > gregkh@linuxfoundation.org; Jolly Shah ; Rajan Vaja > ; arnd@arndb.de; Manish Narani > ; Amit Sunil Dhamne ; Tejas > Patel ; linux-fpga@vger.kernel.org; > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; linux-arm- > kernel@lists.infradead.org; chinnikishore369@gmail.com; Appana Durga > Kedareswara Rao > Subject: Re: [PATCH v3 2/3] dt-bindings: fpga: Add binding doc for versal fpga > manager > > On Thu, Mar 04, 2021 at 12:32:23PM +0530, Nava kishore Manne wrote: > > From: Appana Durga Kedareswara rao > > > > This patch adds binding doc for versal fpga manager driver. > > Why do you need a DT entry for this? Can't the Versal firmware driver > instantiate the fpga-mgr device? > This dt entry is need to handle the fpga regions properly for both full and Partial bitstream loading use cases and it cannot be done by Versal firmware driver instantiate. Complete firmware DT node example is shown below for your reference. Example for full FPGA configuration: fpga-region0 { compatible = "fpga-region"; fpga-mgr = <&versal_fpga>; #address-cells = <0x1>; #size-cells = <0x1>; }; firmware { zynqmp_firmware: zynqmp-firmware { compatible = "xlnx,zynqmp-firmware"; method = "smc"; versal_fpga: fpga { compatible = "xlnx,versal-fpga"; }; }; }; Please correct me if my understanding is wrong... Regards, Navakishore. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel