From: "Saleem, Shiraz" <shiraz.saleem@intel.com>
To: Jason Gunthorpe <jgg@nvidia.com>,
"Nikolova, Tatyana E" <tatyana.e.nikolova@intel.com>,
"Hefty, Sean" <sean.hefty@intel.com>,
"Rimmer, Todd" <todd.rimmer@intel.com>
Cc: "dledford@redhat.com" <dledford@redhat.com>,
"leon@kernel.org" <leon@kernel.org>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>
Subject: RE: [PATCH v2 rdma-core] irdma: Add ice and irdma to kernel-boot rules
Date: Fri, 13 Jan 2023 23:57:33 +0000 [thread overview]
Message-ID: <MWHPR11MB002952D469591FEF43EBC6F6E9C29@MWHPR11MB0029.namprd11.prod.outlook.com> (raw)
In-Reply-To: <Y2uu4HfKADHiCzGx@nvidia.com>
> Subject: Re: [PATCH v2 rdma-core] irdma: Add ice and irdma to kernel-boot rules
>
> On Wed, Nov 02, 2022 at 04:40:20PM +0000, Nikolova, Tatyana E wrote:
> > Hi Jason,
> >
> > I know it has been a while since we discussed this. Based on your feedback, we
> are proposing another solution for the irdma kernel-boot rules. Could you please
> review it?
> >
> > > > udevadm info --attribute-walk /sys/class/infiniband/rocep47s0f0
> > > >
> > > > looking at device
> > > '/devices/pci0000:2e/0000:2e:00.0/0000:2f:00.0/infiniband/rocep47s0f0':
> > >
> > > This looks like the problem. For any of this to work the infiniband
> > > device needs to be parented to the aux device, not the PCI device.
> > >
> > > mlx5 did not due this for backwards compat reasons, but this is a
> > > new driver so it could do it properly.
> > >
Hi Jason - This also impacts us in terms of backwards compatibility.
There are current applications/customers who are looking at "'/sys/class/infiniband/<ib_device>/device/"
for sysfs attributes like numa_node, local_cpus etc. under the PCI device.
i.e. assuming the PCI device is ib device parent.
With parent change to auxiliary device, they won't be able find these attributes and potentially resort to default
configurations that are sub-optimal.
Shiraz
next prev parent reply other threads:[~2023-01-13 23:57 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-23 15:48 [PATCH v2 rdma-core] irdma: Add ice and irdma to kernel-boot rules Tatyana Nikolova
2021-08-23 16:11 ` Jason Gunthorpe
2021-09-02 15:29 ` Nikolova, Tatyana E
2021-09-02 15:40 ` Jason Gunthorpe
2021-09-20 19:41 ` Nikolova, Tatyana E
2021-09-20 23:23 ` Jason Gunthorpe
2021-10-14 20:11 ` Nikolova, Tatyana E
2021-10-14 23:36 ` Jason Gunthorpe
2022-11-02 16:40 ` Nikolova, Tatyana E
2022-11-09 13:45 ` Jason Gunthorpe
2023-01-13 23:57 ` Saleem, Shiraz [this message]
2023-01-14 0:01 ` Jason Gunthorpe
2023-01-17 20:27 ` Saleem, Shiraz
2023-01-20 18:02 ` Jason Gunthorpe
2021-09-02 16:03 ` Leon Romanovsky
2021-09-02 16:13 ` Nikolova, Tatyana E
2021-09-02 23:23 ` Leon Romanovsky
2021-10-10 9:42 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MWHPR11MB002952D469591FEF43EBC6F6E9C29@MWHPR11MB0029.namprd11.prod.outlook.com \
--to=shiraz.saleem@intel.com \
--cc=dledford@redhat.com \
--cc=jgg@nvidia.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=sean.hefty@intel.com \
--cc=tatyana.e.nikolova@intel.com \
--cc=todd.rimmer@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.