From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60DEFC76186 for ; Wed, 17 Jul 2019 12:47:48 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id A9C2C205F4 for ; Wed, 17 Jul 2019 12:47:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=cisco.com header.i=@cisco.com header.b="ZN/8gU9S"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=cisco.onmicrosoft.com header.i=@cisco.onmicrosoft.com header.b="FaVWvBAE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A9C2C205F4 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=cisco.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 24FA71B993; Wed, 17 Jul 2019 14:47:46 +0200 (CEST) Received: from rcdn-iport-6.cisco.com (rcdn-iport-6.cisco.com [173.37.86.77]) by dpdk.org (Postfix) with ESMTP id AB1D31B993 for ; Wed, 17 Jul 2019 14:47:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=2708; q=dns/txt; s=iport; t=1563367664; x=1564577264; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=ImwBfYczr8dUqVCK5wDi2/u24+K/bEVhlUcpzMcisao=; b=ZN/8gU9SxD0R4knDT5fxPGnrgY9GykhKDO74+dG8nTz1rCy1aPUlT5ve qg1LVRBbWxHV6e1AZILoYKPSXzZJvwkaNMVu6MZEC3Y/WMBtrHLCDf3fx nf5FKHZRbzGUyd5C6FtsFIiCR4P8i7RXPxVe7VyiQiPMLjM++xUBP0sRP Y=; IronPort-PHdr: =?us-ascii?q?9a23=3AqN1IZxVgJsCNgdcYRRJxgIO5XffV8LGuZFwc94?= =?us-ascii?q?YnhrRSc6+q45XlOgnF6O5wiEPSA92J8OpK3uzRta2oGXcN55qMqjgjSNRNTF?= =?us-ascii?q?dE7KdehAk8GIiAAEz/IuTtank6DcNEV15g13q6KkNSXs35Yg6arw=3D=3D?= X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0BLAwCwFy9d/5ldJa1lHAEBAQQBAQc?= =?us-ascii?q?EAQGBVgQBAQsBgUNQA21VIAQLKodjA418gluXUIJSA1QJAQEBDAEBGxICAQG?= =?us-ascii?q?DP4EBAoJFIzcGDgEDAQEEAQECAQVthTwMhUoBAQEBAxIVEwYBATcBCwQCAQg?= =?us-ascii?q?OAwQBAR8QMh0IAgQBDQUIGoMBgWoDHQGiHgKBOIhggXAzgnkBAQWBBQEBhAo?= =?us-ascii?q?YghMJgTQBi14XgUA/gRABRoJMPoRGJIMXgiaqZwkCghmGWI1PgxqUcI01l1A?= =?us-ascii?q?CBAIEBQIOAQEFgWYigVhwFYMnCYI4gxNeihwBNnKBKY1HAQE?= X-IronPort-AV: E=Sophos;i="5.64,274,1559520000"; d="scan'208";a="596679118" Received: from rcdn-core-2.cisco.com ([173.37.93.153]) by rcdn-iport-6.cisco.com with ESMTP/TLS/DHE-RSA-SEED-SHA; 17 Jul 2019 12:47:43 +0000 Received: from XCH-ALN-004.cisco.com (xch-aln-004.cisco.com [173.36.7.14]) by rcdn-core-2.cisco.com (8.15.2/8.15.2) with ESMTPS id x6HClh4b001713 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=FAIL); Wed, 17 Jul 2019 12:47:43 GMT Received: from xhs-aln-002.cisco.com (173.37.135.119) by XCH-ALN-004.cisco.com (173.36.7.14) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Wed, 17 Jul 2019 07:47:42 -0500 Received: from xhs-rtp-002.cisco.com (64.101.210.229) by xhs-aln-002.cisco.com (173.37.135.119) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Wed, 17 Jul 2019 07:47:42 -0500 Received: from NAM04-CO1-obe.outbound.protection.outlook.com (64.101.32.56) by xhs-rtp-002.cisco.com (64.101.210.229) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Wed, 17 Jul 2019 08:47:42 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XMHGEPlX5SqwX0USB0zOffaWzsRHZ2jyq9debamM86/I6SZNbtqmVxCdVWRtZQCH0gGTp/viv7v75fuXVAIae/b/pX72rcEWlVv82RlPSYCKmDrXy3wHvVwR5g2+hRvr6Ihqcum51fdbZdQN8oyat23CWMHm449F+2k/92P1dHZ14tzsCocrceqmysAqI5c0mCYyIpO5tXK9/mrWogKbtIcMg0fUoMpH051tjCRrWcuaWaQcIgNtE9W8XvSArJF1Wszz+9cP4cE1yvbsTyCVEA+ELfYv05mqCDr1oDmT1NXmL+zlbIdHWnwGFHeQWo5dLhc/PW8f0jr0bd1RWQHa0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gIcRAU51afbmAwDhvVEInopspEE6ZPtrnQTY7p3Emqg=; b=d65ZmkoNqj8UbMM6m8DmiCHu5Sq4CyRUvDemkbBQ92a1R47AJ0cYJuGamUpMgHbj8vhEGMJj7RG9/jxQWq7Pu6dsFQSDMFtfr7O0XIr6KF1o3GvgEK0YaNN/fnAGCs62RQGSxnszNg4eRwn4DTwQCjwhJiqpJO4oTwfqKPZ7h4sM0tQcZp3wcg1UZrnW13mCS7EavRmdgmb0/tipU2mVorKd2psBKxwC5NSsVm8INn8rVGAOBUw3SRs61JQw43n9zLYvsYZqclHrUaJXsDUBH+58DZ3JYCRomMrKWCTSo8b8YOqQyx3To4ma/LmDZciBJDHWka6ZGNqzkwnUuy7l4Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=cisco.com;dmarc=pass action=none header.from=cisco.com;dkim=pass header.d=cisco.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cisco.onmicrosoft.com; s=selector2-cisco-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gIcRAU51afbmAwDhvVEInopspEE6ZPtrnQTY7p3Emqg=; b=FaVWvBAEjhQ0RwgJWIhx5CpYQSqLqZuRgSTzrUv2B/mHy9TKLgBVmLOrfVgl9iLrcTQi/9iFV4kl4lMxBrpa+mZs8tb62PNhbIbp42SJHl9YcwVwzlQl4nwrQTdIQl+UHke61fgFArbum/n434sVCiriEM6Fskax0tUJvMeUXmg= Received: from MWHPR11MB1839.namprd11.prod.outlook.com (10.175.53.12) by MWHPR11MB0063.namprd11.prod.outlook.com (10.164.204.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2073.11; Wed, 17 Jul 2019 12:47:40 +0000 Received: from MWHPR11MB1839.namprd11.prod.outlook.com ([fe80::3cef:35b5:8800:39f1]) by MWHPR11MB1839.namprd11.prod.outlook.com ([fe80::3cef:35b5:8800:39f1%6]) with mapi id 15.20.2094.011; Wed, 17 Jul 2019 12:47:40 +0000 From: "Hyong Youb Kim (hyonkim)" To: Nithin Dabilpuram , David Marchand , Thomas Monjalon , "Ferruh Yigit" , Igor Russkikh , Pavel Belous , Allain Legacy , Matt Peters , "Ravi Kumar" , Rasesh Mody , Shahed Shaikh , Wenzhuo Lu , Qi Zhang , Xiao Wang , Beilei Xing , Jingjing Wu , Qiming Yang , Konstantin Ananyev , Alejandro Lucero , Andrew Rybchenko , Maxime Coquelin , Tiwei Bie , Zhihong Wang , "Yong Wang" CC: "jerinj@marvell.com" , "John Daley (johndale)" , "dev@dpdk.org" Thread-Topic: [PATCH 3/3] drivers/net: use ack API in interrupt handlers Thread-Index: AQHVPJdOh/MgGNko30a/BHbJ+dkTf6bOwDCQ Date: Wed, 17 Jul 2019 12:47:40 +0000 Message-ID: References: <20190717115852.171416-1-ndabilpuram@marvell.com> <20190717115852.171416-4-ndabilpuram@marvell.com> In-Reply-To: <20190717115852.171416-4-ndabilpuram@marvell.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=hyonkim@cisco.com; x-originating-ip: [2001:420:c0dc:1001::133] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 3c8deeed-450a-4b76-241e-08d70ab4f44d x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:MWHPR11MB0063; x-ms-traffictypediagnostic: MWHPR11MB0063: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3826; x-forefront-prvs: 01018CB5B3 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(366004)(39860400002)(376002)(396003)(346002)(136003)(13464003)(199004)(189003)(71190400001)(110136005)(71200400001)(99286004)(54906003)(256004)(316002)(446003)(6116002)(229853002)(102836004)(7696005)(8936002)(81156014)(25786009)(55016002)(86362001)(66446008)(8676002)(53936002)(6436002)(76176011)(9686003)(76116006)(68736007)(476003)(305945005)(478600001)(7736002)(74316002)(486006)(2906002)(64756008)(4326008)(6506007)(186003)(6246003)(14454004)(81166006)(66556008)(5660300002)(7416002)(52536014)(11346002)(66476007)(66946007)(53546011)(33656002)(46003)(921003)(1121003); DIR:OUT; SFP:1101; SCL:1; SRVR:MWHPR11MB0063; H:MWHPR11MB1839.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: cisco.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: vJSw/gP7M5bUpxF2GJULGFQILmCbUNsMrzdvfR+Du/lvMLfkRbSoFM2jAjth4A7kXLWH4EzXt9Snyn/P5fgViJ43I7wqwbCvDhwD5sxQfazfVvsP291uGXDEtPWE3beQ/A1Oor/JGdS+fY/8pAeHNq8XbAoNZb0LXHCS7TzRES9x8DwbU/iPQ7I4w2rbhv1Vi9Hd53FBDPDpg4efREZjxbswBl7zvUKXrf1uKnNrzKUplDh0S7vCRoFnt1WiN69qeNMyBBjHph7029NXRK74vD7gmwKqqlYGAdh3/G28GK2TLHlMP5Xc4UF1ihxSlL0qvQ/su7AOhu1tz38aLZ8iBR5bnc592VbsVrpQCEU54pvyXR08DhMV+PBNkvFKnGSZJv27T82UldqiuSqq72jE8ELGZZG1BX8XvU4cPHHnW/Q= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 3c8deeed-450a-4b76-241e-08d70ab4f44d X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Jul 2019 12:47:40.3290 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 5ae1af62-9505-4097-a69a-c1553ef7840e X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: hyonkim@cisco.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB0063 X-OriginatorOrg: cisco.com X-Outbound-SMTP-Client: 173.36.7.14, xch-aln-004.cisco.com X-Outbound-Node: rcdn-core-2.cisco.com Subject: Re: [dpdk-dev] [PATCH 3/3] drivers/net: use ack API in interrupt handlers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Nithin Dabilpuram > Sent: Wednesday, July 17, 2019 8:59 PM [...] > Subject: [PATCH 3/3] drivers/net: use ack API in interrupt handlers >=20 > Replace rte_intr_enable() with rte_intr_ack() API > for acking an interrupt in interrupt handlers and > rx_queue_intr_enable() callbacks of PMD's. >=20 > This is inline with original intent of this change in PMDs > to ack interrupts after handling is completed if > device is backed by UIO, IGB_UIO or VFIO(with INTx). >=20 > Signed-off-by: Nithin Dabilpuram > Signed-off-by: Jerin Jacob > --- > drivers/net/atlantic/Makefile | 1 + > drivers/net/atlantic/atl_ethdev.c | 2 +- > drivers/net/atlantic/meson.build | 2 ++ > drivers/net/avp/avp_ethdev.c | 2 +- > drivers/net/avp/meson.build | 1 + > drivers/net/axgbe/Makefile | 1 + > drivers/net/axgbe/axgbe_ethdev.c | 4 ++-- > drivers/net/axgbe/meson.build | 1 + > drivers/net/bnx2x/bnx2x_ethdev.c | 2 +- > drivers/net/bnx2x/meson.build | 1 + > drivers/net/e1000/em_ethdev.c | 4 ++-- > drivers/net/e1000/igb_ethdev.c | 6 +++--- > drivers/net/fm10k/fm10k_ethdev.c | 6 +++--- > drivers/net/fm10k/meson.build | 1 + > drivers/net/i40e/i40e_ethdev.c | 2 +- > drivers/net/iavf/iavf_ethdev.c | 2 +- > drivers/net/ice/Makefile | 1 + > drivers/net/ice/ice_ethdev.c | 4 ++-- > drivers/net/ice/meson.build | 1 + > drivers/net/ixgbe/ixgbe_ethdev.c | 6 +++--- > drivers/net/nfp/nfp_net.c | 2 +- > drivers/net/qede/Makefile | 1 + > drivers/net/qede/meson.build | 2 ++ > drivers/net/qede/qede_ethdev.c | 8 ++++---- > drivers/net/sfc/sfc_intr.c | 4 ++-- > drivers/net/virtio/virtio_ethdev.c | 16 +++++++++++++++- > drivers/net/vmxnet3/vmxnet3_ethdev.c | 2 +- > 27 files changed, 56 insertions(+), 29 deletions(-) >=20 [...] > diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c > index 1a7aa17..91a226c 100644 > --- a/drivers/net/nfp/nfp_net.c > +++ b/drivers/net/nfp/nfp_net.c > @@ -1412,7 +1412,7 @@ nfp_net_irq_unmask(struct rte_eth_dev *dev) > if (hw->ctrl & NFP_NET_CFG_CTRL_MSIXAUTO) { > /* If MSI-X auto-masking is used, clear the entry */ > rte_wmb(); > - rte_intr_enable(&pci_dev->intr_handle); > + rte_intr_ack(&pci_dev->intr_handle); > } else { > /* Make sure all updates are written before un-masking */ > rte_wmb(); This part really needs ack/testing by nfp folks. [...] -Hyong