From: "Lee Chee Yang" <chee.yang.lee@intel.com>
To: Paul Barker <pbarker@konsulko.com>,
"openembedded-core@lists.openembedded.org"
<openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] [PATCH 1/6] wic: Add workdir argument
Date: Mon, 11 Jan 2021 14:17:29 +0000 [thread overview]
Message-ID: <MWHPR11MB20008B3181D901FA9C20BC8CB9AB0@MWHPR11MB2000.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20210111103247.11685-1-pbarker@konsulko.com>
You might want to update scripts/lib/wic/help.py with description for this new features too
>-----Original Message-----
>From: openembedded-core@lists.openembedded.org <openembedded-
>core@lists.openembedded.org> On Behalf Of Paul Barker
>Sent: Monday, 11 January, 2021 6:33 PM
>To: openembedded-core@lists.openembedded.org
>Cc: Paul Barker <pbarker@konsulko.com>
>Subject: [OE-core] [PATCH 1/6] wic: Add workdir argument
>
>This allows the path for the temporary workdir used by wic to be set when
>running wic from bitbake or directly from the command line.
>
>Signed-off-by: Paul Barker <pbarker@konsulko.com>
>---
> scripts/lib/wic/plugins/imager/direct.py | 2 +-
> scripts/wic | 2 ++
> 2 files changed, 3 insertions(+), 1 deletion(-)
>
>diff --git a/scripts/lib/wic/plugins/imager/direct.py
>b/scripts/lib/wic/plugins/imager/direct.py
>index 0ca67b77d5..b329568c7a 100644
>--- a/scripts/lib/wic/plugins/imager/direct.py
>+++ b/scripts/lib/wic/plugins/imager/direct.py
>@@ -62,7 +62,7 @@ class DirectPlugin(ImagerPlugin):
>
> self.name = "%s-%s" % (os.path.splitext(os.path.basename(wks_file))[0],
> strftime("%Y%m%d%H%M"))
>- self.workdir = tempfile.mkdtemp(dir=self.outdir, prefix='tmp.wic.')
>+ self.workdir = options.workdir or
>+ tempfile.mkdtemp(dir=self.outdir, prefix='tmp.wic.')
> self._image = None
> self.ptable_format = self.ks.bootloader.ptable
> self.parts = self.ks.partitions diff --git a/scripts/wic b/scripts/wic index
>24700f380f..a741aed364 100755
>--- a/scripts/wic
>+++ b/scripts/wic
>@@ -312,6 +312,8 @@ def wic_init_parser_create(subparser):
>
> subparser.add_argument("-o", "--outdir", dest="outdir", default='.',
> help="name of directory to create image in")
>+ subparser.add_argument("-w", "--workdir",
>+ help="temporary workdir to use for intermediate
>+ files")
> subparser.add_argument("-e", "--image-name", dest="image_name",
> help="name of the image to use the artifacts from "
> "e.g. core-image-sato")
>--
>2.26.2
next prev parent reply other threads:[~2021-01-11 14:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-11 10:32 [PATCH 1/6] wic: Add workdir argument Paul Barker
2021-01-11 10:32 ` [PATCH 2/6] image_types_wic: Move wic working directory Paul Barker
2021-01-11 10:32 ` [PATCH 3/6] wic: Allow exec_native_cmd to run HOSTTOOLS Paul Barker
2021-01-11 10:32 ` [PATCH 4/6] wic: Update pseudo db when excluding content from rootfs Paul Barker
2021-01-11 10:32 ` [PATCH 5/6] wic: Copy rootfs dir if fstab needs updating Paul Barker
2021-01-11 10:32 ` [PATCH 6/6] wic: Optimise fstab modification for ext2/3/4 and msdos partitions Paul Barker
2021-01-11 10:36 ` [OE-core] " Alexander Kanavin
[not found] ` <16592723997B4DF6.2879@lists.openembedded.org>
2021-01-11 10:37 ` Alexander Kanavin
2021-01-11 10:40 ` Paul Barker
2021-01-11 14:17 ` Lee Chee Yang [this message]
2021-01-11 14:22 ` [OE-core] [PATCH 1/6] wic: Add workdir argument Paul Barker
2021-01-11 14:33 ` Paul Barker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MWHPR11MB20008B3181D901FA9C20BC8CB9AB0@MWHPR11MB2000.namprd11.prod.outlook.com \
--to=chee.yang.lee@intel.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=pbarker@konsulko.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.