From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, HTML_MESSAGE,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F9CCC43603 for ; Mon, 9 Dec 2019 22:10:00 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E0EE9206D5 for ; Mon, 9 Dec 2019 22:09:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E0EE9206D5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=amd.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=amd-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9FA276E56D; Mon, 9 Dec 2019 22:09:59 +0000 (UTC) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2082.outbound.protection.outlook.com [40.107.243.82]) by gabe.freedesktop.org (Postfix) with ESMTPS id 92FF46E56D for ; Mon, 9 Dec 2019 22:09:58 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DJdeGdjtBCwOJJ0ecHrgwSoOZL4ZakrAzQASZs1pvgNinA/0TDIHIJXtIeQat7otltewuXVBwZyv60WaPCJqZTEBz51Edzs2u9TH5BSjnrfC/UZYlFNQdrpYJ3AhRPJOyJvyxbpxTFImqFitND5RrVptVPk/wyA565iY9fix3iHvhpEcwkGBbAH2foHM7Eu+OY2DHI6pYUmbTvc7w1hIkZMb+5NPtu0eiyLmGW8Ovv6hOhI+ZpSH96CtrmVduDRWcOpU8dEKYVGz0wJ0mtVS6VWZoYBxEzJ39480WOPp+kHpmeD0iz5RbAZ4LhB2DchGAVgTpwvcpKLT572DXgcoFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MAOOalcIOb2rQDnwh4eefPtSSrPlk8TyhhsVc8nDoOo=; b=JP/4VCMhYg9K2pCmkaCe5OeSUWxzHeeEfQqDWBx/KwVZDgIr6uphpVmXrat8lOCXT6MHun4JPu5pOZXURfPZU5NrBPmQnMzMn3yGK3iU1c5oxqGEnvOa2ELtbmOrbjyOxpjUljOeOXXeVon1KC1+0FAegf9F3PARg4MGm0+N0OBJZlPq+ChI9DLPenVL4EQD24Z/uWaohResrFIwbJfitQQeT0D/PNpueWk/MMnkp9588iS1k0vMkdnd5lbB5x1WGi1nX6O5Xg3sny+BN51iD6NqQlPmDIA0ydjrPRWOohIKlos6pQdUNz8RiIPdW54XSsQnlORHCVQ1IpbUmRbo1g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none Received: from MWHPR12MB1358.namprd12.prod.outlook.com (10.169.203.148) by MWHPR12MB1374.namprd12.prod.outlook.com (10.169.206.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2516.13; Mon, 9 Dec 2019 22:09:57 +0000 Received: from MWHPR12MB1358.namprd12.prod.outlook.com ([fe80::b94d:fcd8:729d:a94f]) by MWHPR12MB1358.namprd12.prod.outlook.com ([fe80::b94d:fcd8:729d:a94f%3]) with mapi id 15.20.2516.018; Mon, 9 Dec 2019 22:09:57 +0000 From: "Deucher, Alexander" To: "Liu, Leo" , "amd-gfx@lists.freedesktop.org" Subject: Re: [PATCH 2/2] drm/amdgpu: fix JPEG instance checking when ctx init Thread-Topic: [PATCH 2/2] drm/amdgpu: fix JPEG instance checking when ctx init Thread-Index: AQHVrtVTelBXb8yLIkKhRJ5oXr+jOqeyVk7tgAAGvgk= Date: Mon, 9 Dec 2019 22:09:56 +0000 Message-ID: References: <20191209211048.6937-1-leo.liu@amd.com>, <20191209211048.6937-2-leo.liu@amd.com>, In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_76546daa-41b6-470c-bb85-f6f40f044d7f_Enabled=True; MSIP_Label_76546daa-41b6-470c-bb85-f6f40f044d7f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_76546daa-41b6-470c-bb85-f6f40f044d7f_SetDate=2019-12-09T22:09:55.919Z; MSIP_Label_76546daa-41b6-470c-bb85-f6f40f044d7f_Name=Internal Distribution Only; MSIP_Label_76546daa-41b6-470c-bb85-f6f40f044d7f_ContentBits=0; MSIP_Label_76546daa-41b6-470c-bb85-f6f40f044d7f_Method=Standard; x-originating-ip: [71.219.59.120] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 1648288e-01e0-4227-c1a5-08d77cf486bf x-ms-traffictypediagnostic: MWHPR12MB1374:|MWHPR12MB1374: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5236; x-forefront-prvs: 02462830BE x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(396003)(366004)(39860400002)(136003)(346002)(376002)(199004)(189003)(81166006)(8936002)(81156014)(478600001)(33656002)(110136005)(8676002)(9686003)(71200400001)(7696005)(55016002)(71190400001)(966005)(2906002)(53546011)(26005)(6506007)(316002)(66556008)(66476007)(186003)(52536014)(5660300002)(45080400002)(64756008)(66946007)(66446008)(86362001)(19627405001)(2940100002)(76116006)(229853002); DIR:OUT; SFP:1101; SCL:1; SRVR:MWHPR12MB1374; H:MWHPR12MB1358.namprd12.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: amd.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: eghNXd5u69WwTQZg+GJyt9MYFQVuyOVaqmAKB/L2ohttUAieHsgKzDvHp+pX5j1h9j6wjX8QzdZbV3oDZ7wzuZHY0eoIrRrmoUqS1j6Sf1xbRh2QpF1k7MNwdzQpSPMFtYkaMqiwb8EOUMmRdW/lBCw/fh2NtCI+5tLRz0aolhqNJsObiJ8yRcAwVlY/eBoqYuxJHQ9X3VEGDEdMzHOMTcjrodEHsGx73ASGEeRn3oWI+8M1CcO5JtDIF7FTrCKB606KFghawj9CXwq6us+crkZJm3XJJVp24Ijr8Ljwu3ATYQM6k2rz7dKStrTBBPvXPd9LlXddq/U2yZbwYGRMMZ/jCqoMWExh53/Oaqy1C0FYoHE7voDBwviPjrZ2idkTsBBOSf9FnuhiRNORrMO9Q18BCtmEGcEdCZ0vje1Azh6bWUKkzPE8FvkuhY2ZcQXkw/PRWfe8DY0Lx32g6itpex4PQbkmSCSdvOdERdVUDkw= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1648288e-01e0-4227-c1a5-08d77cf486bf X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Dec 2019 22:09:56.8853 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: u17Z8A8LwZY7adKsGhz41YLYF3hf/Q9Z3mbqQrLokFv2beU8ZqAKxfvjkibvU7z94DjbUEhmEoC5B3uQUutR3Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR12MB1374 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector2-amdcloud-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MAOOalcIOb2rQDnwh4eefPtSSrPlk8TyhhsVc8nDoOo=; b=BrOE603NBAsdFwr6vMMLvj1Lz78Ey18/OWiW3nMIeAjA7Blflmqbv3ytlArW/zN9fu+xOUPOhZojdaihuREIX0qTZdFEOAQ3F8L9z9whTWhbHKZAS7ZeZQjQqmsU8Td9GSsyOfc2vAtlPaeLBjwRg5Vg3aNI6R0ZV0tm58mDb2s= X-Mailman-Original-Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Alexander.Deucher@amd.com; X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============1285095981==" Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" --===============1285095981== Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_MWHPR12MB1358F3B35B1B3EE1DD558D5CF7580MWHPR12MB1358namp_" --_000_MWHPR12MB1358F3B35B1B3EE1DD558D5CF7580MWHPR12MB1358namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable forgot to add RB for the series. Alex ________________________________ From: amd-gfx on behalf of Deucher,= Alexander Sent: Monday, December 9, 2019 4:45 PM To: Liu, Leo ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 2/2] drm/amdgpu: fix JPEG instance checking when ctx in= it [AMD Official Use Only - Internal Distribution Only] Reviewed-by: Alex Deucher ________________________________ From: amd-gfx on behalf of Leo Liu = Sent: Monday, December 9, 2019 4:10 PM To: amd-gfx@lists.freedesktop.org Cc: Liu, Leo Subject: [PATCH 2/2] drm/amdgpu: fix JPEG instance checking when ctx init Fixes: 0388aee76("drm/amdgpu: use the JPEG structure for general driver support") Signed-off-by: Leo Liu --- drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c b/drivers/gpu/drm/amd/= amdgpu/amdgpu_ctx.c index a0d3d7b756eb..db4b6283c28c 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c @@ -170,7 +170,7 @@ static int amdgpu_ctx_init(struct amdgpu_device *adev, break; case AMDGPU_HW_IP_VCN_JPEG: for (j =3D 0; j < adev->jpeg.num_jpeg_inst; ++j) { - if (adev->vcn.harvest_config & (1 << j)) + if (adev->jpeg.harvest_config & (1 << j)) continue; rings[num_rings++] =3D &adev->jpeg.inst[j]= .ring_dec; } -- 2.17.1 _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Flists.f= reedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=3D02%7C01%7Calexande= r.deucher%40amd.com%7Ca5db83292d3844d8955908d77cec5306%7C3dd8961fe4884e608e= 11a82d994e183d%7C0%7C0%7C637115227328960060&sdata=3DmWsj0v7AxwKQVL1FzSn= %2F6QhASdd4NxUQmMl9pCX7vTQ%3D&reserved=3D0 --_000_MWHPR12MB1358F3B35B1B3EE1DD558D5CF7580MWHPR12MB1358namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable
forgot to add RB for the series.

Alex
From: amd-gfx <amd-gfx-b= ounces@lists.freedesktop.org> on behalf of Deucher, Alexander <Alexan= der.Deucher@amd.com>
Sent: Monday, December 9, 2019 4:45 PM
To: Liu, Leo <Leo.Liu@amd.com>; amd-gfx@lists.freedesktop.org = <amd-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 2/2] drm/amdgpu: fix JPEG instance checking when= ctx init
 

[AMD Official Use Only - Internal Distribution Only]


Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
From: amd-gfx <amd-gfx= -bounces@lists.freedesktop.org> on behalf of Leo Liu <leo.liu@amd.com= >
Sent: Monday, December 9, 2019 4:10 PM
To: amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org&= gt;
Cc: Liu, Leo <Leo.Liu@amd.com>
Subject: [PATCH 2/2] drm/amdgpu: fix JPEG instance checking when ctx= init
 
Fixes: 0388aee76("drm/amdgpu: use the JPEG = structure for
general driver support")

Signed-off-by: Leo Liu <leo.liu@amd.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c b/drivers/gpu/drm/amd/= amdgpu/amdgpu_ctx.c
index a0d3d7b756eb..db4b6283c28c 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c
@@ -170,7 +170,7 @@ static int amdgpu_ctx_init(struct amdgpu_device *ad= ev,
            &nb= sp;            break= ;
            &nb= sp;    case AMDGPU_HW_IP_VCN_JPEG:
            &nb= sp;            for (= j =3D 0; j < adev->jpeg.num_jpeg_inst; ++j) {
-            &n= bsp;            = ;      if (adev->vcn.harvest_config & (1 &l= t;< j))
+           &nbs= p;            &= nbsp;      if (adev->jpeg.harvest_config & = (1 << j))
            &nb= sp;            =             &nb= sp;   continue;
            &nb= sp;            =         rings[num_rings++] =3D &= amp;adev->jpeg.inst[j].ring_dec;
            &nb= sp;            }
--
2.17.1

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://nam11.safelinks.protection.outlook.com/?url=3Dht= tps%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&amp;da= ta=3D02%7C01%7Calexander.deucher%40amd.com%7Ca5db83292d3844d8955908d77cec53= 06%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637115227328960060&amp;= sdata=3DmWsj0v7AxwKQVL1FzSn%2F6QhASdd4NxUQmMl9pCX7vTQ%3D&amp;reserved= =3D0
--_000_MWHPR12MB1358F3B35B1B3EE1DD558D5CF7580MWHPR12MB1358namp_-- --===============1285095981== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KYW1kLWdmeCBt YWlsaW5nIGxpc3QKYW1kLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9hbWQtZ2Z4 --===============1285095981==--