From mboxrd@z Thu Jan 1 00:00:00 1970 From: Casey Leedom Subject: Re: [PATCH] iommu/vt-d: Fix scatterlist offset handling Date: Fri, 29 Sep 2017 16:18:16 +0000 Message-ID: References: <644c3e01654f8bd48d669c36e424959d6ef0e27e.1506607370.git.robin.murphy@arm.com>, Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org" , "linux-crypto-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org" , "herbert-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org" To: "Harsh Jain" , Robin Murphy , "joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org" Return-path: In-Reply-To: Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org List-Id: linux-crypto.vger.kernel.org | From: Harsh Jain | Sent: Friday, September 29, 2017 1:14:45 AM | | Robin, | | I tried running patch on our test setup. | | With "intel_iommu=on" : I can see single occurrence of DMAR Write failure | on perf traffic with 10 thread. | | [ 749.616480] perf: interrupt took too long (3203 > 3202), lowering kernel.perf_event_max_sample_rate to 62000 | [ 852.500671] DMAR: DRHD: handling fault status reg 2 | [ 852.506039] DMAR: [DMA Write] Request device [02:00.4] fault addr ef919000 [fault reason 05] PTE Write access is not set | [root@heptagon linux_t4_build]# cat /proc/cmdline | BOOT_IMAGE=/vmlinuz-4.9.51+ root=UUID=ccbb7f18-b3f0-43df-89de-07521e9c02fe ro intel_iommu=on crashkernel=auto rhgb quiet rhgb quiet console=ttyS0,115200, console=tty0 LANG=en_US.UTF-8 Harsh. Can you provide the debugging information for that one DMA FAILURE trace? It May be yet another corner case in __domain_mapping() or a different path. | With intel_iommu=sp_off : It works fine for more than 30 minutes without | any issues. I think that even without Robin's patch using intel_iommu=sp_off worked without errors, right? Casey From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752385AbdI2QSX (ORCPT ); Fri, 29 Sep 2017 12:18:23 -0400 Received: from mail-cys01nam02on0114.outbound.protection.outlook.com ([104.47.37.114]:44576 "EHLO NAM02-CY1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752172AbdI2QSV (ORCPT ); Fri, 29 Sep 2017 12:18:21 -0400 From: Casey Leedom To: "Harsh Jain" , Robin Murphy , "joro@8bytes.org" CC: "dwmw2@infradead.org" , "ashok.raj@intel.com" , "herbert@gondor.apana.org.au" , "iommu@lists.linux-foundation.org" , "linux-crypto@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] iommu/vt-d: Fix scatterlist offset handling Thread-Topic: [PATCH] iommu/vt-d: Fix scatterlist offset handling Thread-Index: AQHTOGQikkoPI7He70aGarHoA2KBFqLLhTyAgABzTBo= Date: Fri, 29 Sep 2017 16:18:16 +0000 Message-ID: References: <644c3e01654f8bd48d669c36e424959d6ef0e27e.1506607370.git.robin.murphy@arm.com>, In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [12.32.117.8] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;MWHPR12MB1949;6:nTfdAN5uzHY56YapYt0hubptTFdREoUAUipbYn91MQeTZxkLFYO+vEiIeYn367Ea25BomoWDfhtoyp9SDtV7jFfkAg0/AJt0Xpa+rwlI+2kcnUJt6wPTTVte4Np6MQA0RYBfcxSZlkYpFsqWWUG9Nxmfi5w9O4ul5FJ1NycTGeTME+mpM0hBBR2HdxSCv2+wdwHvsNXT5Qbgv1cRBRFJMV26jK5GNH/B+TAGuZxPOUZEnnvzKyvqP/Dn/MNV3Awn//gpderYcmM+c4uIpPaglR/14l+adlxlgno5EDRbVBu6uDr1A6U/sfJPmcJBNWKIhr88qvMS8umEBAwtIum/Kg==;5:F+aYxRDY+mJcxKC2w3dkNQP//HBQRTtd/n4JKFhp13f5LHV1ghPyaQeNrutfI8XTqTGLFeLBw1rCeVFYoOsie7/Xn0alOw2C5XcGNStbI+imCJTY9foGXnfRAGEenQGtTbl8cPE/dbWNmhch7QS+qA==;24:uQXBz4lpbDr2Ju6AUrUhLHZU1M2cLmPA8rHgZ793HZDBLAmJrK2qgZXo7Y7U9S9JmetTwWhw1Y55w8gtkq3AAD9kVj2bRPGi3W52QETHXlE=;7:BgVglpWVhkGWU8Jr6JXZ1YXuukxZgrGqjhEjFjQxCANzURyF1Utg+KK7NFREd7jjmdf6H2NKcbNbuWusW5JfvIeh49odWBl1ROxVSwZVeWXnKALn2U4t6F/4bMmU+bAjyOIBiDBdulJXlP96QWln83lJn94RAjftGY+31yk+ngdcixEr4+kpIbk9Y/Gg1xw1IDNNRs2Xf2wzyRcTY3mtB8kC6fT+v3b8zLnH4DP+g80= x-ms-exchange-antispam-srfa-diagnostics: SSOS;SSOR; x-forefront-antispam-report: SFV:SKI;SCL:-1;SFV:NSPM;SFS:(10019020)(6009001)(376002)(39830400002)(346002)(199003)(377454003)(51444003)(189002)(74316002)(2950100002)(316002)(6436002)(14454004)(77096006)(68736007)(4326008)(6506006)(2501003)(53936002)(50986999)(76176999)(54356999)(55016002)(99286003)(101416001)(5660300001)(33656002)(97736004)(6246003)(229853002)(9686003)(2900100001)(81156014)(3660700001)(478600001)(81166006)(305945005)(86362001)(25786009)(7696004)(8676002)(8936002)(102836003)(6116002)(3846002)(7736002)(105586002)(106356001)(3280700002)(189998001)(54906003)(110136005)(66066001)(2906002);DIR:OUT;SFP:1102;SCL:1;SRVR:MWHPR12MB1949;H:MWHPR12MB1600.namprd12.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; x-ms-office365-filtering-correlation-id: 36d6b2b5-0b8e-4400-2b44-08d50755b106 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254152)(2017082002075)(2017052603199)(201703131423075)(201702281549075);SRVR:MWHPR12MB1949; x-ms-traffictypediagnostic: MWHPR12MB1949: x-exchange-antispam-report-test: UriScan:; x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(100000703101)(100105400095)(3002001)(10201501046)(93006095)(93001095)(6041248)(20161123558100)(2016111802025)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123562025)(20161123560025)(6043046)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:MWHPR12MB1949;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:MWHPR12MB1949; x-forefront-prvs: 0445A82F82 authentication-results: spf=none (sender IP is ) smtp.mailfrom=leedom@chelsio.com; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" MIME-Version: 1.0 X-OriginatorOrg: chelsio.com X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Sep 2017 16:18:16.4660 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 065db76d-a7ae-4c60-b78a-501e8fc17095 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR12MB1949 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id v8TGIWkJ000664 | From: Harsh Jain | Sent: Friday, September 29, 2017 1:14:45 AM | | Robin, | | I tried running patch on our test setup. | | With "intel_iommu=on" : I can see single occurrence of DMAR Write failure | on perf traffic with 10 thread. | | [ 749.616480] perf: interrupt took too long (3203 > 3202), lowering kernel.perf_event_max_sample_rate to 62000 | [ 852.500671] DMAR: DRHD: handling fault status reg 2 | [ 852.506039] DMAR: [DMA Write] Request device [02:00.4] fault addr ef919000 [fault reason 05] PTE Write access is not set | [root@heptagon linux_t4_build]# cat /proc/cmdline | BOOT_IMAGE=/vmlinuz-4.9.51+ root=UUID=ccbb7f18-b3f0-43df-89de-07521e9c02fe ro intel_iommu=on crashkernel=auto rhgb quiet rhgb quiet console=ttyS0,115200, console=tty0 LANG=en_US.UTF-8 Harsh. Can you provide the debugging information for that one DMA FAILURE trace? It May be yet another corner case in __domain_mapping() or a different path. | With intel_iommu=sp_off : It works fine for more than 30 minutes without | any issues. I think that even without Robin's patch using intel_iommu=sp_off worked without errors, right? Casey