From: Ratheesh Kannoth <rkannoth@marvell.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Sunil Kovvuri Goutham <sgoutham@marvell.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"edumazet@google.com" <edumazet@google.com>,
"pabeni@redhat.com" <pabeni@redhat.com>
Subject: RE: [EXT] Re: [net-next PATCH V3 06/12] octeontx2-af: Drop rules for NPC MCAM
Date: Fri, 8 Jul 2022 04:45:05 +0000 [thread overview]
Message-ID: <MWHPR1801MB1918C2542BC344601E837721D3829@MWHPR1801MB1918.namprd18.prod.outlook.com> (raw)
In-Reply-To: <20220707175428.127006ba@kernel.org>
-----Original Message-----
From: Jakub Kicinski <kuba@kernel.org>
Sent: Friday, July 8, 2022 6:24 AM
To: Ratheesh Kannoth <rkannoth@marvell.com>
Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Sunil Kovvuri Goutham <sgoutham@marvell.com>; davem@davemloft.net; edumazet@google.com; pabeni@redhat.com
Subject: [EXT] Re: [net-next PATCH V3 06/12] octeontx2-af: Drop rules for NPC MCAM
External Email
----------------------------------------------------------------------
On Thu, 7 Jul 2022 13:03:47 +0530 Ratheesh Kannoth wrote:
> NPC exact match table installs drop on hit rules in NPC mcam for each
> channel. This rule has broadcast and multicast bits cleared. Exact
> match bit cleared and channel bits set. If exact match table hit bit
> is 0, corresponding NPC mcam drop rule will be hit for the packet and
> will be dropped.
>kdoc:
>drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c:1462: warning: bad line: u8 cgx_id, lmac_id;
Done. Posted new patch set.
>clang:
.>/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c:1228:6: warning: variable 'disable_cam' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
if (entry->cmd)
^~~~~~~~~~
>../drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c:1232:6: note: uninitialized use occurs here
if (disable_cam) {
^~~~~~~~~~~
>./drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c:1228:2: note: remove the 'if' if its condition is always true
> if (entry->cmd)
^~~~~~~~~~~~~~~
>../drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c:1201:18: note: initialize the variable 'disable_cam' to silence this warning
bool disable_cam;
^
= 0
>../drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c:1308:6: warning: variable 'enable_cam' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
> if (cmd)
^~~
>../drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c:1312:6: note: uninitialized use occurs here
> if (enable_cam) {
^~~~~~~~~~
>../drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c:1308:2: note: remove the 'if' if its condition is always true
> if (cmd)
> ^~~~~~~~
>../drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c:1275:17: note: initialize the variable 'enable_cam' to silence this warning
> bool enable_cam;
^
> = 0
Done. Posted new patch.
next prev parent reply other threads:[~2022-07-08 4:45 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-07 7:33 [net-next PATCH V3 00/12] octeontx2: Exact Match Table Ratheesh Kannoth
2022-07-07 7:33 ` [net-next PATCH V3 01/12] octeontx2-af: Use hashed field in MCAM key Ratheesh Kannoth
2022-07-07 7:33 ` [net-next PATCH V3 02/12] octeontx2-af: Exact match support Ratheesh Kannoth
2022-07-08 0:53 ` Jakub Kicinski
2022-07-08 4:48 ` [EXT] " Ratheesh Kannoth
2022-07-07 7:33 ` [net-next PATCH V3 03/12] octeontx2-af: Exact match scan from kex profile Ratheesh Kannoth
2022-07-07 7:33 ` [net-next PATCH V3 04/12] octeontx2-af: devlink configuration support Ratheesh Kannoth
2022-07-07 7:33 ` [net-next PATCH V3 05/12] octeontx2-af: FLR handler for exact match table Ratheesh Kannoth
2022-07-07 7:33 ` [net-next PATCH V3 06/12] octeontx2-af: Drop rules for NPC MCAM Ratheesh Kannoth
2022-07-08 0:54 ` Jakub Kicinski
2022-07-08 4:45 ` Ratheesh Kannoth [this message]
2022-07-07 7:33 ` [net-next PATCH V3 07/12] octeontx2-af: Debugsfs support for exact match Ratheesh Kannoth
2022-07-07 7:33 ` [net-next PATCH V3 08/12] octeontx2: Modify mbox request and response structures Ratheesh Kannoth
2022-07-07 7:33 ` [net-next PATCH V3 09/12] octeontx2-af: Wrapper functions for MAC addr add/del/update/reset Ratheesh Kannoth
2022-07-07 7:33 ` [net-next PATCH V3 10/12] octeontx2-af: Invoke exact match functions if supported Ratheesh Kannoth
2022-07-07 7:33 ` [net-next PATCH V3 11/12] octeontx2-pf: Add support for exact match table Ratheesh Kannoth
2022-07-07 7:33 ` [net-next PATCH V3 12/12] octeontx2-af: Enable Exact match flag in kex profile Ratheesh Kannoth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MWHPR1801MB1918C2542BC344601E837721D3829@MWHPR1801MB1918.namprd18.prod.outlook.com \
--to=rkannoth@marvell.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sgoutham@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.