RE: [EXT] Re: [PATCH v2 1/1] common/cnxk: fix static assertion failure

From: Vamsi Krishna Attunuru <vattunuru@marvell.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
	Nithin Kumar Dabilpuram <ndabilpuram@marvell.com>,
	"yux.jiang@intel.com" <yux.jiang@intel.com>,
	"stable@dpdk.org" <stable@dpdk.org>,
	Wei Ling <weix.ling@intel.com>,
	Srikanth Yalavarthi <syalavarthi@marvell.com>
Subject: RE: [EXT] Re: [PATCH v2 1/1] common/cnxk: fix static assertion failure
Date: Fri, 4 Mar 2022 11:45:54 +0000	[thread overview]
Message-ID: <MWHPR18MB0942D819D2834DA1C94C9676A6059@MWHPR18MB0942.namprd18.prod.outlook.com> (raw)
In-Reply-To: <d8d6cf2a-16de-9c4a-287a-93aa30085dc8@intel.com>

> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit@intel.com>
> Sent: Friday, March 4, 2022 4:46 PM
> To: Vamsi Krishna Attunuru <vattunuru@marvell.com>; dev@dpdk.org
> Cc: Jerin Jacob Kollanukkaran <jerinj@marvell.com>; Nithin Kumar
> Dabilpuram <ndabilpuram@marvell.com>; yux.jiang@intel.com;
> stable@dpdk.org; Wei Ling <weix.ling@intel.com>; Srikanth Yalavarthi
> <syalavarthi@marvell.com>
> Subject: Re: [EXT] Re: [PATCH v2 1/1] common/cnxk: fix static assertion
> failure
> 
> On 3/4/2022 10:20 AM, Vamsi Krishna Attunuru wrote:
> >
> >
> >> -----Original Message-----
> >> From: Ferruh Yigit <ferruh.yigit@intel.com>
> >> Sent: Thursday, March 3, 2022 10:52 PM
> >> To: Vamsi Krishna Attunuru <vattunuru@marvell.com>; dev@dpdk.org
> >> Cc: Jerin Jacob Kollanukkaran <jerinj@marvell.com>; Nithin Kumar
> >> Dabilpuram <ndabilpuram@marvell.com>; yux.jiang@intel.com;
> >> stable@dpdk.org; Wei Ling <weix.ling@intel.com>; Srikanth Yalavarthi
> >> <syalavarthi@marvell.com>
> >> Subject: [EXT] Re: [PATCH v2 1/1] common/cnxk: fix static assertion
> >> failure
> >>
> >> External Email
> >>
> >> ---------------------------------------------------------------------
> >> - On 3/2/2022 1:46 PM, Vamsi Attunuru wrote:
> >>> Use dynamically allocated memory for storing soft expiry ring base
> >>> addresses which fixes the static assertion failure, as the size of
> >>> dynamic allocation depends on RTE_MAX_ETHPORTS which varies based
> on
> >>> the build config.
> >>>
> >>
> >> Hi Vamsi,
> >>
> >> "fix static assertion failure" is not enough descriptive.
> >> assertions already added to verify assumptions, and in this case it
> >> seems it failed, but what was actually wrong?
> >>
> >> Is it that allocated memory size for ring wrong? (this is what I got
> >> from commit log but I am not sure)
> >>
> >> Can you please describe what actually was wrong and fixed now?
> >>
> > Hi Ferruh,
> >
> > Earlier sa_soft_exp_ring struct member was an array of pointers and
> > it's size is linked to num RTE_MAX_ETHPORTS, and the whole struct size
> > is confined and protected by size assertion.  It resulted in build failure with -
> Dmax_ethports=1024 option and assertion caught that failure. V2 fixes the
> issues by allocating the required memory dynamically instead
> >   of using array of pointers.
> >
> 
> Thanks Vamsi for details,
> 
> I was expecting a new version of patch with updated commit log, but to
> make patch for -rc3 I will update it in next-net according above information

Sure, thanks Ferruh.

> 
> >>> Bugzilla ID: 940
> >>> Fixes: d26185716d3f ("net/cnxk: support outbound soft expiry
> >>> notification") Cc:stable@dpdk.org
> >>>
> >>> Reported-by: Wei Ling<weix.ling@intel.com>
> >>> Reported-by: Yu Jiang<yux.jiang@intel.com>
> >>> Signed-off-by: Vamsi Attunuru<vattunuru@marvell.com>
> >>> Signed-off-by: Srikanth Yalavarthi<syalavarthi@marvell.com>
> >>> ---
> >>> V2: Add bugzilla & reportee details, remove unused changes.
> >>> ---
> >