All of lore.kernel.org
 help / color / mirror / Atom feed
From: Long Li <longli@microsoft.com>
To: "Martin K. Petersen" <martin.petersen@oracle.com>,
	KY Srinivasan <kys@microsoft.com>
Cc: Ross Lagerwall <ross.lagerwall@citrix.com>,
	"James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] scsi: devinfo: Add Microsoft iSCSI target to 1024 sector blacklist
Date: Wed, 28 Mar 2018 22:33:05 +0000	[thread overview]
Message-ID: <MWHPR2101MB0729E7680EDB0EE4886AAED1CEA30@MWHPR2101MB0729.namprd21.prod.outlook.com> (raw)
In-Reply-To: <yq17epvj2f1.fsf@oracle.com>

> Subject: Re: [PATCH] scsi: devinfo: Add Microsoft iSCSI target to 1024 sector
> blacklist
> 
> 
> Long, KY: Please confirm.
> 
> > The Windows Server 2016 iSCSI target doesn't work with the Linux
> > kernel initiator since the kernel started sending larger requests by
> > default, nor does it implement the block limits VPD page. Apply the
> > sector limit workaround for these targets.
> >
> > Signed-off-by: Ross Lagerwall <ross.lagerwall@citrix.com>
> > ---
> >  drivers/scsi/scsi_devinfo.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/scsi/scsi_devinfo.c b/drivers/scsi/scsi_devinfo.c
> > index f3b1172..5cb748a 100644
> > --- a/drivers/scsi/scsi_devinfo.c
> > +++ b/drivers/scsi/scsi_devinfo.c
> > @@ -213,7 +213,7 @@ static struct {
> >  	{"Medion", "Flash XL  MMC/SD", "2.6D", BLIST_FORCELUN},
> >  	{"MegaRAID", "LD", NULL, BLIST_FORCELUN},
> >  	{"MICROP", "4110", NULL, BLIST_NOTQ},
> > -	{"MSFT", "Virtual HD", NULL, BLIST_NO_RSOC},
> > +	{"MSFT", "Virtual HD", NULL, BLIST_MAX_1024 | BLIST_NO_RSOC},

Ross,

What about storage_channel_properties.max_transfer_bytes returned from VSTOR_OPERATION_QUERY_PROPERTIES (in storvsc_channel_init())

Does it return correctly the maximum transfer size for iSCSI?

Long 

> >  	{"MYLEX", "DACARMRB", "*", BLIST_REPORTLUN2},
> >  	{"nCipher", "Fastness Crypto", NULL, BLIST_FORCELUN},
> >  	{"NAKAMICH", "MJ-4.8S", NULL, BLIST_FORCELUN |
> BLIST_SINGLELUN},
> 
> --
> Martin K. Petersen	Oracle Linux Engineering

  reply	other threads:[~2018-03-28 22:33 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-26 13:56 [PATCH] scsi: devinfo: Add Microsoft iSCSI target to 1024 sector blacklist Ross Lagerwall
2018-03-26 13:56 ` Ross Lagerwall
2018-03-28 21:49 ` Martin K. Petersen
2018-03-28 21:49   ` Martin K. Petersen
2018-03-28 22:33   ` Long Li [this message]
2018-04-05 16:58     ` Ross Lagerwall
2018-04-05 19:52       ` KY Srinivasan
2018-04-10  2:07 ` Martin K. Petersen
2018-04-10  2:07   ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MWHPR2101MB0729E7680EDB0EE4886AAED1CEA30@MWHPR2101MB0729.namprd21.prod.outlook.com \
    --to=longli@microsoft.com \
    --cc=jejb@linux.vnet.ibm.com \
    --cc=kys@microsoft.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=ross.lagerwall@citrix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.