From: Michael Kelley <mikelley@microsoft.com>
To: Sunil Muthuswamy <sunilmut@microsoft.com>,
Matheus Castello <matheus@castello.eng.br>,
"linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
Haiyang Zhang <haiyangz@microsoft.com>,
Stephen Hemminger <sthemmin@microsoft.com>,
Wei Liu <liuwe@microsoft.com>,
Tianyu Lan <Tianyu.Lan@microsoft.com>,
Wei Liu <wei.liu@kernel.org>, vkuznets <vkuznets@redhat.com>
Cc: KY Srinivasan <kys@microsoft.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v4] x86/Hyper-V: Support for free page reporting
Date: Fri, 19 Mar 2021 21:30:50 +0000 [thread overview]
Message-ID: <MWHPR21MB15932DFEE4F0756419D58525D7689@MWHPR21MB1593.namprd21.prod.outlook.com> (raw)
In-Reply-To: <SN4PR2101MB088036B8892891C5408067BEC0689@SN4PR2101MB0880.namprd21.prod.outlook.com>
From: Sunil Muthuswamy <sunilmut@microsoft.com> Sent: Friday, March 19, 2021 2:21 PM
>
> > What's the strategy for this flag in the unlikely event that the hypercall fails?
> > It doesn't seem right to have hv_query_ext_cap() fail, but leave the
> > static flag set to true. Just move that line down to after the status check
> > has succeeded?
>
> That call should not fail in any normal circumstances. The current idea was to
> avoid repeating the same call on persistent failure.
OK, I can see that as a valid strategy. And the assumption is that a failed
hypercall would leave hv_extended_cap unmodified and hence all zeros.
I'm OK with this approach if you want to keep it. But perhaps add a short
comment about the intent so it doesn't look like a bug. :-)
Michael
> But, since we don't expect
> the query capability to be called in any kind of hot path, I am ok moving this
> down.
>
> >
> > Other than the above about the flag when the hypercall fails,
> > everything else looks good.
> Thanks for the review.
next prev parent reply other threads:[~2021-03-19 21:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-18 20:14 [PATCH v4] x86/Hyper-V: Support for free page reporting Sunil Muthuswamy
2021-03-19 19:21 ` Michael Kelley
2021-03-19 21:20 ` Sunil Muthuswamy
2021-03-19 21:30 ` Michael Kelley [this message]
2021-03-22 11:16 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MWHPR21MB15932DFEE4F0756419D58525D7689@MWHPR21MB1593.namprd21.prod.outlook.com \
--to=mikelley@microsoft.com \
--cc=Tianyu.Lan@microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liuwe@microsoft.com \
--cc=matheus@castello.eng.br \
--cc=sthemmin@microsoft.com \
--cc=sunilmut@microsoft.com \
--cc=vkuznets@redhat.com \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.