From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED68EC64E7B for ; Mon, 30 Nov 2020 21:50:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A5132208DB for ; Mon, 30 Nov 2020 21:50:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730326AbgK3Vtz convert rfc822-to-8bit (ORCPT ); Mon, 30 Nov 2020 16:49:55 -0500 Received: from aposti.net ([89.234.176.197]:44566 "EHLO aposti.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727807AbgK3Vty (ORCPT ); Mon, 30 Nov 2020 16:49:54 -0500 Date: Mon, 30 Nov 2020 21:48:58 +0000 From: Paul Cercueil Subject: Re: [PATCH 2/4] dt-bindings: display: Add ABT Y030XX067A panel bindings To: Rob Herring Cc: Sam Ravnborg , Thierry Reding , Christophe Branchereau , od@zcrc.me, dri-devel , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Message-Id: In-Reply-To: References: <20201101093150.8071-1-paul@crapouillou.net> <20201101093150.8071-3-paul@crapouillou.net> <20201101122900.GB1269759@ravnborg.org> <9CZ5JQ.CWYPSJ8EDOW4@crapouillou.net> <1XJMKQ.YER47WG3D7R41@crapouillou.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le lun. 30 nov. 2020 à 13:18, Rob Herring a écrit : > On Mon, Nov 30, 2020 at 12:39 PM Paul Cercueil > wrote: >> >> Hi Rob, >> >> Le lun. 30 nov. 2020 à 7:32, Rob Herring a >> écrit >> : >> > On Mon, Nov 2, 2020 at 3:19 AM Paul Cercueil >> >> > wrote: >> >> >> >> >> >> >> >> Le dim. 1 nov. 2020 à 13:29, Sam Ravnborg a >> >> écrit : >> >> > On Sun, Nov 01, 2020 at 09:31:48AM +0000, Paul Cercueil wrote: >> >> >> The Asia Better Technology (ABT) Y030XX067A panel is a 3.0" >> >> 320x480 >> >> >> 24-bit IPS LCD panel. Its particularity is that it has >> >> non-square >> >> >> pixels >> >> >> (as it is 4:3 for a resolution of 320x480), and that it >> >> requires odd >> >> >> lines to be sent as RGB and even lines to be sent as GRB on >> its >> >> >> 8-bit >> >> >> bus. >> >> >> >> >> >> Signed-off-by: Paul Cercueil >> >> >> --- >> >> >> .../display/panel/abt,y030xx067a.yaml | 54 >> >> >> +++++++++++++++++++ >> >> >> 1 file changed, 54 insertions(+) >> >> >> create mode 100644 >> >> >> >> >> >> Documentation/devicetree/bindings/display/panel/abt,y030xx067a.yaml >> >> >> >> >> >> diff --git >> >> >> >> >> >> a/Documentation/devicetree/bindings/display/panel/abt,y030xx067a.yaml >> >> >> >> >> >> b/Documentation/devicetree/bindings/display/panel/abt,y030xx067a.yaml >> >> >> new file mode 100644 >> >> >> index 000000000000..6407e8bf45fa >> >> >> --- /dev/null >> >> >> +++ >> >> >> >> >> >> b/Documentation/devicetree/bindings/display/panel/abt,y030xx067a.yaml >> >> >> @@ -0,0 +1,54 @@ >> >> >> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) >> >> >> +%YAML 1.2 >> >> >> +--- >> >> >> +$id: >> >> >> >> http://devicetree.org/schemas/display/panel/abt,y030xx067a.yaml# >> >> >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> >> >> + >> >> >> +title: Asia Better Technology 3.0" (320x480 pixels) 24-bit >> IPS >> >> LCD >> >> >> panel >> >> >> + >> >> >> +description: | >> >> >> + The panel must obey the rules for a SPI slave device as >> >> >> specified in >> >> >> + spi/spi-controller.yaml >> >> >> + >> >> >> +maintainers: >> >> >> + - Paul Cercueil >> >> >> + >> >> >> +allOf: >> >> >> + - $ref: panel-common.yaml# >> >> >> + >> >> >> +properties: >> >> >> + compatible: >> >> >> + const: abt,y030xx067a >> >> >> + >> >> >> + backlight: true >> >> >> + port: true >> >> >> + power-supply: true >> >> >> + reg: true >> >> >> + reset-gpios: true >> >> > >> >> > The binding is missing: >> >> > required: >> >> > - compatible >> >> > - reg >> >> > - power-supply >> >> > - reset-gpios >> >> > - ... >> >> > >> >> > additionalProperties: false >> >> > >> >> > So r-b only with these added. >> >> >> >> Stupid mistake, sorry about that. >> >> >> >> I'll V2. >> > >> > I don't have any V2 in my inbox, but looks like it is in >> linux-next >> > now: >> >> Yes, Sam told me on IRC I could fix it while applying and avoid the >> V2. >> >> > >> /builds/robherring/linux-dt-bindings/Documentation/devicetree/bindings/display/panel/abt,y030xx067a.example.dt.yaml: >> > panel@0: 'spi-max-frequency' does not match any of the regexes: >> > 'pinctrl-[0-9]+' >> > From schema: >> > >> /builds/robherring/linux-dt-bindings/Documentation/devicetree/bindings/display/panel/abt,y030xx067a.yaml >> >> "make dt_binding_check >> >> DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/panel/abt,y030xx067a.yaml" >> doesn't complain here :( > > Even if you do 'touch > Documentation/devicetree/bindings/display/panel/abt,y030xx067a.yaml' > or do a clean build? > > I can't think of any kernel or dt-schema changes which would explain > the difference. This is purely related to 'additionalProperties: > false'. Ok, I see it now. Should I use 'unevaluatedProperties: false' instead? -Paul From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D3ADC64E8A for ; Tue, 1 Dec 2020 08:24:00 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D5AD12087D for ; Tue, 1 Dec 2020 08:23:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D5AD12087D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=crapouillou.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AEF316E4D7; Tue, 1 Dec 2020 08:23:44 +0000 (UTC) Received: from aposti.net (aposti.net [89.234.176.197]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7BEFB6E8CC for ; Mon, 30 Nov 2020 21:49:13 +0000 (UTC) Date: Mon, 30 Nov 2020 21:48:58 +0000 From: Paul Cercueil Subject: Re: [PATCH 2/4] dt-bindings: display: Add ABT Y030XX067A panel bindings To: Rob Herring Message-Id: In-Reply-To: References: <20201101093150.8071-1-paul@crapouillou.net> <20201101093150.8071-3-paul@crapouillou.net> <20201101122900.GB1269759@ravnborg.org> <9CZ5JQ.CWYPSJ8EDOW4@crapouillou.net> <1XJMKQ.YER47WG3D7R41@crapouillou.net> MIME-Version: 1.0 X-Mailman-Approved-At: Tue, 01 Dec 2020 08:23:37 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, od@zcrc.me, Sam Ravnborg , linux-kernel@vger.kernel.org, dri-devel , Thierry Reding , Christophe Branchereau Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1"; Format="flowed" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Le lun. 30 nov. 2020 =E0 13:18, Rob Herring a = =E9crit : > On Mon, Nov 30, 2020 at 12:39 PM Paul Cercueil = > wrote: >> = >> Hi Rob, >> = >> Le lun. 30 nov. 2020 =E0 7:32, Rob Herring a = >> =E9crit >> : >> > On Mon, Nov 2, 2020 at 3:19 AM Paul Cercueil = >> >> > wrote: >> >> >> >> >> >> >> >> Le dim. 1 nov. 2020 =E0 13:29, Sam Ravnborg a >> >> =E9crit : >> >> > On Sun, Nov 01, 2020 at 09:31:48AM +0000, Paul Cercueil wrote: >> >> >> The Asia Better Technology (ABT) Y030XX067A panel is a 3.0" >> >> 320x480 >> >> >> 24-bit IPS LCD panel. Its particularity is that it has >> >> non-square >> >> >> pixels >> >> >> (as it is 4:3 for a resolution of 320x480), and that it >> >> requires odd >> >> >> lines to be sent as RGB and even lines to be sent as GRB on = >> its >> >> >> 8-bit >> >> >> bus. >> >> >> >> >> >> Signed-off-by: Paul Cercueil >> >> >> --- >> >> >> .../display/panel/abt,y030xx067a.yaml | 54 >> >> >> +++++++++++++++++++ >> >> >> 1 file changed, 54 insertions(+) >> >> >> create mode 100644 >> >> >> >> >> = >> Documentation/devicetree/bindings/display/panel/abt,y030xx067a.yaml >> >> >> >> >> >> diff --git >> >> >> >> >> = >> a/Documentation/devicetree/bindings/display/panel/abt,y030xx067a.yaml >> >> >> >> >> = >> b/Documentation/devicetree/bindings/display/panel/abt,y030xx067a.yaml >> >> >> new file mode 100644 >> >> >> index 000000000000..6407e8bf45fa >> >> >> --- /dev/null >> >> >> +++ >> >> >> >> >> = >> b/Documentation/devicetree/bindings/display/panel/abt,y030xx067a.yaml >> >> >> @@ -0,0 +1,54 @@ >> >> >> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) >> >> >> +%YAML 1.2 >> >> >> +--- >> >> >> +$id: >> >> >> = >> http://devicetree.org/schemas/display/panel/abt,y030xx067a.yaml# >> >> >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> >> >> + >> >> >> +title: Asia Better Technology 3.0" (320x480 pixels) 24-bit = >> IPS >> >> LCD >> >> >> panel >> >> >> + >> >> >> +description: | >> >> >> + The panel must obey the rules for a SPI slave device as >> >> >> specified in >> >> >> + spi/spi-controller.yaml >> >> >> + >> >> >> +maintainers: >> >> >> + - Paul Cercueil >> >> >> + >> >> >> +allOf: >> >> >> + - $ref: panel-common.yaml# >> >> >> + >> >> >> +properties: >> >> >> + compatible: >> >> >> + const: abt,y030xx067a >> >> >> + >> >> >> + backlight: true >> >> >> + port: true >> >> >> + power-supply: true >> >> >> + reg: true >> >> >> + reset-gpios: true >> >> > >> >> > The binding is missing: >> >> > required: >> >> > - compatible >> >> > - reg >> >> > - power-supply >> >> > - reset-gpios >> >> > - ... >> >> > >> >> > additionalProperties: false >> >> > >> >> > So r-b only with these added. >> >> >> >> Stupid mistake, sorry about that. >> >> >> >> I'll V2. >> > >> > I don't have any V2 in my inbox, but looks like it is in = >> linux-next >> > now: >> = >> Yes, Sam told me on IRC I could fix it while applying and avoid the = >> V2. >> = >> > = >> /builds/robherring/linux-dt-bindings/Documentation/devicetree/bindings/d= isplay/panel/abt,y030xx067a.example.dt.yaml: >> > panel@0: 'spi-max-frequency' does not match any of the regexes: >> > 'pinctrl-[0-9]+' >> > From schema: >> > = >> /builds/robherring/linux-dt-bindings/Documentation/devicetree/bindings/d= isplay/panel/abt,y030xx067a.yaml >> = >> "make dt_binding_check >> = >> DT_SCHEMA_FILES=3DDocumentation/devicetree/bindings/display/panel/abt,y0= 30xx067a.yaml" >> doesn't complain here :( > = > Even if you do 'touch > Documentation/devicetree/bindings/display/panel/abt,y030xx067a.yaml' > or do a clean build? > = > I can't think of any kernel or dt-schema changes which would explain > the difference. This is purely related to 'additionalProperties: > false'. Ok, I see it now. Should I use 'unevaluatedProperties: false' instead? -Paul _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel