From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S268910AbTGJE2U (ORCPT ); Thu, 10 Jul 2003 00:28:20 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S268912AbTGJE2U (ORCPT ); Thu, 10 Jul 2003 00:28:20 -0400 Received: from blackbird.intercode.com.au ([203.32.101.10]:21775 "EHLO blackbird.intercode.com.au") by vger.kernel.org with ESMTP id S268910AbTGJE2T (ORCPT ); Thu, 10 Jul 2003 00:28:19 -0400 Date: Thu, 10 Jul 2003 14:42:44 +1000 (EST) From: James Morris To: Jim Keniston cc: LKML , , Andrew Morton , "David S. Miller" , Jeff Garzik , Alan Cox , Randy Dunlap Subject: Re: [PATCH - RFC] [1/2] 2.6 must-fix list - kernel error reporting In-Reply-To: <3F0AFFE6.E85FF283@us.ibm.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 8 Jul 2003, Jim Keniston wrote: + kerror_nl = netlink_kernel_create(NETLINK_KERROR, kerror_netlink_rcv); + if (kerror_nl == NULL) + panic("kerror_init: cannot initialize kerror_nl\n"); You can simply use NULL instead of passing the dummy kerror_netlink_rcv function. +struct kern_log_entry { + __u16 log_kmagic; /* always LOGREC_KMAGIC */ + __u16 log_kversion; /* which version of this struct? */ + char log_facility[FACILITY_MAXLEN]; /* e.g., driver name */ These fields should generally be specified in ascending order to help with alignment. It may also be worth looking at how the ULOG code batches messages to improve peformance. - James -- James Morris