From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C16D4C43334 for ; Thu, 7 Jul 2022 09:54:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235117AbiGGJyE (ORCPT ); Thu, 7 Jul 2022 05:54:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54162 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233939AbiGGJyD (ORCPT ); Thu, 7 Jul 2022 05:54:03 -0400 Received: from aposti.net (aposti.net [89.234.176.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7B2D94D14B; Thu, 7 Jul 2022 02:54:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=crapouillou.net; s=mail; t=1657187641; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nve6BKmlaYOc+otcI5eNXohDPw2cjmzrRzVfk9qXlSw=; b=QV8hoZwQTYaJ3Jt8bNtBQ+DQI0juH8x5zi9rMmqfAh1yP2oH9HizoJIn8ro25vqQChCN1G M9ZoL16/rzcKJcqAfnOp+VBukhcMLdDuhYIfNUJ8x/h6/TaEa7+bcVkEkOOKymU+bhNVYu KGkMwRNo+s52kdYt5n57pjrCZDEMZwE= Date: Thu, 07 Jul 2022 10:53:47 +0100 From: Paul Cercueil Subject: Re: [PATCH 11/11] ASoC: jz4740-i2s: Support continuous sample rate To: Aidan MacDonald Cc: lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, linux-mips@vger.kernel.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Message-Id: In-Reply-To: <20220706211330.120198-12-aidanmacdonald.0x0@gmail.com> References: <20220706211330.120198-1-aidanmacdonald.0x0@gmail.com> <20220706211330.120198-12-aidanmacdonald.0x0@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le mer., juil. 6 2022 at 22:13:30 +0100, Aidan MacDonald=20 a =E9crit : > The I2S controller on JZ47xx SoCs doesn't impose restrictions on > sample rate and the driver doesn't make any assumptions about it, > so the DAI should advertise a continuous sample rate range. >=20 > Signed-off-by: Aidan MacDonald Acked-by: Paul Cercueil Cheers, -Paul > --- > sound/soc/jz4740/jz4740-i2s.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) >=20 > diff --git a/sound/soc/jz4740/jz4740-i2s.c=20 > b/sound/soc/jz4740/jz4740-i2s.c > index ee99c5e781ec..053697c7f19e 100644 > --- a/sound/soc/jz4740/jz4740-i2s.c > +++ b/sound/soc/jz4740/jz4740-i2s.c > @@ -378,13 +378,13 @@ static struct snd_soc_dai_driver jz4740_i2s_dai=20 > =3D { > .playback =3D { > .channels_min =3D 1, > .channels_max =3D 2, > - .rates =3D SNDRV_PCM_RATE_8000_48000, > + .rates =3D SNDRV_PCM_RATE_CONTINUOUS, > .formats =3D JZ4740_I2S_FMTS, > }, > .capture =3D { > .channels_min =3D 2, > .channels_max =3D 2, > - .rates =3D SNDRV_PCM_RATE_8000_48000, > + .rates =3D SNDRV_PCM_RATE_CONTINUOUS, > .formats =3D JZ4740_I2S_FMTS, > }, > .symmetric_rate =3D 1, > @@ -415,13 +415,13 @@ static struct snd_soc_dai_driver jz4770_i2s_dai=20 > =3D { > .playback =3D { > .channels_min =3D 1, > .channels_max =3D 2, > - .rates =3D SNDRV_PCM_RATE_8000_48000, > + .rates =3D SNDRV_PCM_RATE_CONTINUOUS, > .formats =3D JZ4740_I2S_FMTS, > }, > .capture =3D { > .channels_min =3D 2, > .channels_max =3D 2, > - .rates =3D SNDRV_PCM_RATE_8000_48000, > + .rates =3D SNDRV_PCM_RATE_CONTINUOUS, > .formats =3D JZ4740_I2S_FMTS, > }, > .ops =3D &jz4740_i2s_dai_ops, > -- > 2.35.1 >=20 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6522CC433EF for ; Thu, 7 Jul 2022 09:55:01 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id A208E1633; Thu, 7 Jul 2022 11:54:09 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz A208E1633 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1657187699; bh=zqX2IkRLxAQo716xYKKIsh/cG2WQc5e4ds3FxDYxhAE=; h=Date:From:Subject:To:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=O9MMVl7YIk093nRTLSXW1R2DYuR4Lg5dNE+YPwrRu/iAJARSbmE0keYX67RqCN5iQ MzpTufni2pGkPvmMUUycdqFOZEQSOkIQb+ebROpQUAoczsWq9Vpc8Liue3xb1NAtIi jSCHqL5LF03i6BRzHEw4eCzWzvq9pJEHVh2JV8aU= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 4E204F80104; Thu, 7 Jul 2022 11:54:09 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id CF79EF804FA; Thu, 7 Jul 2022 11:54:07 +0200 (CEST) Received: from aposti.net (aposti.net [89.234.176.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id C2F92F80104 for ; Thu, 7 Jul 2022 11:54:01 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz C2F92F80104 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=crapouillou.net header.i=@crapouillou.net header.b="QV8hoZwQ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=crapouillou.net; s=mail; t=1657187641; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nve6BKmlaYOc+otcI5eNXohDPw2cjmzrRzVfk9qXlSw=; b=QV8hoZwQTYaJ3Jt8bNtBQ+DQI0juH8x5zi9rMmqfAh1yP2oH9HizoJIn8ro25vqQChCN1G M9ZoL16/rzcKJcqAfnOp+VBukhcMLdDuhYIfNUJ8x/h6/TaEa7+bcVkEkOOKymU+bhNVYu KGkMwRNo+s52kdYt5n57pjrCZDEMZwE= Date: Thu, 07 Jul 2022 10:53:47 +0100 From: Paul Cercueil Subject: Re: [PATCH 11/11] ASoC: jz4740-i2s: Support continuous sample rate To: Aidan MacDonald Message-Id: In-Reply-To: <20220706211330.120198-12-aidanmacdonald.0x0@gmail.com> References: <20220706211330.120198-1-aidanmacdonald.0x0@gmail.com> <20220706211330.120198-12-aidanmacdonald.0x0@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable Cc: alsa-devel@alsa-project.org, lgirdwood@gmail.com, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, tiwai@suse.com, broonie@kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Le mer., juil. 6 2022 at 22:13:30 +0100, Aidan MacDonald=20 a =E9crit : > The I2S controller on JZ47xx SoCs doesn't impose restrictions on > sample rate and the driver doesn't make any assumptions about it, > so the DAI should advertise a continuous sample rate range. >=20 > Signed-off-by: Aidan MacDonald Acked-by: Paul Cercueil Cheers, -Paul > --- > sound/soc/jz4740/jz4740-i2s.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) >=20 > diff --git a/sound/soc/jz4740/jz4740-i2s.c=20 > b/sound/soc/jz4740/jz4740-i2s.c > index ee99c5e781ec..053697c7f19e 100644 > --- a/sound/soc/jz4740/jz4740-i2s.c > +++ b/sound/soc/jz4740/jz4740-i2s.c > @@ -378,13 +378,13 @@ static struct snd_soc_dai_driver jz4740_i2s_dai=20 > =3D { > .playback =3D { > .channels_min =3D 1, > .channels_max =3D 2, > - .rates =3D SNDRV_PCM_RATE_8000_48000, > + .rates =3D SNDRV_PCM_RATE_CONTINUOUS, > .formats =3D JZ4740_I2S_FMTS, > }, > .capture =3D { > .channels_min =3D 2, > .channels_max =3D 2, > - .rates =3D SNDRV_PCM_RATE_8000_48000, > + .rates =3D SNDRV_PCM_RATE_CONTINUOUS, > .formats =3D JZ4740_I2S_FMTS, > }, > .symmetric_rate =3D 1, > @@ -415,13 +415,13 @@ static struct snd_soc_dai_driver jz4770_i2s_dai=20 > =3D { > .playback =3D { > .channels_min =3D 1, > .channels_max =3D 2, > - .rates =3D SNDRV_PCM_RATE_8000_48000, > + .rates =3D SNDRV_PCM_RATE_CONTINUOUS, > .formats =3D JZ4740_I2S_FMTS, > }, > .capture =3D { > .channels_min =3D 2, > .channels_max =3D 2, > - .rates =3D SNDRV_PCM_RATE_8000_48000, > + .rates =3D SNDRV_PCM_RATE_CONTINUOUS, > .formats =3D JZ4740_I2S_FMTS, > }, > .ops =3D &jz4740_i2s_dai_ops, > -- > 2.35.1 >=20