All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steve.Glendinning@smsc.com
To: Paul Mundt <lethal@linux-sh.org>
Cc: davem@davemloft.net, Ian.Saturley@smsc.com, iwamatsu@nigauri.org,
	Magnus Damm <magnus.damm@gmail.com>,
	netdev@vger.kernel.org
Subject: Re: [PATCH] smsc911x: add fifo byteswap support
Date: Thu, 23 Apr 2009 12:33:33 +0100	[thread overview]
Message-ID: <OF0BDED475.580A7BDC-ON802575A1.003F11AE-802575A1.003F7D39@smsc.com> (raw)
In-Reply-To: <20090423020925.GA8818@linux-sh.org>

Paul Mundt <lethal@linux-sh.org> wrote on 23/04/2009 03:09:25:

> > The best solution would be to swap the byte lanes in hardware,
> > as the device's endian swapping features only affect registers
> > (not the FIFOs).  The very latest devices in this family
> > (such as the LAN9221) can swap both independently, but this
> > driver has to also support older parts.
> > 
> > Performance will be suboptimal with this software byteswapping,
> > so I think we should also add a comment to stress that this is
> > a "last resort" workaround for broken hardware.
> > 
> > Acked-by: Steve Glendinning <steve.glendinning@smsc.com>
> 
> Performance is not much of a consideration here, it's basically between
> this and no ethernet at all. On the plus side, at least not many boards
> will need this, I believe it's only 2 generations of microcontroller
> evaluation boards that suffer from this particular bit of idiocy on our
> side.

I agree, it's a handy feature to have when you're stuck with broken
hardware.  I'd like everyone who enables it to KNOW that their hardware
is broken however, so hopefully they push back on their hardware guys
to correct it in a later revision.

I'd like to avoid people getting a broken platform working using this,
then later complaining about performance!

Steve

  reply	other threads:[~2009-04-23 11:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-22 14:55 [PATCH] smsc911x: add fifo byteswap support Magnus Damm
2009-04-22 15:21 ` Steve.Glendinning
2009-04-23  2:09   ` Paul Mundt
2009-04-23 11:33     ` Steve.Glendinning [this message]
2009-04-24  1:15   ` Magnus Damm
2009-04-27  7:40     ` Steve.Glendinning

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=OF0BDED475.580A7BDC-ON802575A1.003F11AE-802575A1.003F7D39@smsc.com \
    --to=steve.glendinning@smsc.com \
    --cc=Ian.Saturley@smsc.com \
    --cc=davem@davemloft.net \
    --cc=iwamatsu@nigauri.org \
    --cc=lethal@linux-sh.org \
    --cc=magnus.damm@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.