From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gw1.transmode.se (gw1.transmode.se [195.58.98.146]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 8A574B6F9F for ; Thu, 31 May 2012 19:56:28 +1000 (EST) In-Reply-To: <13517672561.20120531113057@abatron.ch> References: <1338363814-19565-1-git-send-email-Joakim.Tjernlund@transmode.se> <6F7E3816-E71B-466A-9C6F-9928E1CFD7B1@digitaldans.com> <10126984030.20120530140826@abatron.ch> <13517672561.20120531113057@abatron.ch> Subject: Re: Re[4]: [RFC] [PATCH] powerpc: Add MSR_DE to MSR_KERNEL To: Support Message-ID: From: Joakim Tjernlund Date: Thu, 31 May 2012 11:56:23 +0200 MIME-Version: 1.0 Content-type: text/plain; charset=US-ASCII Cc: linuxppc-dev@ozlabs.org, Dan Malek , Bob Cochran List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Abatron Support wrote on 2012/05/31 11:30:57: > > > > Abatron Support wrote on 2012/05/30 14:08:26: > >> > >> >> I have tested this briefly with BDI2000 on P2010(e500) and > >> >> it works for me. I don't know if there are any bad side effects, > >> >> therfore > >> >> this RFC. > >> > >> > We used to have MSR_DE surrounded by CONFIG_something > >> > to ensure it wasn't set under normal operation. IIRC, if MSR_DE > >> > is set, you will have problems with software debuggers that > >> > utilize the the debugging registers in the chip itself. You only want > >> > to force this to be set when using the BDI, not at other times. > >> > >> This MSR_DE is also of interest and used for software debuggers that > >> make use of the debug registers. Only if MSR_DE is set then debug > >> interrupts are generated. If a debug event leads to a debug interrupt > >> handled by a software debugger or if it leads to a debug halt handled > >> by a JTAG tool is selected with DBCR0_EDM / DBCR0_IDM. > >> > >> The "e500 Core Family Reference Manual" chapter "Chapter 8 > >> Debug Support" explains in detail the effect of MSR_DE. > > > So what is the verdict on this? I don't buy into Dan argument without some > > hard data. > > What I tried to mention is that handling the MSR_DE correct is not only > an emulator (JTAG debugger) requirement. Also a software debugger may > depend on a correct handled MSR_DE bit. Yes, that made sense to me too. How would SW debuggers work if the kernel keeps turning off MSR_DE first chance it gets? Jocke