From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Stevens Subject: Re: [PATCH net] net: vxlan: fix crash when interface is created with no group Date: Wed, 19 Mar 2014 08:40:29 -0600 Message-ID: References: , <1395055050-20874-1-git-send-email-mike.rapoport@ravellosystems.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: netdev To: Mike Rapoport Return-path: Received: from e34.co.us.ibm.com ([32.97.110.152]:43653 "EHLO e34.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932861AbaCSOkc convert rfc822-to-8bit (ORCPT ); Wed, 19 Mar 2014 10:40:32 -0400 Received: from /spool/local by e34.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 19 Mar 2014 08:40:32 -0600 Received: from b03cxnp08026.gho.boulder.ibm.com (b03cxnp08026.gho.boulder.ibm.com [9.17.130.18]) by d03dlp03.boulder.ibm.com (Postfix) with ESMTP id 6463219D8036 for ; Wed, 19 Mar 2014 08:40:27 -0600 (MDT) Received: from d03av03.boulder.ibm.com (d03av03.boulder.ibm.com [9.17.195.169]) by b03cxnp08026.gho.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id s2JEdve857737378 for ; Wed, 19 Mar 2014 15:39:57 +0100 Received: from d03av03.boulder.ibm.com (localhost [127.0.0.1]) by d03av03.boulder.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s2JEeTI4002460 for ; Wed, 19 Mar 2014 08:40:30 -0600 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: -----Mike Rapoport wrote: ----- >I'm not really familiar with v4 and v6 interoperability, but the >vxlan_socket_create will create v6 socket only if IPv6 is explicitly >requested. >Would it be possible to receive IPv6-encapsulated packets from IPv4 >socket? =A0 =A0 Yes, if it's bound to INADDR_ANY or "::", which would be the ca= se when "vxlan_dev->saddr" aka "ip ... local XXXX" =A0is not specified. =A0 =A0 And it's a good thing, if mixing protocols is what you want, bu= t I think we need to make sure the admin can choose whether it's v4, v6 or both. =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0= =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0+-DLS