From: tang.junhui@zte.com.cn
To: Hannes Reinecke <hare@suse.de>
Cc: Bart Van Assche <bart.vanassche@sandisk.com>,
device-mapper development <dm-devel@redhat.com>,
dm-devel-bounces@redhat.com, zhang.kai16@zte.com.cn
Subject: 答复: Re: [PATCH] libmultipath: fix multipath -q command logic
Date: Wed, 12 Oct 2016 14:28:04 +0800 [thread overview]
Message-ID: <OF1E8D06A4.2C019510-ON4825804A.002288E2-4825804A.0023874A@zte.com.cn> (raw)
In-Reply-To: <48fb8d6b-b428-4f2f-a6df-4b566a04616d@suse.de>
[-- Attachment #1.1: Type: text/plain, Size: 2885 bytes --]
Hello Hannes,
check_daemon() now is only used to determine whether to set/remove
queue_if_no_path feature for
mapped devices, which you said maybe another issue, we are looking forward
for your patch.
Thanks,
Tang
发件人: Hannes Reinecke <hare@suse.de>
收件人: tang.junhui@zte.com.cn, bmarzins@redhat.com,
抄送: Bart Van Assche <bart.vanassche@sandisk.com>, device-mapper
development <dm-devel@redhat.com>, zhang.kai16@zte.com.cn
日期: 2016/10/11 18:42
主题: Re: [dm-devel] [PATCH] libmultipath: fix multipath -q command
logic
发件人: dm-devel-bounces@redhat.com
On 10/11/2016 11:17 AM, tang.junhui@zte.com.cn wrote:
> Hello Hannes, Ben,
> Could you have a review for this patch, any comment will be highly
> appreciated.
>
> Thanks,
> Tang
>
>
>
>
> 发件人: Christophe Varoqui <christophe.varoqui@opensvc.com>
> 收件人: tang.junhui@zte.com.cn,
> 抄送: Bart Van Assche <bart.vanassche@sandisk.com>, device-mapper
> development <dm-devel@redhat.com>, zhang.kai16@zte.com.cn
> 日期: 2016/10/11 14:59
> 主题: Re: [dm-devel] [PATCH] libmultipath: fix multipath -q
> command logic
> 发件人: dm-devel-bounces@redhat.com
> ------------------------------------------------------------------------
>
>
>
> Hannes, Ben,
>
> are you ok with the solution to these two issues.
> Seems sane to me.
>
This actually is only part of the story.
The whole idea of issuing 'multipath' is to check if a given path
_should_ be multipathed (as this is typically called from an udev event).
But as it's called from an udev event we cannot rely on the multipath
daemon to be started; we might just handle an event which came in before
multipathd got started from systemd.
So checking for the PID file is not enough, we need to check if the
daemon will be started eventually.
And in fact checking the PID file or calling mpath_connect() is
equivalent, with the added advantage the mpath_connect() will start the
daemon _if enabled by systemd_.
So this patch doesn't help much, as it doesn't solve the main problem of
figuring out if multipathd _should_ be started.
I've done a patch for checking the '.wants' directories from systemd,
but this obviously will only work if the OS is systemd-based.
And it's not really perfect, as there are corner-cases where just
checking for the .wants directory is not enough.
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911
74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
[-- Attachment #1.2: Type: text/html, Size: 4714 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
prev parent reply other threads:[~2016-10-12 6:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-16 11:32 [PATCH] libmultipath: fix multipath -q command logic tang.junhui
2016-10-11 6:46 ` tang.junhui
2016-10-11 6:52 ` Christophe Varoqui
2016-10-11 9:17 ` tang.junhui
2016-10-11 10:33 ` Hannes Reinecke
2016-10-12 2:44 ` Benjamin Marzinski
2016-10-12 4:29 ` tang.junhui
2016-10-12 6:28 ` tang.junhui [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=OF1E8D06A4.2C019510-ON4825804A.002288E2-4825804A.0023874A@zte.com.cn \
--to=tang.junhui@zte.com.cn \
--cc=bart.vanassche@sandisk.com \
--cc=dm-devel-bounces@redhat.com \
--cc=dm-devel@redhat.com \
--cc=hare@suse.de \
--cc=zhang.kai16@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.