All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike_Phillips@URSCorp.com
To: Stephen Hemminger <shemminger@osdl.org>
Cc: jgarzik@pobox.com, netdev@oss.sgi.com, netdev-bounce@oss.sgi.com
Subject: Re: [PATCH] (5/6) ibmtr -- probe2
Date: Fri, 17 Oct 2003 10:34:54 -0300	[thread overview]
Message-ID: <OF2CF9F939.3E58DC8A-ON84256DC2.004A4CEF-84256DC2.004A9B73@urscorp.com> (raw)


>>
>> > typedef struct ibmtr_dev_t {
>> > +    struct tok_info         ti;         /* must be first! */
>>
>> Why must this be first ?? Sounds like an alignment issue, we shouldn't
>> assume some is aligned correctly just because it's the first entry.

>Because ibmtr_cs calls ibmtr_probe1 function which does:
>            struct tok_info *ti = dev->priv;
>and dereferences it in a couple of places.

Huh ?? All the patch did was move the definition of ti to the start of the
struct ibmtr_dev_t

Mike

             reply	other threads:[~2003-10-17 13:34 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-10-17 13:34 Mike_Phillips [this message]
  -- strict thread matches above, loose matches on Subject: below --
2003-10-21  0:50 [PATCH] (5/6) ibmtr -- probe2 Mike_Phillips
2003-10-20 14:07 Mike_Phillips
2003-10-17 13:40 Mike_Phillips
2003-10-17 13:37 Mike_Phillips
2003-10-17 22:49 ` Stephen Hemminger
2003-10-16 22:52 Mike_Phillips
2003-10-16 20:08 ` Stephen Hemminger
2003-10-15 20:48 Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=OF2CF9F939.3E58DC8A-ON84256DC2.004A4CEF-84256DC2.004A9B73@urscorp.com \
    --to=mike_phillips@urscorp.com \
    --cc=jgarzik@pobox.com \
    --cc=netdev-bounce@oss.sgi.com \
    --cc=netdev@oss.sgi.com \
    --cc=shemminger@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.