From: zhengxunli@mxic.com.tw To: "Pratyush Yadav" <p.yadav@ti.com> Cc: broonie@kernel.org, jaimeliao@mxic.com.tw, linux-mtd@lists.infradead.org, linux-spi@vger.kernel.org, miquel.raynal@bootlin.com, tudor.ambarus@microchip.com Subject: Re: [PATCH v5 2/2] spi: mxic: patch for octal DTR mode support Date: Tue, 18 May 2021 10:47:36 +0800 [thread overview] Message-ID: <OF3240723E.EAE563CF-ON482586D9.000E8308-482586D9.000F5865@mxic.com.tw> (raw) In-Reply-To: <20210517160628.s65h6prjt5mw6bud@ti.com> Hi, "Pratyush Yadav" <p.yadav@ti.com> wrote on 2021/05/18 上午 12:06:30: > "Pratyush Yadav" <p.yadav@ti.com> > 2021/05/18 上午 12:06 > > To > > "Zhengxun Li" <zhengxunli@mxic.com.tw>, > > cc > > <linux-mtd@lists.infradead.org>, <linux-spi@vger.kernel.org>, > <tudor.ambarus@microchip.com>, <miquel.raynal@bootlin.com>, > <broonie@kernel.org>, <jaimeliao@mxic.com.tw> > > Subject > > Re: [PATCH v5 2/2] spi: mxic: patch for octal DTR mode support > > On 17/05/21 02:14PM, Zhengxun Li wrote: > > Driver patch for octal DTR mode support. > > > > Owing to the spi_mem_default_supports_op() is not support dtr > > operation. Based on Pratyush patch "spi: spi-mem: add spi_mem_dtr > > I don't like the "Based on Pratyush patch". Please mention the commit > hash so it is much easier to find later. For example, saying based on > commit 539cf68cd51b (spi: spi-mem: add spi_mem_dtr_supports_op(), > 2021-02-04) is much better. > > But while we are on this topic, I don't think it is needed all that > much. People use pre-existing APIs all the time. I don't see any need to > specifically point it out. So I think saying "Call > spi_mem_dtr_supports_op() to ..." is better. Thanks for your suggestion. > > _supports_op()" add spi_mem_dtr_supports_op() to support dtr and > > keep checking the buswidth and command bytes. > > > > Signed-off-by: Zhengxun Li <zhengxunli@mxic.com.tw> > > --- Thanks, Zhengxun CONFIDENTIALITY NOTE: This e-mail and any attachments may contain confidential information and/or personal data, which is protected by applicable laws. Please be reminded that duplication, disclosure, distribution, or use of this e-mail (and/or its attachments) or any part thereof is prohibited. If you receive this e-mail in error, please notify us immediately and delete this mail as well as its attachment(s) from your system. In addition, please be informed that collection, processing, and/or use of personal data is prohibited unless expressly permitted by personal data protection laws. Thank you for your attention and cooperation. Macronix International Co., Ltd. ===================================================================== ============================================================================ CONFIDENTIALITY NOTE: This e-mail and any attachments may contain confidential information and/or personal data, which is protected by applicable laws. Please be reminded that duplication, disclosure, distribution, or use of this e-mail (and/or its attachments) or any part thereof is prohibited. If you receive this e-mail in error, please notify us immediately and delete this mail as well as its attachment(s) from your system. In addition, please be informed that collection, processing, and/or use of personal data is prohibited unless expressly permitted by personal data protection laws. Thank you for your attention and cooperation. Macronix International Co., Ltd. =====================================================================
WARNING: multiple messages have this Message-ID (diff)
From: zhengxunli@mxic.com.tw To: "Pratyush Yadav" <p.yadav@ti.com> Cc: broonie@kernel.org, jaimeliao@mxic.com.tw, linux-mtd@lists.infradead.org, linux-spi@vger.kernel.org, miquel.raynal@bootlin.com, tudor.ambarus@microchip.com Subject: Re: [PATCH v5 2/2] spi: mxic: patch for octal DTR mode support Date: Tue, 18 May 2021 10:47:36 +0800 [thread overview] Message-ID: <OF3240723E.EAE563CF-ON482586D9.000E8308-482586D9.000F5865@mxic.com.tw> (raw) In-Reply-To: <20210517160628.s65h6prjt5mw6bud@ti.com> Hi, "Pratyush Yadav" <p.yadav@ti.com> wrote on 2021/05/18 上午 12:06:30: > "Pratyush Yadav" <p.yadav@ti.com> > 2021/05/18 上午 12:06 > > To > > "Zhengxun Li" <zhengxunli@mxic.com.tw>, > > cc > > <linux-mtd@lists.infradead.org>, <linux-spi@vger.kernel.org>, > <tudor.ambarus@microchip.com>, <miquel.raynal@bootlin.com>, > <broonie@kernel.org>, <jaimeliao@mxic.com.tw> > > Subject > > Re: [PATCH v5 2/2] spi: mxic: patch for octal DTR mode support > > On 17/05/21 02:14PM, Zhengxun Li wrote: > > Driver patch for octal DTR mode support. > > > > Owing to the spi_mem_default_supports_op() is not support dtr > > operation. Based on Pratyush patch "spi: spi-mem: add spi_mem_dtr > > I don't like the "Based on Pratyush patch". Please mention the commit > hash so it is much easier to find later. For example, saying based on > commit 539cf68cd51b (spi: spi-mem: add spi_mem_dtr_supports_op(), > 2021-02-04) is much better. > > But while we are on this topic, I don't think it is needed all that > much. People use pre-existing APIs all the time. I don't see any need to > specifically point it out. So I think saying "Call > spi_mem_dtr_supports_op() to ..." is better. Thanks for your suggestion. > > _supports_op()" add spi_mem_dtr_supports_op() to support dtr and > > keep checking the buswidth and command bytes. > > > > Signed-off-by: Zhengxun Li <zhengxunli@mxic.com.tw> > > --- Thanks, Zhengxun CONFIDENTIALITY NOTE: This e-mail and any attachments may contain confidential information and/or personal data, which is protected by applicable laws. Please be reminded that duplication, disclosure, distribution, or use of this e-mail (and/or its attachments) or any part thereof is prohibited. If you receive this e-mail in error, please notify us immediately and delete this mail as well as its attachment(s) from your system. In addition, please be informed that collection, processing, and/or use of personal data is prohibited unless expressly permitted by personal data protection laws. Thank you for your attention and cooperation. Macronix International Co., Ltd. ===================================================================== ============================================================================ CONFIDENTIALITY NOTE: This e-mail and any attachments may contain confidential information and/or personal data, which is protected by applicable laws. Please be reminded that duplication, disclosure, distribution, or use of this e-mail (and/or its attachments) or any part thereof is prohibited. If you receive this e-mail in error, please notify us immediately and delete this mail as well as its attachment(s) from your system. In addition, please be informed that collection, processing, and/or use of personal data is prohibited unless expressly permitted by personal data protection laws. Thank you for your attention and cooperation. Macronix International Co., Ltd. ===================================================================== ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2021-05-18 2:48 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-05-17 6:14 [PATCH v5 0/2] Add octal DTR support for Macronix flash Zhengxun Li 2021-05-17 6:14 ` Zhengxun Li 2021-05-17 6:14 ` [PATCH v5 1/2] mtd: spi-nor: macronix: add support for Macronix octaflash Zhengxun Li 2021-05-17 6:14 ` Zhengxun Li 2021-05-17 7:33 ` Pratyush Yadav 2021-05-17 7:33 ` Pratyush Yadav 2021-06-29 2:06 ` zhengxunli 2021-06-29 2:06 ` zhengxunli 2021-06-29 6:37 ` Tudor.Ambarus 2021-06-29 6:37 ` Tudor.Ambarus 2021-06-29 9:33 ` zhengxunli 2021-06-29 9:33 ` zhengxunli 2021-06-30 9:03 ` zhengxunli 2021-06-30 9:03 ` zhengxunli 2021-05-17 6:14 ` [PATCH v5 2/2] spi: mxic: patch for octal DTR mode support Zhengxun Li 2021-05-17 6:14 ` Zhengxun Li 2021-05-17 15:49 ` Mark Brown 2021-05-17 15:49 ` Mark Brown 2021-05-17 16:06 ` Pratyush Yadav 2021-05-17 16:06 ` Pratyush Yadav 2021-05-18 2:47 ` zhengxunli [this message] 2021-05-18 2:47 ` zhengxunli
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=OF3240723E.EAE563CF-ON482586D9.000E8308-482586D9.000F5865@mxic.com.tw \ --to=zhengxunli@mxic.com.tw \ --cc=broonie@kernel.org \ --cc=jaimeliao@mxic.com.tw \ --cc=linux-mtd@lists.infradead.org \ --cc=linux-spi@vger.kernel.org \ --cc=miquel.raynal@bootlin.com \ --cc=p.yadav@ti.com \ --cc=tudor.ambarus@microchip.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.