From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bastian.Ruppert at sewerin.de <Bastian.Ruppert@sewerin.de>
Date: Tue, 11 Sep 2012 07:32:13 +0200
Subject: [U-Boot] [PATCH v3 5/6] da850/omap-l138: davinci_emac: Suppress
 auto negotiation if needed
In-Reply-To: <504EBB2C.4070604@ti.com>
References: <1346538565-1821-1-git-send-email-agust@denx.de>	<1346911659-3080-5-git-send-email-Bastian.Ruppert@Sewerin.de>
	<CA+V-a8uZzTY0pdUR-4=uZdhG+T5=AL5JOuPti2Mtcc9vrJda1g@mail.gmail.com>	<CA+M6bXkff9YjNbLWBHnfz2xHM2i47njzCFgd85so5E7rfXGdXg@mail.gmail.com>
	<OF122D77D8.3575244C-ONC1257A75.001EA7E5-C1257A75.00214E17@sewerin.de>	<CA+M6bXkrM8SijTYnfO2tusZfpiwNM2ybEbD3MeonLvq7vNNXNg@mail.gmail.com>
	<504EBB2C.4070604@ti.com>
Message-ID: <OF363D191F.07602EE3-ONC1257A76.001DAC5B-C1257A76.001E9E8B@sewerin.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hello, Prabhakar, hello Tom

> On Monday 10 September 2012 09:38 PM, Tom Rini wrote:
> > On Sun, Sep 9, 2012 at 11:01 PM,  <Bastian.Ruppert@sewerin.de> wrote:
> >> Hello,
> >>
> >>> Re: [U-Boot] [PATCH v3 5/6] da850/omap-l138: davinci_emac: Suppress
> >>> auto negotiation if needed
> >>>
> >>> On Fri, Sep 7, 2012 at 1:08 AM, Prabhakar Lad
> >>> <prabhakar.csengg@gmail.com> wrote:
> >>>> Hi Bastian,
> >>>>
> >>>> Thanks for the patch.
> >>>>
> >>>> On Thu, Sep 6, 2012 at 11:37 AM, Bastian Ruppert
> >>>> <Bastian.Ruppert@sewerin.de> wrote:
> >>>>> From this commit id: b78375a806ed04eb22b963255cfdef8df702de47 auto
> >>>>> negotiation is enabled in RMII mode. Some boards based on da850
need
> >>>>> to suppress this procedure.
> >>>>>
> >>>>> CC: Rajashekhara, Sudhakar <sudhakar.raj@ti.com>
> >>>>> CC: Lad, Prabhakar <prabhakar.lad@ti.com>
> >>>>> CC: Hadli, Manjunath <manjunath.hadli@ti.com>
> >>>>> CC: sbabic at denx.de
> >>>>> Acked-by: Stefano Babic <sbabic@denx.de>
> >>>>> CC: Tom Rini <trini@ti.com>
> >>>>> Signed-off-by: Bastian Ruppert <Bastian.Ruppert@Sewerin.de>
> >>>>> ---
> >>>>>  drivers/net/davinci_emac.c |    3 ++-
> >>>>>  1 files changed, 2 insertions(+), 1 deletions(-)
> >>>>>
> >>>>> diff --git a/drivers/net/davinci_emac.c
b/drivers/net/davinci_emac.c
> >>>>> index b2516d1..fe988d7 100644
> >>>>> --- a/drivers/net/davinci_emac.c
> >>>>> +++ b/drivers/net/davinci_emac.c
> >>>>> @@ -897,7 +897,8 @@ int davinci_emac_initialize(void)
> >>>>>         }
> >>>>>
> >>>>>  #if defined(CONFIG_DRIVER_TI_EMAC_USE_RMII) && \
> >>>>> -               defined(CONFIG_MACH_DAVINCI_DA850_EVM)
> >>>>> +               defined(CONFIG_MACH_DAVINCI_DA850_EVM) && \
> >>>>> +                       !defined(CONFIG_DRIVER_TI_EMAC_RMII_NONEG)
> >>>> instead of CONFIG_DRIVER_TI_EMAC_RMII_NONEG why not have
> >>>> CONFIG_DRIVER_TI_EMAC_RMII_AUTO_NEGOTIATE ?
> >>>
> >>> Good idea, opt-in is better than opt-out, please make it so.
> >>>
> >>
> >> i can see what you mean! But in this case i would like to answer back.
> >> Normally, one almost certainly use the auto negotiation. On the ea20
> >> board there is a seldom case where auto negotiation is
counterproductive.
> >> In my opinion the feature "disable it" is opt-in.
> >> So i would like to leave it as it is.
> >
> > I will defer to Prabhakar for a final answer on this.
> >
> Ok. 'NONEG' doesn't sound good can you make it NO_NEGOTIATE ?
>

Ok, i will use CONFIG_DRIVER_TI_EMAC_RMII_NO_NEGOTIATE. It is not too long,
isn?t it?

Tom, would you like to receive a complete v4 patch series for this?
Or should i post version 4 for the affected patches only?

Thanks,

Bastian.