Hi Al= l,

please confirm on following

Boost-bus - compilation fails . Is it used? Should be archived @an= drewj?

Google-ipmi-i2c - code compiles well, complain in formatting script @<= span>pstrink= le
subsys_initcall(i2c_via_ipmi_init);^[[m^M
Traceback (mo= st recent call last):^M
File "/home/lkammath/final_data/unit-test= .py", line 826, in <module>^M
    check_call_cmd(".= /format-code.sh", CODE_SCAN_DIR)^M
File "/home/lkammath/final_dat= a/unit-test.py", line 229, in check_call_cmd^M
    check_= call(cmd)^M
File "/usr/lib/python2.7/subprocess.py", line 190, in= check_call^M
    raise CalledProcessError(retcode, cmd)^= M
subprocess.CalledProcessError: Command '('./format-code.sh', '/home/lk= ammath/final_data/google-ipmi-i2c')' returned non-zero exit status 1^M
T= raceback (most recent call last):^M
File "/home/lkammath/final_da= ta/dbus-unit-test.py", line 91, in <module>^M

Inarp.git - Should be archived @andrewj?
Compilation issue
i= narp.c: In function =E2=80=98arp_recv=E2=80=99:
inarp.c:433:4: error: ta= king address of packed member of =E2=80=98struct arp_packet=E2=80=99 may re= sult in an unaligned pointer value [-Werror=3Daddress-of-packed-member]
= 433 |    &inarp_req.src_ip);
   = ;   |    ^~~~~~~~~~~~~~~~~
In function =E2=80= =98do_ifreq=E2=80=99,
    inlined from =E2=80=98get_local= _ipaddr=E2=80=99 at inarp.c:182:7,
    inlined from =E2= =80=98arp_recv=E2=80=99 at inarp.c:419:7,
    inlined fro= m =E2=80=98main=E2=80=99 at inarp.c:480:4:
inarp.c:170:2: error: =E2=80= =98strncpy=E2=80=99 output may be truncated copying 16 bytes from a string = of length 16 [-Werror=3Dstringop-truncation]
170 | strncpy(= ifreq->ifr_name, ifname, sizeof(ifreq->ifr_name));
  &nb= sp;   | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~= ~~~~~~
cc1: all warnings being treated as errors
make[1]: *** [inarp.= o] Error 1
make[1]: Leaving directory `/esw/san5/lkammath/boost/inarp'make: *** [all] Error 2

In CI environment
ool.la -lncurses -ltinfo -lcrypto^M
copy= ing selected object files to avoid basename conflicts...^M
ar: `u' modif= ier ignored since `D' is the default (see `U')^M
make[4]: Leaving direct= ory '/home/lkammath/final_data/ipmitool/src/plugins/lan'^M
Making all in= lanplus^M
make[4]: Entering directory '/home/lkammath/final_data/ipmito= ol/src/plugins/lanplus'^M
/bin/bash ../../../libtool --silent --ta= g=3DCC   --mode=3Dcompile gcc -DHAVE_CONFIG_H -I. -I../../.. -I..= /../../include    -g -O2 -Wall -Wextra -std=3Dc99 -pedantic = -Wformat -Wformat-nonliteral -MT lanplus_crypt_impl.lo -MD -MP -MF .deps/la= nplus_crypt_impl.Tpo -c -o lanplus_crypt_impl.lo lanplus_crypt_impl.c^M
= lanplus_crypt_impl.c: In function 'lanplus_encrypt_aes_cbc_128':^M
lanpl= us_crypt_impl.c:158:17: error: storage size of 'ctx' isn't known^M
= ; 158 | EVP_CIPHER_CTX ctx;^M
      |&nbs= p;            &= nbsp;   ^~~^M
lanplus_crypt_impl.c:158:17: warning: unused var= iable 'ctx' [-Wunused-variable]^M
lanplus_crypt_impl.c: In function 'lan= plus_decrypt_aes_cbc_128':^M
lanplus_crypt_impl.c:233:17: error: storage= size of 'ctx' isn't known^M
233 | EVP_CIPHER_CTX ctx;^M      |       =           ^~~^M

Smbios-mdr - @brad. Please confirm if used?
No automake env (ma= ke)

Thanks &= amp; Regards,
Lakshminarayana Kamath
--------------------------------= ------------------------------------------------------------------

----- Original message -----
From: "Andrew Jeffery" &= lt;andrew@aj.id.au>
To: "Lakshminarayana R Kammath" <lkammath@in.i= bm.com>, openbmc@lists.ozlabs.org
Cc:
Subject: [EXTERNAL] Re: [Ope= nBMC]: Unit test coverage analysis on openbmc repositories
Date: Tue, Ma= r 3, 2020 10:18 AM

On Sat, 29 Feb 2020, at 02:05, Lakshminarayana R Kammath wrote:
> https://github.com/openbmc/obmc-console.git  YES, UN= IT TEST

I need to add coverage support to obmc-console.

> = = https://github.com/openbmc/openbmc-tools.git  NO

Not s= ure we can expect anything for openbmc-tools - it's a collection
of rand= om scripts people have written to make their life developing
openbmc eas= ier. It's not something that should have strict QA
processes.

>= ; https://github.com/openbmc/openpower-host-ipmi-flash.git&= nbsp; NO

I should add some tests here where I can.

> = https:= //github.com/openbmc/hiomapd.git  YES, UNIT TEST
> https://gi= thub.com/openbmc/libmctp.git  YES, UNIT TEST
> ht= tps://github.com/openbmc/phosphor-led-sysfs.git  YES, UNIT TE= ST

These three do in-fact have GCOV/LCOV support, you need to do the= usual autotools invocations to get it:

```
./configure --enable-= code-coverage && make check-code-coverage
```

> https= ://github.com/openbmc/phosphor-mboxd.git  ERROR

This i= s archived.

...

> https://github.com/openbmc/u-boot  NO=

This uses Kbuild as a build system. I notice openbmc/linux and open= bmc/qemu aren't included in the list.

> https://github.com/openbmc/we= bui-vue.git  NO
> https://github.com/open= bmc/witherspoon-pfault-analysis.git  YES, COVERAGE
> https://github.com/openbmc/x86-power-control.git  NO
>= ; *************************UNIT TEST COVERAGE
> REPORT***************= **********
> SUMMARY:
> TOTAL REPOSITORIES : 110
> TESTED= REPOSITORIES : 43
> ERROR : 11
> COVERAGE REPORT : 12
> = UNIT TEST REPORT : 31
> NO REPORT : 56
> **********************= *****************************************************
> Following act= ions, we can draw from above
>
> 1. *There are 12 repo's = that have GCOV/LCOV plugged in* - We need to
> maintain which has goo= d coverage and try to improve those which has
> less coverage
>= 2. *There are 31 repo's that have unit test cases added but no
&g= t; coverage analysis because they aren't plugged in yet to GCOV/LCOV* - Is<= br>> there a plan for plugging in GCOV

As above at least three of= these are false-negatives for test coverage.

Andrew
= ;