From mboxrd@z Thu Jan 1 00:00:00 1970 From: j.nixdorf@avm.de Date: Fri, 27 Nov 2020 11:58:57 +0100 Subject: [LTP] [PATCH] netstress: explicitly set a thread stack size In-Reply-To: <9c761b66-89c6-9121-88bb-44e98b9a64cb@oracle.com> References: <9c761b66-89c6-9121-88bb-44e98b9a64cb@oracle.com>, Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ltp@lists.linux.it -----"Alexey Kodanev" wrote: ----- >On 26.11.2020 17:52, Johannes Nixdorf via ltp wrote: >It doesn't mean you should intentionally pass unaligned size. > >And on it's man-page [1], in errors section, there is a note that it >might >return EINVAL for some systems if the stack size not multiple of page >size. Ok. I was going by the POSIX man page [1], which doesn't mention that practice. [1]: https://pubs.opengroup.org/onlinepubs/9699919799/functions/pthread_attr_setstacksize.html >max_msg_len is const. It seems like I was misreading [2] to mean it sets max_msg_len instead of using it as a limit. [2]: https://github.com/linux-test-project/ltp/blob/master/testcases/network/netstress/netstress.c#L854 Thanks for the review, I'll change it to go with your proposed static limit. Regards, Johannes