From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F286DC433E0 for ; Fri, 5 Jun 2020 02:54:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DC0B6207DA for ; Fri, 5 Jun 2020 02:54:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726068AbgFECy7 (ORCPT ); Thu, 4 Jun 2020 22:54:59 -0400 Received: from twhmllg3.macronix.com ([211.75.127.131]:17489 "EHLO TWHMLLG3.macronix.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725954AbgFECy7 (ORCPT ); Thu, 4 Jun 2020 22:54:59 -0400 Received: from twhfmlp1.macronix.com (twhfmlp1.macronix.com [172.17.20.91]) by TWHMLLG3.macronix.com with ESMTP id 0552rtPd075823; Fri, 5 Jun 2020 10:53:55 +0800 (GMT-8) (envelope-from masonccyang@mxic.com.tw) Received: from MXML06C.mxic.com.tw (mxml06c.macronix.com [172.17.14.55]) by Forcepoint Email with ESMTP id 25B3BC43AAFD1364824D; Fri, 5 Jun 2020 10:53:55 +0800 (CST) In-Reply-To: <20200603055359.y35dwznglc7tlewq@yadavpratyush.com> References: <1590737775-4798-1-git-send-email-masonccyang@mxic.com.tw> <1590737775-4798-8-git-send-email-masonccyang@mxic.com.tw> <20200529094202.7vjs7clhykncivux@yadavpratyush.com> <20200603055359.y35dwznglc7tlewq@yadavpratyush.com> To: "Pratyush Yadav" Cc: boris.brezillon@collabora.com, broonie@kernel.org, juliensu@mxic.com.tw, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, linux-spi@vger.kernel.org, matthias.bgg@gmail.com, miquel.raynal@bootlin.com, p.yadav@ti.com, richard@nod.at, tudor.ambarus@microchip.com, vigneshr@ti.com Subject: Re: [PATCH v4 7/7] mtd: spi-nor: macronix: Add Octal 8D-8D-8D supports for Macronix mx25uw51245g MIME-Version: 1.0 X-KeepSent: 72696CF7:123ABE04-4825857E:000F9054; type=4; name=$KeepSent X-Mailer: Lotus Notes Release 8.5.3FP4 SHF90 June 10, 2013 Message-ID: From: masonccyang@mxic.com.tw Date: Fri, 5 Jun 2020 10:53:55 +0800 X-MIMETrack: Serialize by Router on MXML06C/TAIWAN/MXIC(Release 9.0.1FP10 HF265|July 25, 2018) at 2020/06/05 AM 10:53:55, Serialize complete at 2020/06/05 AM 10:53:55 Content-Type: text/plain; charset="US-ASCII" X-MAIL: TWHMLLG3.macronix.com 0552rtPd075823 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > > > > > > > +#define MXIC_CR2_DUMMY_SET_ADDR 0x300 > > > > + > > > > +/* Fixup the dummy cycles to device and setup octa_dtr_enable() */ > > > > +static void mx25uw51245g_post_sfdp_fixups(struct spi_nor *nor) > > > > +{ > > > > + struct spi_nor_flash_parameter *params = nor->params; > > > > + int ret; > > > > + u8 rdc, wdc; > > > > + > > > > + ret = spi_nor_read_cr2(nor, MXIC_CR2_DUMMY_SET_ADDR, &rdc); > > > > + if (ret) > > > > + return; > > > > + > > > > + /* Refer to dummy cycle and frequency table(MHz) */ > > > > + switch (params->dummy_cycles) { > > > > + case 10: /* 10 dummy cycles for 104 MHz */ > > > > + wdc = 5; > > > > + break; > > > > + case 12: /* 12 dummy cycles for 133 MHz */ > > > > + wdc = 4; > > > > + break; > > > > + case 16: /* 16 dummy cycles for 166 MHz */ > > > > + wdc = 2; > > > > + break; > > > > + case 18: /* 18 dummy cycles for 173 MHz */ > > > > + wdc = 1; > > > > + break; > > > > + case 20: /* 20 dummy cycles for 200 MHz */ > > > > + default: > > > > + wdc = 0; > > > > + } > > > > > > I don't get the point of this. You already know the fastest the > > > mx25uw51245g flash can run at. Why not just use the maximum dummy > > > cycles? SPI NOR doesn't know the speed the controller is running at so > > > the best it can do is use the maximum dummy cycles possible so it never > > > falls short. Sure, it will be _slightly_ less performance, but we will > > > be sure to read the correct data, which is much much more important. > > > > In general, 200MHz needs 20 dummy cycles but some powerful device may only > > > > needs 18 dummy cycles or less. > > Yes, but do different mx25uw51245g chips have different dummy cycle > requirements? Shouldn't all the chips with the same ID have same > performance? > Same chip ID but different grade, i.e., commercial or industrial grade. thanks & best regards, Mason CONFIDENTIALITY NOTE: This e-mail and any attachments may contain confidential information and/or personal data, which is protected by applicable laws. Please be reminded that duplication, disclosure, distribution, or use of this e-mail (and/or its attachments) or any part thereof is prohibited. If you receive this e-mail in error, please notify us immediately and delete this mail as well as its attachment(s) from your system. In addition, please be informed that collection, processing, and/or use of personal data is prohibited unless expressly permitted by personal data protection laws. Thank you for your attention and cooperation. Macronix International Co., Ltd. ===================================================================== ============================================================================ CONFIDENTIALITY NOTE: This e-mail and any attachments may contain confidential information and/or personal data, which is protected by applicable laws. Please be reminded that duplication, disclosure, distribution, or use of this e-mail (and/or its attachments) or any part thereof is prohibited. If you receive this e-mail in error, please notify us immediately and delete this mail as well as its attachment(s) from your system. In addition, please be informed that collection, processing, and/or use of personal data is prohibited unless expressly permitted by personal data protection laws. Thank you for your attention and cooperation. Macronix International Co., Ltd. ===================================================================== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9296EC433DF for ; Fri, 5 Jun 2020 02:54:46 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 63A6820738 for ; Fri, 5 Jun 2020 02:54:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="jybywqz9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 63A6820738 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mxic.com.tw Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Date:From:Message-ID:MIME-Version: Subject:To:References:In-Reply-To:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Mepvo6DKHaN/nBynwVSLLvjzeHL26rpzSl3uW4Dxji0=; b=jybywqz9830ePR mvTODV1wccVFCUxGuONSbKrF7thaMTtd2oqePSGWJabmheu5RantEmAqdqfCgAOHsPmoaOBibb9oI xUE4bofmvUOfTBB92meXkGz6pEDnwQIjer8saHw9qFFZDl7ZU8SYwnNz5dwn1kJKH1MWY3b5kfHzS jwthhSIxjUMDPua1rYXCFGhQ0c667kvdTES/iOhk/eEvCoH7B1DsThEvJ+fCT3GbMJqF1KYaIzy5n 5YJnY0e/iE3Fs95LR1oKHTtamfDPy9GYQuBfNLyzhavHioyPyEGQ0VWyees1khgpLoI+c++26LPvq FcZLMHHKFa43TlARevsg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jh2VA-0002dg-BC; Fri, 05 Jun 2020 02:54:36 +0000 Received: from [122.147.135.201] (helo=TWHMLLG3.macronix.com) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jh2V7-0002cr-5W for linux-mtd@lists.infradead.org; Fri, 05 Jun 2020 02:54:34 +0000 Received: from twhfmlp1.macronix.com (twhfmlp1.macronix.com [172.17.20.91]) by TWHMLLG3.macronix.com with ESMTP id 0552rtPd075823; Fri, 5 Jun 2020 10:53:55 +0800 (GMT-8) (envelope-from masonccyang@mxic.com.tw) Received: from MXML06C.mxic.com.tw (mxml06c.macronix.com [172.17.14.55]) by Forcepoint Email with ESMTP id 25B3BC43AAFD1364824D; Fri, 5 Jun 2020 10:53:55 +0800 (CST) In-Reply-To: <20200603055359.y35dwznglc7tlewq@yadavpratyush.com> References: <1590737775-4798-1-git-send-email-masonccyang@mxic.com.tw> <1590737775-4798-8-git-send-email-masonccyang@mxic.com.tw> <20200529094202.7vjs7clhykncivux@yadavpratyush.com> <20200603055359.y35dwznglc7tlewq@yadavpratyush.com> To: "Pratyush Yadav" Subject: Re: [PATCH v4 7/7] mtd: spi-nor: macronix: Add Octal 8D-8D-8D supports for Macronix mx25uw51245g MIME-Version: 1.0 X-KeepSent: 72696CF7:123ABE04-4825857E:000F9054; type=4; name=$KeepSent X-Mailer: Lotus Notes Release 8.5.3FP4 SHF90 June 10, 2013 Message-ID: From: masonccyang@mxic.com.tw Date: Fri, 5 Jun 2020 10:53:55 +0800 X-MIMETrack: Serialize by Router on MXML06C/TAIWAN/MXIC(Release 9.0.1FP10 HF265|July 25, 2018) at 2020/06/05 AM 10:53:55, Serialize complete at 2020/06/05 AM 10:53:55 X-MAIL: TWHMLLG3.macronix.com 0552rtPd075823 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200604_195433_500949_652AD2AA X-CRM114-Status: GOOD ( 11.48 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: vigneshr@ti.com, tudor.ambarus@microchip.com, juliensu@mxic.com.tw, richard@nod.at, miquel.raynal@bootlin.com, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, broonie@kernel.org, linux-mtd@lists.infradead.org, boris.brezillon@collabora.com, matthias.bgg@gmail.com, p.yadav@ti.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org > > > > > > > > +#define MXIC_CR2_DUMMY_SET_ADDR 0x300 > > > > + > > > > +/* Fixup the dummy cycles to device and setup octa_dtr_enable() */ > > > > +static void mx25uw51245g_post_sfdp_fixups(struct spi_nor *nor) > > > > +{ > > > > + struct spi_nor_flash_parameter *params = nor->params; > > > > + int ret; > > > > + u8 rdc, wdc; > > > > + > > > > + ret = spi_nor_read_cr2(nor, MXIC_CR2_DUMMY_SET_ADDR, &rdc); > > > > + if (ret) > > > > + return; > > > > + > > > > + /* Refer to dummy cycle and frequency table(MHz) */ > > > > + switch (params->dummy_cycles) { > > > > + case 10: /* 10 dummy cycles for 104 MHz */ > > > > + wdc = 5; > > > > + break; > > > > + case 12: /* 12 dummy cycles for 133 MHz */ > > > > + wdc = 4; > > > > + break; > > > > + case 16: /* 16 dummy cycles for 166 MHz */ > > > > + wdc = 2; > > > > + break; > > > > + case 18: /* 18 dummy cycles for 173 MHz */ > > > > + wdc = 1; > > > > + break; > > > > + case 20: /* 20 dummy cycles for 200 MHz */ > > > > + default: > > > > + wdc = 0; > > > > + } > > > > > > I don't get the point of this. You already know the fastest the > > > mx25uw51245g flash can run at. Why not just use the maximum dummy > > > cycles? SPI NOR doesn't know the speed the controller is running at so > > > the best it can do is use the maximum dummy cycles possible so it never > > > falls short. Sure, it will be _slightly_ less performance, but we will > > > be sure to read the correct data, which is much much more important. > > > > In general, 200MHz needs 20 dummy cycles but some powerful device may only > > > > needs 18 dummy cycles or less. > > Yes, but do different mx25uw51245g chips have different dummy cycle > requirements? Shouldn't all the chips with the same ID have same > performance? > Same chip ID but different grade, i.e., commercial or industrial grade. thanks & best regards, Mason CONFIDENTIALITY NOTE: This e-mail and any attachments may contain confidential information and/or personal data, which is protected by applicable laws. Please be reminded that duplication, disclosure, distribution, or use of this e-mail (and/or its attachments) or any part thereof is prohibited. If you receive this e-mail in error, please notify us immediately and delete this mail as well as its attachment(s) from your system. In addition, please be informed that collection, processing, and/or use of personal data is prohibited unless expressly permitted by personal data protection laws. Thank you for your attention and cooperation. Macronix International Co., Ltd. ===================================================================== ============================================================================ CONFIDENTIALITY NOTE: This e-mail and any attachments may contain confidential information and/or personal data, which is protected by applicable laws. Please be reminded that duplication, disclosure, distribution, or use of this e-mail (and/or its attachments) or any part thereof is prohibited. If you receive this e-mail in error, please notify us immediately and delete this mail as well as its attachment(s) from your system. In addition, please be informed that collection, processing, and/or use of personal data is prohibited unless expressly permitted by personal data protection laws. Thank you for your attention and cooperation. Macronix International Co., Ltd. ===================================================================== ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/