Re: [PATCH] multipathd: uxsock_timeout should be assigned by conf->uxsock_timeout

[tang.junhui@zte.com.cn]

[-- Attachment #1.1: Type: text/plain, Size: 2172 bytes --]

Please have a review for this patch, any comment will be highly 
appreciated.




发件人:         tang.junhui@zte.com.cn
收件人:         christophe varoqui <christophe.varoqui@free.fr>, 
抄送:   zhang.kai16@zte.com.cn, dm-devel@redhat.com, "tang.junhui" 
<tang.junhui@zte.com.cn>
日期:   2016/09/13 18:17
主题:   [dm-devel] [PATCH] multipathd: uxsock_timeout should be assigned 
by      conf->uxsock_timeout
发件人: dm-devel-bounces@redhat.com



From: "tang.junhui" <tang.junhui@zte.com.cn>

uxsock_timeout should be assigned by conf->uxsock_timeout
before using it in uxclnt() as a CLI client timeout value,
otherwise its default value is 0, and the CLI client timeout
value is 0 + 100(ms), so the CLI client will be timeout very
quickly.

Signed-off-by: tang.junhui <tang.junhui@zte.com.cn>
---
 multipathd/main.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/multipathd/main.c b/multipathd/main.c
index 96ef01f..a08f1a5 100644
--- a/multipathd/main.c
+++ b/multipathd/main.c
@@ -2549,6 +2549,7 @@ main (int argc, char *argv[])
                                                                 exit(1);
                                                 if (verbosity)
 conf->verbosity = verbosity;
+                                                uxsock_timeout = 
conf->uxsock_timeout;
                                                 uxclnt(optarg, 
uxsock_timeout + 100);
                                                 exit(0);
                                 case 'B':
@@ -2573,6 +2574,7 @@ main (int argc, char *argv[])
                                                 exit(1);
                                 if (verbosity)
                                                 conf->verbosity = 
verbosity;
+                                uxsock_timeout = conf->uxsock_timeout;
                                 memset(cmd, 0x0, CMDSIZE);
                                 while (optind < argc) {
                                                 if (strchr(argv[optind], 
' '))
-- 
2.8.1.windows.1

--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel



[-- Attachment #1.2: Type: text/html, Size: 5229 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]