All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bernhard Messerklinger <bernhard.messerklinger@br-automation.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] Antwort: Re: [PATCH] spi: mxc_spi: Fix chipselect with DM_SPI in SPL
Date: Tue, 4 Sep 2018 10:54:56 +0200	[thread overview]
Message-ID: <OF7E458542.13523DE2-ONC12582FE.002F5712-C12582FE.0030F9F2@LocalDomain> (raw)
In-Reply-To: <CAMty3ZD8qcnhmPLJKFZQBaLrAH81CFpFLgakYqYGBZ63BfuXFg@mail.gmail.com>

Hi Jagan,

it's not about any size constraint.
To my understanding the macro CONFIG_IS_ENABLED(DM_SPI) is true if 
CONFIG_SPL_DM_SPI is defined during SPL build. Please tell me if I am 
wrong.
At the moment this configuration parameter doesn't exist, so I used a 
#ifdef
which works with CONFIG_DM_SPI.

Would you prefer to add CONFIG_SPL_DM_SPI as configuration parameter?

Bernhard



Von:    Jagan Teki <jagan@amarulasolutions.com>
An:     Bernhard Messerklinger <bernhard.messerklinger@br-automation.com>, 

Kopie:  U-Boot-Denx <u-boot@lists.denx.de>, Jagan Teki 
<jagan@openedev.com>
Datum:  03.09.2018 18:33
Betreff:        Re: [U-Boot] [PATCH] spi: mxc_spi: Fix chipselect with 
DM_SPI in SPL



On Mon, Sep 3, 2018 at 4:02 PM, Bernhard Messerklinger
<bernhard.messerklinger@br-automation.com> wrote:
> Since CONFIG_IS_ENABLED(DM_SPI) is not working in SPL because
> CONFIG_SPL_DM_SPI is not defined we should go with #ifdef CONFIG_DM_SPI.

Better enabled it for SPL, did you find any size constraint? if yet
try for platdata?

  reply	other threads:[~2018-09-04  8:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-03 10:32 [U-Boot] [PATCH] spi: mxc_spi: Fix chipselect with DM_SPI in SPL Bernhard Messerklinger
2018-09-03 16:33 ` Jagan Teki
2018-09-04  8:54   ` Bernhard Messerklinger [this message]
2018-10-30 13:21     ` [U-Boot] Antwort: " Bernhard Messerklinger
2018-10-30 13:28     ` [U-Boot] " Jagan Teki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=OF7E458542.13523DE2-ONC12582FE.002F5712-C12582FE.0030F9F2@LocalDomain \
    --to=bernhard.messerklinger@br-automation.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.