From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750852AbXBQPxU (ORCPT ); Sat, 17 Feb 2007 10:53:20 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750856AbXBQPxU (ORCPT ); Sat, 17 Feb 2007 10:53:20 -0500 Received: from mtagate7.de.ibm.com ([195.212.29.156]:59846 "EHLO mtagate7.de.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750852AbXBQPxT convert rfc822-to-8bit (ORCPT ); Sat, 17 Feb 2007 10:53:19 -0500 In-Reply-To: <45D6CC81.1040004@246tNt.com> To: Sylvain Munaut Cc: Hoang-Nam Nguyen , johnrose@us.ibm.com, linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org, paulus@samba.org, pmac@au1.ibm.com MIME-Version: 1.0 Subject: Re: [PATCH 2.6.21-rc1] ibmebus: Use of_device_uevent() X-Mailer: Lotus Notes Release 7.0 HF277 June 21, 2006 From: Joachim Fenkes Message-ID: Date: Sat, 17 Feb 2007 10:53:15 -0500 X-MIMETrack: Serialize by Router on D12ML064/12/M/IBM(Release 6.5.5HF882 | September 26, 2006) at 17/02/2007 16:53:15, Serialize complete at 17/02/2007 16:53:15 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Sylvain Munaut wrote on 17.02.2007 04:36:01: > Doesn't that oops when called with the fake parent device ? I should stop posting patches after 12 hours of work ,) > Or, an even better approach is to add this > > + if (!ebus_dev->ofdev.node) > + return -ENODEV; > > inside the code of of_device_uevent itself. Nice! Patch will follow. Thanks again, Joachim --- Joachim Fenkes -- eHCA Linux Driver Developer and Hardware Tamer extraordinaire IBM Deutschland Entwicklung GmbH -- Dept. 3627 (I/O Firmware Development 2) Schoenaicher Strasse 220 -- 71032 Boeblingen -- Germany eMail: fenkes@de.ibm.com -- Phone: +49 7031 16 1239 Vorsitzender des Aufsichtsrats: Johann Weihen -- Geschäftsführung: Herbert Kircher Sitz der Gesellschaft: Böblingen -- Registergericht: Amtsgericht Stuttgart, HRB 243294 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mtagate6.de.ibm.com (mtagate6.de.ibm.com [195.212.29.155]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mtagate6.de.ibm.com", Issuer "Equifax" (verified OK)) by ozlabs.org (Postfix) with ESMTP id C1B4EDDDF9 for ; Sun, 18 Feb 2007 02:53:22 +1100 (EST) Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate6.de.ibm.com (8.13.8/8.13.8) with ESMTP id l1HFrHit184836 for ; Sat, 17 Feb 2007 15:53:17 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.2) with ESMTP id l1HFrH9W1818676 for ; Sat, 17 Feb 2007 16:53:17 +0100 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id l1HFrGMh016482 for ; Sat, 17 Feb 2007 16:53:17 +0100 In-Reply-To: <45D6CC81.1040004@246tNt.com> To: Sylvain Munaut MIME-Version: 1.0 Subject: Re: [PATCH 2.6.21-rc1] ibmebus: Use of_device_uevent() From: Joachim Fenkes Message-ID: Date: Sat, 17 Feb 2007 10:53:15 -0500 Content-Type: text/plain; charset="ISO-8859-1" Cc: pmac@au1.ibm.com, linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org, paulus@samba.org, Hoang-Nam Nguyen , johnrose@us.ibm.com List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sylvain Munaut wrote on 17.02.2007 04:36:01: > Doesn't that oops when called with the fake parent device ? I should stop posting patches after 12 hours of work ,) > Or, an even better approach is to add this >=20 > + if (!ebus=5Fdev->ofdev.node) > + return -ENODEV; >=20 > inside the code of of=5Fdevice=5Fuevent itself. Nice! Patch will follow. Thanks again, Joachim --- Joachim Fenkes -- eHCA Linux Driver Developer and Hardware Tamer=20 extraordinaire IBM Deutschland Entwicklung GmbH -- Dept. 3627 (I/O Firmware Development = 2) Schoenaicher Strasse 220 -- 71032 Boeblingen -- Germany eMail: fenkes@de.ibm.com -- Phone: +49 7031 16 1239=20 Vorsitzender des Aufsichtsrats: Johann Weihen -- Gesch=E4ftsf=FChrung:=20 Herbert Kircher Sitz der Gesellschaft: B=F6blingen -- Registergericht: Amtsgericht=20 Stuttgart, HRB 243294