From: "Bernard Metzler" <BMT@zurich.ibm.com>
To: "Leon Romanovsky" <leon@kernel.org>
Cc: "Doug Ledford" <dledford@redhat.com>,
"Jason Gunthorpe" <jgg@nvidia.com>,
"Leon Romanovsky" <leonro@nvidia.com>,
"linux-kernel" <linux-kernel@vger.kernel.org>,
"linux-rdma" <linux-rdma@vger.kernel.org>
Subject: Re: [PATCH rdma-rc] RDMA/siw: Release xarray entry
Date: Mon, 10 May 2021 08:25:27 +0000 [thread overview]
Message-ID: <OFCA0BD73F.A7CD6605-ON002586D1.002E4672-002586D1.002E467F@notes.na.collabserv.com> (raw)
In-Reply-To: <f070b59d5a1114d5a4e830346755c2b3f141cde5.1620560472.git.leonro@nvidia.com>
-----"Leon Romanovsky" <leon@kernel.org> wrote: -----
>To: "Doug Ledford" <dledford@redhat.com>, "Jason Gunthorpe"
><jgg@nvidia.com>
>From: "Leon Romanovsky" <leon@kernel.org>
>Date: 05/09/2021 01:41PM
>Cc: "Leon Romanovsky" <leonro@nvidia.com>, "Bernard Metzler"
><bmt@zurich.ibm.com>, linux-kernel@vger.kernel.org,
>linux-rdma@vger.kernel.org
>Subject: [EXTERNAL] [PATCH rdma-rc] RDMA/siw: Release xarray entry
>
>From: Leon Romanovsky <leonro@nvidia.com>
>
>The xarray entry is allocated in siw_qp_add(), but release was
>missed in case zero-sized SQ was discovered.
>
>Fixes: 661f385961f0 ("RDMA/siw: Fix handling of zero-sized Read and
>Receive Queues.")
>Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
>---
> drivers/infiniband/sw/siw/siw_verbs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/infiniband/sw/siw/siw_verbs.c
>b/drivers/infiniband/sw/siw/siw_verbs.c
>index 917c8a919f38..3f175f220a22 100644
>--- a/drivers/infiniband/sw/siw/siw_verbs.c
>+++ b/drivers/infiniband/sw/siw/siw_verbs.c
>@@ -375,7 +375,7 @@ struct ib_qp *siw_create_qp(struct ib_pd *pd,
> else {
> /* Zero sized SQ is not supported */
> rv = -EINVAL;
>- goto err_out;
>+ goto err_out_xa;
> }
> if (num_rqe)
> num_rqe = roundup_pow_of_two(num_rqe);
>--
>2.31.1
>
>
Thanks Leon!
Reviewed-by: Bernard Metzler <bmt@zurich.ibm.com>
next prev parent reply other threads:[~2021-05-10 8:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-09 11:41 [PATCH rdma-rc] RDMA/siw: Release xarray entry Leon Romanovsky
2021-05-10 8:25 ` Bernard Metzler [this message]
2021-05-10 19:22 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=OFCA0BD73F.A7CD6605-ON002586D1.002E4672-002586D1.002E467F@notes.na.collabserv.com \
--to=bmt@zurich.ibm.com \
--cc=dledford@redhat.com \
--cc=jgg@nvidia.com \
--cc=leon@kernel.org \
--cc=leonro@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.