Re: [PATCH v10 3/3] dt-bindings: mfd: Document Renesas R-Car Gen3 RPC-IF controller bindings

From: masonccyang@mxic.com.tw
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: bbrezillon@kernel.org, broonie@kernel.org,
	devicetree@vger.kernel.org,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Simon Horman <horms@verge.net.au>,
	juliensu@mxic.com.tw, lee.jones@linaro.org,
	linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
	linux-spi@vger.kernel.org, marek.vasut@gmail.com,
	mark.rutland@arm.com, robh+dt@kernel.org
Subject: Re: [PATCH v10 3/3] dt-bindings: mfd: Document Renesas R-Car Gen3 RPC-IF controller bindings
Date: Thu, 18 Apr 2019 13:55:36 +0800	[thread overview]
Message-ID: <OFCBCE0527.706EB4F2-ON482583E0.00200707-482583E0.00208EAD@mxic.com.tw> (raw)
In-Reply-To: <8720224d-76f4-c620-9e3f-91605d6fa1e3@cogentembedded.com>

[-- Attachment #1: Type: text/plain, Size: 3830 bytes --]

Hello,

> Subject
> 
> Re: [PATCH v10 3/3] dt-bindings: mfd: Document Renesas R-Car Gen3 
> RPC-IF controller bindings
> 
> On 16.04.2019 4:06, masonccyang@mxic.com.tw wrote:
> 
> >  > > Document the bindings used by the Renesas R-Car Gen3 RPC-IF 
> MFD controller.
> >  > >
> >  > > Signed-off-by: Mason Yang <masonccyang@mxic.com.tw>
> >  > > ---
> >  > >  .../devicetree/bindings/mfd/mfd-renesas-rpc.txt  | 37 +++++++++
> >  > +++++++++++++
> >  > >  1 file changed, 37 insertions(+)
> >  > >  create mode 100644 Documentation/devicetree/bindings/mfd/mfd-
> >  > renesas-rpc.txt
> >  > >
> >  > > diff --git a/Documentation/devicetree/bindings/mfd/mfd-renesas-
> >  > rpc.txt b/Documentation/devicetree/bindings/mfd/mfd-renesas-rpc.txt
> >  > > new file mode 100644
> >  > > index 0000000..bfb3d29
> >  > > --- /dev/null
> >  > > +++ b/Documentation/devicetree/bindings/mfd/mfd-renesas-rpc.txt
> >  > > @@ -0,0 +1,37 @@
> >  > > +Renesas R-Car Gen3 RPC-IF MFD controller Device Tree Bindings
> >  > > +-------------------------------------------------------------
> >  > > +
> >  > > +Required properties:
> >  > > +- compatible: should be an SoC-specific compatible value, 
followed by
> >  > > +      "renesas,rcar-gen3-rpc" as a fallback.
> >  > > +      supported SoC-specific values are:
> >  > > +      "renesas,r8a77995-rpc" (R-Car D3)
> >  > > +- reg: should contain 2 entries, one for the base address of 
rpc-
> >  > if registers,
> >  > > +   and one for the direct mapping area
> >  > > +- reg-names: should contain "regs", and "dirmap"
> >  >
> >  >    The device tree describes the hardware, not the driver. Why 
> did you remove
> >  > the "wbuf" area?
> > 
> > I don't think we should describe the hardware that driver did not 
> implement it
> > because there are still many RPC registers we don't use them.
> 
>     I have to repeat: we describe the hardware, not the driver 
capabilities.

how about:

 - reg: should contain three register areas:
          first for the base address of rpc-if registers,
          second for the direct mapping read mode and
          third for an optional write buffer area.
 - reg-names: should contain "regs", "dirmap" and "wbuf"(optional).

is it OK ?

thanks & best regards,
Mason

CONFIDENTIALITY NOTE:

This e-mail and any attachments may contain confidential information 
and/or personal data, which is protected by applicable laws. Please be 
reminded that duplication, disclosure, distribution, or use of this e-mail 
(and/or its attachments) or any part thereof is prohibited. If you receive 
this e-mail in error, please notify us immediately and delete this mail as 
well as its attachment(s) from your system. In addition, please be 
informed that collection, processing, and/or use of personal data is 
prohibited unless expressly permitted by personal data protection laws. 
Thank you for your attention and cooperation.

Macronix International Co., Ltd.

=====================================================================

============================================================================

CONFIDENTIALITY NOTE:

This e-mail and any attachments may contain confidential information and/or personal data, which is protected by applicable laws. Please be reminded that duplication, disclosure, distribution, or use of this e-mail (and/or its attachments) or any part thereof is prohibited. If you receive this e-mail in error, please notify us immediately and delete this mail as well as its attachment(s) from your system. In addition, please be informed that collection, processing, and/or use of personal data is prohibited unless expressly permitted by personal data protection laws. Thank you for your attention and cooperation.

Macronix International Co., Ltd.

=====================================================================

[-- Attachment #2: Type: text/html, Size: 4528 bytes --]