From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Bernard Metzler" Subject: RE: [PATCH v2 06/13] SoftiWarp connection management Date: Sat, 14 Oct 2017 00:56:45 +0000 Message-ID: References: ,<20171006122853.16310-1-bmt@zurich.ibm.com> <20171006122853.16310-7-bmt@zurich.ibm.com> <1507303945.2602.9.camel@wdc.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Return-path: In-Reply-To: Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Parav Pandit Cc: Bart Van Assche , "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: linux-rdma@vger.kernel.org -----Parav Pandit wrote: ----- >To: Bart Van Assche , "bmt-OA+xvbQnYDHMbYB6QlFGEg@public.gmane.org" >, "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" > >From: Parav Pandit >Date: 10/06/2017 06:05PM >Subject: RE: [PATCH v2 06/13] SoftiWarp connection management > >> -----Original Message----- > >> From: Bart Van Assche [mailto:Bart.VanAssche-Sjgp3cTcYWE@public.gmane.org] > >> Sent: Friday, October 06, 2017 10:32 AM > >> To: bmt-OA+xvbQnYDHMbYB6QlFGEg@public.gmane.org; Parav Pandit ; linux- > >> rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > >> Subject: Re: [PATCH v2 06/13] SoftiWarp connection management > >> > >> On Fri, 2017-10-06 at 14:59 +0000, Parav Pandit wrote: > >> > > + BUG_ON(!cep); > >> > > >> > Do you need BUG_ON or can be converted to WARN__ and return? > >> > >> Hello Bernard and Parav, > >> > >> Using BUG_ON() in new code is considered unacceptable. See e.g. >Linus > >> Torvalds, > > > >Yes. However checkpatch.pl shows that as warning instead of error. > >It may be worth to change to report that as an error to reflect what >Linus mentioned in [1]. > >That allows to catch it even before patch gets posted. > > > >[1] >https://urldefense.proofpoint.com/v2/url?u=https-3A__lkml.org_lkml_20 >16_10_4_1&d=DwIGaQ&c=jf_iaSHvJObTbx-siA1ZOg&r=2TaYXQ0T-r8ZO1PP1alNwU_ >QJcRRLfmYTAgd3QCvqSc&m=tbMVPXruAkltYA5JPtSz_QBfl52SZgEMaghx4r6U_Sc&s= >ayQywk_3kHdY_lD0Nr7WPolhVaE9qQKXQ08ilhemILI&e= > > > While I found it useful, I am going to remove all BUG() and friends statements. Thanks, Bernard. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html