From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wolfgang Wallner <wolfgang.wallner@br-automation.com>
Date: Fri, 28 Feb 2020 14:59:57 +0100
Subject: Antwort: Re: [RFC PATCH] serial: ns16550: Move PCI access from
 ofdata_to_platdata() to probe()
In-Reply-To: <CAEUhbmVaHn3jHHe5vBLdEf2aSd_tyCX0ZvL-SvWsKtXxPw5nVg@mail.gmail.com>
References: <CAEUhbmVaHn3jHHe5vBLdEf2aSd_tyCX0ZvL-SvWsKtXxPw5nVg@mail.gmail.com>,
 <20200218123424.85618-1-wolfgang.wallner@br-automation.com>
 <CAEUhbmXxTPbp=L+o20zBUGtkXstECeCTmyAhoTYjEpst6Y+Q0g@mail.gmail.com>
 <CAEUhbmWYt_E+KChBvmD9tbpwzCn++gtEaZ5ijOHeipf=yaA5HQ@mail.gmail.com>
Message-ID: <OFE6B5C74C.154029F3-ONC125851C.004CAAD3-C125851C.004CE67B@br-automation.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Bin,

-----"Bin Meng" <bmeng.cn@gmail.com> schrieb: -----
> Hi Wolfgang,
> 
> [snip]
> 
> Unfortunately this patch breaks several ARM board:
> 
> +drivers/built-in.o: In function `ofnode_get_parent':
> +drivers/core/ofnode.c:235: undefined reference to `fdt_parent_offset'
> +drivers/built-in.o: In function `ofnode_read_simple_addr_cells':
> +drivers/core/ofnode.c:717: undefined reference to `fdt_address_cells'
> +drivers/built-in.o: In function `ofnode_read_simple_size_cells':
> +drivers/core/ofnode.c:725: undefined reference to `fdt_size_cells'
> +drivers/built-in.o: In function `ofnode_get_addr_size_index':
> +drivers/core/ofnode.c:294: undefined reference to `fdtdec_get_addr_size_fixed'
> 
> See https://dev.azure.com/bmeng/GitHub/_build/results?buildId=158&view=logs&j=25fc9316-c681-5af2-a03f-b888fd665e84&t=3af932b6-18ad-575e-b0ea-0b31bb7c6c26

Thanks for pointing this out.

I have missed that the code was guarded with
 #if CONFIG_IS_ENABLED(OF_CONTROL) && !CONFIG_IS_ENABLED(OF_PLATDATA)
before, and is not guarded anymore now.

> Would you please send a v2 to address this? thanks!

Yes, I will follow up with a v2.

regards, Wolfgang