From: Biju Das <biju.das.jz@bp.renesas.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>,
Magnus Damm <magnus.damm@gmail.com>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Chris Paterson <Chris.Paterson2@renesas.com>,
Biju Das <biju.das@bp.renesas.com>,
Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>
Subject: RE: [PATCH 1/2] arm64: dts: renesas: r9a07g044: Fix external clk node names
Date: Sun, 24 Apr 2022 10:22:09 +0000 [thread overview]
Message-ID: <OS0PR01MB5922619EE8816DA1676BAB4D86F99@OS0PR01MB5922.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <7bd2ae6d-c55f-4ab7-0c98-72da0d5d4050@linaro.org>
Hi Krzysztof Kozlowski,
Thanks for the feedback.
> Subject: Re: [PATCH 1/2] arm64: dts: renesas: r9a07g044: Fix external clk
> node names
>
> On 24/04/2022 09:50, Biju Das wrote:
> >> Subject: RE: [PATCH 1/2] arm64: dts: renesas: r9a07g044: Fix external
> >> clk node names
> >>
> >> Hi Krzysztof Kozlowski,
> >>
> >> Thanks for the feedback.
> >>
> >>> Subject: Re: [PATCH 1/2] arm64: dts: renesas: r9a07g044: Fix
> >>> external clk node names
> >>>
> >>> On 23/04/2022 16:06, Biju Das wrote:
> >>>> Fix audio clk node names with "_" -> "-" and add suffix '-clk' for
> >>>> can and extal clks.
> >>>>
> >>>> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> >>>> ---
> >>>> arch/arm64/boot/dts/renesas/r9a07g044.dtsi | 8 ++++----
> >>>> 1 file changed, 4 insertions(+), 4 deletions(-)
> >>>>
> >>>> diff --git a/arch/arm64/boot/dts/renesas/r9a07g044.dtsi
> >>>> b/arch/arm64/boot/dts/renesas/r9a07g044.dtsi
> >>>> index 19287cccb1f0..4f9a84d7af08 100644
> >>>> --- a/arch/arm64/boot/dts/renesas/r9a07g044.dtsi
> >>>> +++ b/arch/arm64/boot/dts/renesas/r9a07g044.dtsi
> >>>> @@ -13,14 +13,14 @@ / {
> >>>> #address-cells = <2>;
> >>>> #size-cells = <2>;
> >>>>
> >>>> - audio_clk1: audio_clk1 {
> >>>> + audio_clk1: audio-clk1 {
> >>>
> >>> How about in such case keeping suffix "clk" everywhere and moving
> >>> the index
> >>> (1/2) to the first part? This way one day maybe schema will match
> >>> the clocks.
> >>
> >> Just a question,
> >>
> >> Your suggestion is "audio_clk1: audio-clk1" -> "audio_clk1: audio-clk"
> >>
> >> In that case, If you plan to drop the label in future, how will you
> >> differentiate between
> >> audio-clk1 and audio-clk2 with just node names?
> >
> > Or
> >
> > Do you want me to do the change like this?
> >
> > "audio_clk1: audio-clk1" -> "audio_clk_1: audio-clk-1"
> >
> > And fix the phandle reference in other dtsi files??
>
> My suggestion was to move the [12] part into the first part, so the suffix
> "clk" stays consistent:
> audio1-clk
> audio2-clk
From HW perspective, there are 2 audio clocks, audio clock1(multiple and sub multiple of 44.1 Khz)
and audio clk 2(Multiple and submultiple of 48Khz) connected to a single audio Codec.
Based on the sampling rate, through clock generator driver we can switch the clock source for
audio mclock along with audio clock for SSI and we can support both these rates
Since there is a single audio codec, I am not sure, audio1-clk and audio2-clk is a good choise.
What about like
audio_clk1: audio-clk-1 ?
audio_clk2: audio-clk-2 ?
Which is consistent with naming used for cpu and opp-tables?
Cheers,
Biju
next prev parent reply other threads:[~2022-04-24 10:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-23 14:06 [PATCH 1/2] arm64: dts: renesas: r9a07g044: Fix external clk node names Biju Das
2022-04-23 14:06 ` [PATCH 2/2] arm64: dts: renesas: r9a07g054: " Biju Das
2022-04-23 19:34 ` [PATCH 1/2] arm64: dts: renesas: r9a07g044: " Krzysztof Kozlowski
2022-04-24 6:45 ` Biju Das
2022-04-24 7:50 ` Biju Das
2022-04-24 10:04 ` Krzysztof Kozlowski
2022-04-24 10:22 ` Biju Das [this message]
2022-04-24 14:39 ` Krzysztof Kozlowski
2022-04-25 15:28 ` Biju Das
2022-04-25 15:50 ` Krzysztof Kozlowski
2022-04-25 16:26 ` Biju Das
2022-04-25 16:30 ` Krzysztof Kozlowski
2022-04-25 16:52 ` Biju Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=OS0PR01MB5922619EE8816DA1676BAB4D86F99@OS0PR01MB5922.jpnprd01.prod.outlook.com \
--to=biju.das.jz@bp.renesas.com \
--cc=Chris.Paterson2@renesas.com \
--cc=biju.das@bp.renesas.com \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.