From: Biju Das <biju.das.jz@bp.renesas.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Wolfgang Grandegger <wg@grandegger.com>,
Marc Kleine-Budde <mkl@pengutronix.de>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: "linux-can@vger.kernel.org" <linux-can@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Chris Paterson <Chris.Paterson2@renesas.com>,
Biju Das <biju.das@bp.renesas.com>,
Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>
Subject: RE: [PATCH v3 1/3] dt-bindings: can: nxp,sja1000: Document RZ/N1 power-domains support
Date: Tue, 30 Aug 2022 17:47:41 +0000 [thread overview]
Message-ID: <OS0PR01MB592292E8BE619470F4C621A186799@OS0PR01MB5922.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <23539312-caaa-78f0-cd6c-899a826f9947@linaro.org>
Hi Krzysztof Kozlowski,
Thanks for the feedback.
> Subject: Re: [PATCH v3 1/3] dt-bindings: can: nxp,sja1000: Document
> RZ/N1 power-domains support
>
> On 30/08/2022 19:45, Biju Das wrote:
> > Document RZ/N1 power-domains support. Also update the example with
> > power-domains property.
> >
> > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> > ---
> > v3:
> > * Documented power-domains support.
>
> You made them required, so it would be nice to see reason in such
> change. The commit msg says only what you did, but not why you did it.
It is simple. As you see from [1] and [2] power-domains are enabled by default in RZ/N1 SoC.
So there is nothing prevent us to document this property for all IP's present in
RZ/N1 SoC.
[1]https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/clk/renesas/r9a06g032-clocks.c?h=v6.0-rc3&id=aad03a66f902e18bab612870261bde647fdbda2c
[2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/soc/renesas?h=v6.0-rc3&id=14f11da778ff642142e9be18814815754c82d6c5
Cheers,
Biju
next prev parent reply other threads:[~2022-08-30 17:51 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-30 16:45 [PATCH v3 0/3] Add RZ/N1 CAN support Biju Das
2022-08-30 16:45 ` [PATCH v3 1/3] dt-bindings: can: nxp,sja1000: Document RZ/N1 power-domains support Biju Das
2022-08-30 17:31 ` Krzysztof Kozlowski
2022-08-30 17:47 ` Biju Das [this message]
2022-08-30 19:03 ` Krzysztof Kozlowski
2022-09-01 10:25 ` Geert Uytterhoeven
2022-09-01 10:22 ` Geert Uytterhoeven
2022-08-30 16:45 ` [PATCH v3 2/3] ARM: dts: r9a06g032: Add CAN{0,1} nodes Biju Das
2022-09-01 12:22 ` Geert Uytterhoeven
2022-08-30 16:45 ` [PATCH v3 3/3] ARM: dts: r9a06g032-rzn1d400-db: Enable CAN{0,1} Biju Das
2022-09-01 12:45 ` Geert Uytterhoeven
2022-09-01 13:15 ` Biju Das
2022-09-01 13:57 ` Biju Das
2022-09-01 17:06 ` Geert Uytterhoeven
2022-09-05 16:07 ` [PATCH v3 0/3] Add RZ/N1 CAN support Marc Kleine-Budde
2022-09-05 16:13 ` Biju Das
2022-09-05 20:01 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=OS0PR01MB592292E8BE619470F4C621A186799@OS0PR01MB5922.jpnprd01.prod.outlook.com \
--to=biju.das.jz@bp.renesas.com \
--cc=Chris.Paterson2@renesas.com \
--cc=biju.das@bp.renesas.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=geert+renesas@glider.be \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=robh+dt@kernel.org \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.