All of lore.kernel.org
 help / color / mirror / Atom feed
From: Min Li <min.li.xe@renesas.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: "sameo@linux.intel.com" <sameo@linux.intel.com>,
	"grant.likely@linaro.org" <grant.likely@linaro.org>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: RE: [PATCH mfd v1] mfd: Add Renesas Synchronization Management Unit (SMU) support
Date: Fri, 21 May 2021 14:36:23 +0000	[thread overview]
Message-ID: <OS3PR01MB6593794BFE3A4A08C62E708BBA299@OS3PR01MB6593.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <20210519080807.GH805368@dell>

> >
> > +config MFD_RSMU_I2C
> > +	tristate "Renesas Synchronization Management Unit with I2C"
> > +	depends on I2C && OF
> > +	depends on MFD_RSMU_SPI=n
> 
> Not sure I've seen a relationship like this before.
> 
> Devices capable of SPI and I2C usually have a core driver which selects one
> or the other.  It will also save some code duplication you have here.  Please
> take a look at some other examples in the MFD subsystem.


Hi Lee

Thanks for taking your time to review my code. I will start working on the core driver. But
Kconfig items will stay as MFD_RSMU_I2C and MFD_RSMU_SPI like the existing ones 

MFD_MADERA_SPI
MFD_MADERA_I2C

MFD_DA9052_SPI
MFD_DA9052_I2C

MFD_MC13XXX_SPI
MFD_MC13XXX_I2C

Min

  reply	other threads:[~2021-05-21 14:36 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-26 19:44 [PATCH mfd v1] mfd: Add Renesas Synchronization Management Unit (SMU) support min.li.xe
2021-05-05 14:11 ` Min Li
2021-05-05 15:10   ` Lee Jones
2021-05-19  8:08 ` Lee Jones
2021-05-21 14:36   ` Min Li [this message]
2021-05-21 15:02     ` Lee Jones
2021-05-21 20:04       ` Min Li
2021-05-25 15:20   ` Min Li
2021-05-25 18:23     ` Lee Jones
2021-05-25 19:35       ` Min Li
2021-05-26  8:01         ` Lee Jones
2021-05-26 18:26   ` Min Li
2021-05-27  8:43     ` Lee Jones
2021-06-03 19:31   ` Min Li
  -- strict thread matches above, loose matches on Subject: below --
2021-03-20 15:43 min.li.xe
2021-03-22 15:03 ` Lee Jones
2021-03-22 15:22   ` Min Li
2021-03-23  8:44     ` Lee Jones
2021-03-23 15:01       ` Min Li
2021-03-17 21:53 min.li.xe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=OS3PR01MB6593794BFE3A4A08C62E708BBA299@OS3PR01MB6593.jpnprd01.prod.outlook.com \
    --to=min.li.xe@renesas.com \
    --cc=devicetree@vger.kernel.org \
    --cc=grant.likely@linaro.org \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=sameo@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.