All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
To: "Niklas Söderlund" <niklas.soderlund@ragnatech.se>
Cc: "wim@linux-watchdog.org" <wim@linux-watchdog.org>,
	"linux@roeck-us.net" <linux@roeck-us.net>,
	"linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>,
	"linux-renesas-soc@vger.kernel.org" 
	<linux-renesas-soc@vger.kernel.org>
Subject: RE: [PATCH v2] watchdog: renesas_wdt: Add a few cycles delay
Date: Wed, 5 Jun 2019 05:01:28 +0000	[thread overview]
Message-ID: <OSAPR01MB3089BB7B26D398AF87291C5FD8160@OSAPR01MB3089.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <20190603162326.GB2960@bigcity.dyn.berto.se>

Hi Niklas-san,

> From: Niklas Söderlund, Sent: Tuesday, June 4, 2019 1:23 AM
> 
> Hi Shimoda-san,
> 
> Thanks for your work.
> 
> On 2019-06-03 19:36:01 +0900, Yoshihiro Shimoda wrote:
> > According to the hardware manual of R-Car Gen2 and Gen3,
> > software should wait a few RLCK cycles as following:
> >  - Delay 2 cycles before setting watchdog counter.
> >  - Delay 3 cycles before disabling module clock.
> >
> > So, this patch adds such delays.
> >
> > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> 
> Small nit bellow, with or without that addressed.
> 
> Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>

Thank you for your review!

<snip>
> > +static void rwdt_wait(struct rwdt_priv *priv, unsigned int cycles)
> > +{
> > +	unsigned long delays;
> 
> Could this be unsigned int? It would still fit for a cycles number
> around 2000 and this change use 2 and 3 cycles.

I think so. I'll fix it on v3.

Best regards,
Yoshihiro Shimoda


      reply	other threads:[~2019-06-05  5:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-03 10:36 [PATCH v2] watchdog: renesas_wdt: Add a few cycles delay Yoshihiro Shimoda
2019-06-03 13:04 ` Wolfram Sang
2019-06-05  4:58   ` Yoshihiro Shimoda
2019-06-03 16:23 ` Niklas Söderlund
2019-06-05  5:01   ` Yoshihiro Shimoda [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=OSAPR01MB3089BB7B26D398AF87291C5FD8160@OSAPR01MB3089.jpnprd01.prod.outlook.com \
    --to=yoshihiro.shimoda.uh@renesas.com \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=niklas.soderlund@ragnatech.se \
    --cc=wim@linux-watchdog.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.