From mboxrd@z Thu Jan 1 00:00:00 1970 From: Fabrizio Castro Subject: RE: [RFC] drm/bridge/sii902x: Fix EDID readback Date: Fri, 2 Nov 2018 12:05:05 +0000 Message-ID: References: <1540990667-14109-1-git-send-email-fabrizio.castro@bp.renesas.com> <20181101112117.GA6425@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20181101112117.GA6425@sirena.org.uk> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Mark Brown Cc: Geert Uytterhoeven , Wolfram Sang , Dave Airlie , Boris BREZILLON , Chris Paterson , "open list:DRM PANEL DRIVERS" , Biju Das , Linux-Renesas , Simon Horman , Laurent Pinchart , Peter Rosin , "linux-i2c@vger.kernel.org" List-Id: linux-i2c@vger.kernel.org SGVsbG8gTWFyaywKClRoYW5rIHlvdSBmb3IgeW91ciBmZWVkYmFjayEKCj4gU3ViamVjdDogUmU6 IFtSRkNdIGRybS9icmlkZ2Uvc2lpOTAyeDogRml4IEVESUQgcmVhZGJhY2sKPgo+IE9uIFdlZCwg T2N0IDMxLCAyMDE4IGF0IDA0OjU1OjUzUE0gKzAwMDAsIEZhYnJpemlvIENhc3RybyB3cm90ZToK Pgo+ID4gSGF2aW5nIHRoZSBvcHRpb24gb2YgdXNpbmcgInVubG9ja2VkIiBmbGF2b3VycyBvZiBy ZWFkcyBhbmQgd3JpdGVzCj4gPiBpcyB3aGF0IHdlIG5lZWQgaGVyZSwgYnV0IGxvb2tpbmcgYXQg ZHJpdmVycy9iYXNlL3JlZ21hcC9yZWdtYXAtaTJjLmMKPiA+IEkgY291bGRuJ3QgZmluZCBhbnl0 aGluZyBzdWl0YWJsZSBmb3IgbXkgY2FzZSwgbWF5YmUgTWFyayBjb3VsZCBhZHZpc2UKPiA+IG9u IHRoaXMgb25lPyBJIGFtIHN1cmUgSSBvdmVybG9va2VkIHNvbWV0aGluZyBoZXJlLCBpcyB0aGVy ZSBhIGJldHRlcgo+ID4gd2F5IHRvIGFkZHJlc3MgdGhpcz8KPgo+IEFzIExpbnVzIHNhaWQgeW91 IGNhbiBnbyBhcyBmYXIgYXMgd3JpdGluZyB5b3VyIG93biByZWFkIGFuZCB3cml0ZQo+IGZ1bmN0 aW9ucyBpZiB5b3Ugd2FudCB0by4gIFRoYXQgc2VlbXMgdG8gYmUgdGhlIGVhc2llc3QgdGhpbmcs IHRob3VnaCBJCj4gYW0gc3VzcGljb3VzIHRoYXQgeW91J3JlIGhhdmluZyB0byB1c2UgdGhlIEky QyBmcmFtZXdvcmsgaW4gdGhpcyB3YXkgLQo+IGl0IGRvZXNuJ3Qgc291bmQgdGVycmlibHkgY2xl dmVyLiAgWW91IGNvdWxkIEkgZ3Vlc3MgYWxzbyBqdXN0IGhhdmUgYQo+IGN1c3RvbSBmdW5jdGlv biBmb3Igd2hhdGV2ZXIgcmVnaXN0ZXIgaXMgZG9pbmcgYWxsIHRoaXMgc3R1ZmYgdGhhdCBqdXN0 Cj4gaWdub3JlcyByZWdtYXAgYW5kIGJvZGdlIHRoaW5ncyB0aGF0IHdheSB3aGlsZSB1c2luZyBy ZWdtYXAgYXMgbm9ybWFsCj4gZm9yIGV2ZXJ5dGhpbmcgZWxzZS4KCkkgYWdyZWUsIEkgaGF2ZSBw cm90b3R5cGVkIGl0IGFuZCBpdCBzZWVtcyB0byBiZSB3b3JraW5nIGp1c3QgZmluZS4KV2lsbCBz ZW5kIGEgcGF0Y2ggYWRkcmVzc2luZyBhbGwgb2YgdGhlIGNvbW1lbnRzLCBpbmNsdWRpbmcgdGhp cyBvbmUuCgpGYWIKCgoKUmVuZXNhcyBFbGVjdHJvbmljcyBFdXJvcGUgTHRkLCBEdWtlcyBNZWFk b3csIE1pbGxib2FyZCBSb2FkLCBCb3VybmUgRW5kLCBCdWNraW5naGFtc2hpcmUsIFNMOCA1Rkgs IFVLLiBSZWdpc3RlcmVkIGluIEVuZ2xhbmQgJiBXYWxlcyB1bmRlciBSZWdpc3RlcmVkIE5vLiAw NDU4NjcwOS4KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K ZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0 dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ty1jpn01on0107.outbound.protection.outlook.com ([104.47.93.107]:23800 "EHLO JPN01-TY1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725935AbeKBVML (ORCPT ); Fri, 2 Nov 2018 17:12:11 -0400 From: Fabrizio Castro To: Mark Brown CC: Linus Walleij , Archit Taneja , Andrzej Hajda , Dave Airlie , Peter Rosin , Wolfram Sang , Laurent Pinchart , "open list:DRM PANEL DRIVERS" , Simon Horman , Geert Uytterhoeven , Chris Paterson , Biju Das , Linux-Renesas , "linux-i2c@vger.kernel.org" , Inki Dae , Boris BREZILLON Subject: RE: [RFC] drm/bridge/sii902x: Fix EDID readback Date: Fri, 2 Nov 2018 12:05:05 +0000 Message-ID: References: <1540990667-14109-1-git-send-email-fabrizio.castro@bp.renesas.com> <20181101112117.GA6425@sirena.org.uk> In-Reply-To: <20181101112117.GA6425@sirena.org.uk> Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: Hello Mark, Thank you for your feedback! > Subject: Re: [RFC] drm/bridge/sii902x: Fix EDID readback > > On Wed, Oct 31, 2018 at 04:55:53PM +0000, Fabrizio Castro wrote: > > > Having the option of using "unlocked" flavours of reads and writes > > is what we need here, but looking at drivers/base/regmap/regmap-i2c.c > > I couldn't find anything suitable for my case, maybe Mark could advise > > on this one? I am sure I overlooked something here, is there a better > > way to address this? > > As Linus said you can go as far as writing your own read and write > functions if you want to. That seems to be the easiest thing, though I > am suspicous that you're having to use the I2C framework in this way - > it doesn't sound terribly clever. You could I guess also just have a > custom function for whatever register is doing all this stuff that just > ignores regmap and bodge things that way while using regmap as normal > for everything else. I agree, I have prototyped it and it seems to be working just fine. Will send a patch addressing all of the comments, including this one. Fab Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, B= uckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered= No. 04586709.