* [PATCH] makedumpfile: Fix a compile error on Debian with pthread
@ 2021-01-30 18:49 Jiang Wang
2021-02-01 1:42 ` HAGIO KAZUHITO(萩尾 一仁)
0 siblings, 1 reply; 3+ messages in thread
From: Jiang Wang @ 2021-01-30 18:49 UTC (permalink / raw)
To: kexec; +Cc: k-hagio-ab, jiang.wang
From: "jiang.wang" <jiang.wang@bytedance.com>
On Debian 10, make reports errors about undefined reference to
`pthread_rwlock_tryrdlock'. To fix it, put ldw before lpthread
in the Makefile.
Signed-off-by: Jiang Wang <jiang.wang@bytedance.com>
---
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index cb6bd42..010d447 100644
--- a/Makefile
+++ b/Makefile
@@ -68,7 +68,7 @@ endif
CFLAGS += -DUSESNAPPY
endif
-LIBS := -lpthread $(LIBS)
+LIBS := $(LIBS) -lpthread
try-run = $(shell set -e; \
TMP=".$$$$.tmp"; \
--
2.11.0
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH] makedumpfile: Fix a compile error on Debian with pthread
2021-01-30 18:49 [PATCH] makedumpfile: Fix a compile error on Debian with pthread Jiang Wang
@ 2021-02-01 1:42 ` HAGIO KAZUHITO(萩尾 一仁)
2021-02-01 17:00 ` [External] " Jiang Wang .
0 siblings, 1 reply; 3+ messages in thread
From: HAGIO KAZUHITO(萩尾 一仁) @ 2021-02-01 1:42 UTC (permalink / raw)
To: Jiang Wang, kexec
-----Original Message-----
> From: "jiang.wang" <jiang.wang@bytedance.com>
>
> On Debian 10, make reports errors about undefined reference to
> `pthread_rwlock_tryrdlock'. To fix it, put ldw before lpthread
> in the Makefile.
>
> Signed-off-by: Jiang Wang <jiang.wang@bytedance.com>
> ---
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index cb6bd42..010d447 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -68,7 +68,7 @@ endif
> CFLAGS += -DUSESNAPPY
> endif
>
> -LIBS := -lpthread $(LIBS)
> +LIBS := $(LIBS) -lpthread
>
> try-run = $(shell set -e; \
> TMP=".$$$$.tmp"; \
> --
> 2.11.0
Thanks for the patch, applied.
https://github.com/makedumpfile/makedumpfile/commit/01b4bd354c4a845c160d14487a93270cd1e22031
Kazu
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [External] RE: [PATCH] makedumpfile: Fix a compile error on Debian with pthread
2021-02-01 1:42 ` HAGIO KAZUHITO(萩尾 一仁)
@ 2021-02-01 17:00 ` Jiang Wang .
0 siblings, 0 replies; 3+ messages in thread
From: Jiang Wang . @ 2021-02-01 17:00 UTC (permalink / raw)
To: HAGIO KAZUHITO(萩尾 一仁); +Cc: kexec
Awesome, thanks!
On Sun, Jan 31, 2021 at 5:42 PM HAGIO KAZUHITO(萩尾 一仁)
<k-hagio-ab@nec.com> wrote:
>
> -----Original Message-----
> > From: "jiang.wang" <jiang.wang@bytedance.com>
> >
> > On Debian 10, make reports errors about undefined reference to
> > `pthread_rwlock_tryrdlock'. To fix it, put ldw before lpthread
> > in the Makefile.
> >
> > Signed-off-by: Jiang Wang <jiang.wang@bytedance.com>
> > ---
> > Makefile | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Makefile b/Makefile
> > index cb6bd42..010d447 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -68,7 +68,7 @@ endif
> > CFLAGS += -DUSESNAPPY
> > endif
> >
> > -LIBS := -lpthread $(LIBS)
> > +LIBS := $(LIBS) -lpthread
> >
> > try-run = $(shell set -e; \
> > TMP=".$$$$.tmp"; \
> > --
> > 2.11.0
>
> Thanks for the patch, applied.
> https://github.com/makedumpfile/makedumpfile/commit/01b4bd354c4a845c160d14487a93270cd1e22031
>
> Kazu
>
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-02-01 17:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-30 18:49 [PATCH] makedumpfile: Fix a compile error on Debian with pthread Jiang Wang
2021-02-01 1:42 ` HAGIO KAZUHITO(萩尾 一仁)
2021-02-01 17:00 ` [External] " Jiang Wang .
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.