All of lore.kernel.org
 help / color / mirror / Atom feed
From: "HAGIO KAZUHITO(萩尾　一仁)" <k-hagio-ab@nec.com>
To: Julien Thierry <jthierry@redhat.com>,
	"lijiang@redhat.com" <lijiang@redhat.com>
Cc: "kexec@lists.infradead.org" <kexec@lists.infradead.org>
Subject: RE: [MAKEDUMPFILE PATCH 1/2] Add option to prevent writing the dumpfile
Date: Thu, 28 Jan 2021 09:00:41 +0000	[thread overview]
Message-ID: <OSBPR01MB199177A99EAA6F3A91CE49DADDBA9@OSBPR01MB1991.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <OSAPR01MB1986854BD0AEB2927A084DDCDDA40@OSAPR01MB1986.jpnprd01.prod.outlook.com>

-----Original Message-----
> Hi Julien,
> 
> Thanks for the patches, and sorry for the late reply..
> 
> -----Original Message-----
> > Add a --dry-run option to run all operations without writing the
> > dump to the output file.
> 
> First, I think makedumpfile should not change its behavior (path checks,
> messages emitted, etc.) and exit code except for writing the dumpfile
> with or without the --dry-run option.  For example with this patch:
> 
>   $ touch dumpfile
>   $ makedumpfile -d 1 vmcore dumpfile --dry-run  --> ok, no problem
>   $ makedumpfile -d 1 vmcore dumpfile            --> error
> 
> This change is a bit strange to me.  So with this premise, commented inline
> and attached a modified patch at end of this email.  Could you check those?

This patchset is applied with some modifications:
https://github.com/makedumpfile/makedumpfile/compare/54aec38...6f3e75a

I will add another for counting bytes to be written and more readable stats later..

Thanks,
Kazu


_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

  reply	other threads:[~2021-01-28  9:00 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-24 10:45 [MAKDUMPFILE PATCH 0/2] Get stats without writing dumpfile Julien Thierry
2020-11-24 10:45 ` [MAKEDUMPFILE PATCH 1/2] Add option to prevent writing the dumpfile Julien Thierry
2021-01-18  6:43   ` HAGIO KAZUHITO(萩尾　一仁)
2021-01-28  9:00     ` HAGIO KAZUHITO(萩尾　一仁) [this message]
2021-02-04  8:21       ` HAGIO KAZUHITO(萩尾　一仁)
2020-11-24 10:45 ` [MAKEDUMPFILE PATCH 2/2] Add shorthand option to show report stats Julien Thierry
2021-01-18  7:19   ` HAGIO KAZUHITO(萩尾　一仁)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=OSBPR01MB199177A99EAA6F3A91CE49DADDBA9@OSBPR01MB1991.jpnprd01.prod.outlook.com \
    --to=k-hagio-ab@nec.com \
    --cc=jthierry@redhat.com \
    --cc=kexec@lists.infradead.org \
    --cc=lijiang@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.