From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Date: Mon, 27 Jul 2020 11:54:04 +0000 Message-ID: References: In-Reply-To: Content-Language: en-US Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [Fuego] Dockerfile vs install-debian.sh List-Id: Mailing list for the Fuego test framework List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: gpi@mailbox.org, fuego@lists.linuxfoundation.org, Tim.Bird@sony.com -----Original Message----- > From: sangorrin daniel(=1B$B%5%s%4%j%s=1B(B =1B$B%@%K%(%k=1B(B =1B$B""#S#= W#C"~#A#C#T=1B(B) > Hi Georg > Tim: I have a question of your at the end. of your -> for you ^^U >=20 > > -----Original Message----- > > From: Fuego On Behalf Of > > Georg Piewald > > Sent: Monday, July 27, 2020 8:14 PM > > To: fuego@lists.linuxfoundation.org > > Subject: [Fuego] Dockerfile vs install-debian.sh > > > > Hi guys, > > > > I was just looking into how to install Fuego without a Docker > > container (since the CHANGELOG says it's possible). Apparently, that's = what install-debian.sh is good for (or is there something else, that I > missed?). >=20 > Yes, I created it in 2019 and it worked at that time. I run it together w= ith LAVA. > Unfortunately, I haven't been able to maintain it since then for private = reasons. Now I am back but I can't spend as much time as I'd like. > https://bkk19.sched.com/event/Li6u/bkk19-tr08-how-to-integrate-fuego-auto= mated-testing-tool-in-your-ci-loop > You have the slides there (and the presentation is on youtube) >=20 > > But honestly, this script seems like a halfhearted attempt to me and > > strongly violates the DRY principle. It is clearly descendant from > > Dockerfile, but did not evolve with it. Several later modifications in = Dockerfile did not make it to install-debian.sh. How do you plan to > keep these files in sync? >=20 > You are right. This was just a fast prototype to prove a point (that Fueg= o can work with LAVA, Ktest, Linaro test definitions, and other test > frameworks) on that conference. > It is waiting for proper integration and maintenance. >=20 > > I propose to only let install-debian.sh have all the code that sets up > > the OS and installs all requirements. The Dockerfile instead should do > > (almost) nothing but execute install-debian.sh. >=20 > Yes, that was my plan as well. >=20 > > An additional benefit of that method is that it will be much easier to = also keep Dockerfile.nojenkins in sync with the standard Dockerfile. > > Because here we have the same problem of lots of copied code, that is > > slowly drifting apart. We might even not need Dockerfile.nojenkins anym= ore at all. >=20 > Exactly. >=20 > > I can offer to implement this, unless there are strong objections by an= yone. >=20 > That would super awesome. It would be good if you see my video on Youtube= or at least read the slides to get a bit of background of what I > wanted to do with it. > Also if you have any question about why i did that, or if there is a miss= ing piece of code please let me know. >=20 > Tim: do you agree? >=20 > Best regards, > Daniel