From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Biju Das Subject: RE: [PATCH v2 2/7] dt-bindings: usb: renesas_usb3: add usb-role-switch property Date: Thu, 14 Mar 2019 10:14:12 +0000 Message-ID: References: <1552552775-51667-1-git-send-email-biju.das@bp.renesas.com> <1552552775-51667-3-git-send-email-biju.das@bp.renesas.com> In-Reply-To: Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 To: Yoshihiro Shimoda , Rob Herring , Mark Rutland Cc: Greg Kroah-Hartman , Heikki Krogerus , Felipe Balbi , "linux-usb@vger.kernel.org" , "devicetree@vger.kernel.org" , Simon Horman , Geert Uytterhoeven , Chris Paterson , Fabrizio Castro , "linux-renesas-soc@vger.kernel.org" List-ID: Hi Shimoda-San, Thanks for the feedback. > Subject: RE: [PATCH v2 2/7] dt-bindings: usb: renesas_usb3: add usb-role- > switch property >=20 > Hi Biju-san, >=20 > > From: Biju Das, Sent: Thursday, March 14, 2019 5:40 PM > > > > Add support for renesas_usb3 to support dual role switch using usb > > role switch class framework. > > > > Signed-off-by: Biju Das > > --- > > V1-->V2 > > * Added usb-role-switch-property > > * Updated the example with usb-role-switch property. > > --- > > .../devicetree/bindings/usb/renesas_usb3.txt | 22 > ++++++++++++++++++++++ > > 1 file changed, 22 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/usb/renesas_usb3.txt > > b/Documentation/devicetree/bindings/usb/renesas_usb3.txt > > index 35039e7..eecaf4c 100644 > > --- a/Documentation/devicetree/bindings/usb/renesas_usb3.txt > > +++ b/Documentation/devicetree/bindings/usb/renesas_usb3.txt > > @@ -22,6 +22,7 @@ Required properties: > > Optional properties: > > - phys: phandle + phy specifier pair > > - phy-names: must be "usb" > > + - usb-role-switch: use USB role switch to support dual-role switch >=20 > I don't think we can add such a property. At least, we have to add "renes= as," > prefix. usb_role_switch_get api uses "usb-role-switch" property to get role swi= tch linked with the device. HD3SS3220 port controller driver gets role switch handle linked with the de= vice using usb_role_switch_get api. =20 That is the reason, I have added " usb-role-switch" property here. Do you have any other suggestion to get usb role switch handle? Please correct me if I am wrong.=20 =20 > > Example of R-Car H3 ES1.x: > > usb3_peri0: usb@ee020000 { > > @@ -39,3 +40,24 @@ Example of R-Car H3 ES1.x: > > interrupts =3D ; > > clocks =3D <&cpg CPG_MOD 327>; > > }; > > + > > +Example of RZ/G2E: > > + usb3_peri0: usb@ee020000 { > > + compatible =3D "renesas,r8a774c0-usb3-peri", > > + "renesas,rcar-gen3-usb3-peri"; > > + reg =3D <0 0xee020000 0 0x400>; > > + interrupts =3D ; > > + clocks =3D <&cpg CPG_MOD 328>; > > + companion =3D <&xhci0>; > > + usb-role-switch; > > + > > + port { > > + #address-cells =3D <1>; > > + #size-cells =3D <0>; > > + > > + usb3peri_role_switch: endpoint@0 { > > + reg =3D <0>; > > + remote-endpoint =3D <&hd3ss3220_ep>; > > + }; > > + }; > > + }; > > -- > > 2.7.4 Regards, Biju From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E035C10F0B for ; Thu, 14 Mar 2019 10:14:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D10642064A for ; Thu, 14 Mar 2019 10:14:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=renesasgroup.onmicrosoft.com header.i=@renesasgroup.onmicrosoft.com header.b="imCV8zCZ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726776AbfCNKOS (ORCPT ); Thu, 14 Mar 2019 06:14:18 -0400 Received: from mail-eopbgr1400128.outbound.protection.outlook.com ([40.107.140.128]:10240 "EHLO JPN01-TY1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726539AbfCNKOR (ORCPT ); Thu, 14 Mar 2019 06:14:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=renesasgroup.onmicrosoft.com; s=selector1-bp-renesas-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EUC90VyBLFNPbtUhsowXDX80XLlWEVfNQNFk8qmC8I8=; b=imCV8zCZ9sda6vhKVDl64MlzshRK0vYF1yV4zCCCUKtEInCqoiodHNtMtaIjgYnva3s5cSxpVlnyjVHb4w0Qc6vB8ZdU25nOhuIpMwZNWABBIZKK+r8paY3lfg39pwqHovfKT4FBCJMGyLlQXmmWQR91ATHNZgBk9LshKXZmseQ= Received: from OSBPR01MB2103.jpnprd01.prod.outlook.com (52.134.242.17) by OSBPR01MB4632.jpnprd01.prod.outlook.com (20.179.184.80) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1686.21; Thu, 14 Mar 2019 10:14:13 +0000 Received: from OSBPR01MB2103.jpnprd01.prod.outlook.com ([fe80::9c06:60ec:8c9a:2888]) by OSBPR01MB2103.jpnprd01.prod.outlook.com ([fe80::9c06:60ec:8c9a:2888%3]) with mapi id 15.20.1709.011; Thu, 14 Mar 2019 10:14:13 +0000 From: Biju Das To: Yoshihiro Shimoda , Rob Herring , Mark Rutland CC: Greg Kroah-Hartman , Heikki Krogerus , Felipe Balbi , "linux-usb@vger.kernel.org" , "devicetree@vger.kernel.org" , Simon Horman , Geert Uytterhoeven , Chris Paterson , Fabrizio Castro , "linux-renesas-soc@vger.kernel.org" Subject: RE: [PATCH v2 2/7] dt-bindings: usb: renesas_usb3: add usb-role-switch property Thread-Topic: [PATCH v2 2/7] dt-bindings: usb: renesas_usb3: add usb-role-switch property Thread-Index: AQHU2kJR8if/PuLc00mcHJXM7PQH56YK2MEAgAAGcKA= Date: Thu, 14 Mar 2019 10:14:12 +0000 Message-ID: References: <1552552775-51667-1-git-send-email-biju.das@bp.renesas.com> <1552552775-51667-3-git-send-email-biju.das@bp.renesas.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=biju.das@bp.renesas.com; x-originating-ip: [193.141.220.21] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: bf92f894-656c-424d-4479-08d6a865ceb6 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(4618075)(2017052603328)(7153060)(7193020);SRVR:OSBPR01MB4632; x-ms-traffictypediagnostic: OSBPR01MB4632: x-microsoft-exchange-diagnostics: 1;OSBPR01MB4632;20:VsbEjlhIO92NfEaKOpHSfbbdr0mJdYQVTTc/9VIA2VYpRY30bpfcAJ7ghYBAmGPy63jGsGMVc/PrQLgqP2xdGNhjtw7HpNpg72dquEEuQRDN21n1p5X9fNP9XOEGu8siZbdqbM/mbesP/9CgetR1Zxvgu99qBM/qCT9Xlj25M8t5TMRvy7JncdTVb3kQndcaUrjUbt4KSAHWuEAVtr3SpA5U3FUH2M6wkwc4Lb4f4kCmpKTAZk9cmnrb1Ffhu3ph x-microsoft-antispam-prvs: x-forefront-prvs: 09760A0505 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(396003)(366004)(136003)(39860400002)(346002)(376002)(51914003)(189003)(199004)(99286004)(76176011)(7736002)(305945005)(26005)(54906003)(256004)(4326008)(478600001)(74316002)(6436002)(476003)(9686003)(7696005)(52536014)(8936002)(66066001)(55016002)(6246003)(25786009)(53936002)(6116002)(97736004)(68736007)(33656002)(8676002)(3846002)(81166006)(71190400001)(71200400001)(81156014)(186003)(110136005)(86362001)(316002)(44832011)(105586002)(6506007)(102836004)(446003)(7416002)(229853002)(11346002)(486006)(5660300002)(2906002)(106356001)(14454004);DIR:OUT;SFP:1102;SCL:1;SRVR:OSBPR01MB4632;H:OSBPR01MB2103.jpnprd01.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:0; received-spf: None (protection.outlook.com: bp.renesas.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: kBu31+LuPrgUT5lvKL0RZpppfuvsbM4KiL58LBGIkNLwV+AIOUTszlZDdi0k0Psyx42FD0GVnC4ITWfdNE33Wzu3+V/U2Ve3AfHWxlTvWct9hf+uBxjhKe/Cqni33IZIU8fbAqXfebdBZVNta1clPZK4l7FM0VHty7zlsgmgTggGPnj8bmxsPd+tbbgqSnxoJ4lSJHf2aUGh0y4A2pEIgZdXkC1Snjus3IzkH65heBGUk4bsP5xtcjG1SvjCTSCUoEisSaQDniFWUkKhkEM1ItOv3X0E1/646Ecb9Easxz39N1UsHNOZiGZx+hu6uGTcFWc+zYS7ouCaOUmA+vbCY+FF6BD2XtQSfAR56FbPlepSalDj4V3yak9lLTI57W7qKnzqchvH34Jdu7y+oywB1M+aoeOOShpHp2D3mIp1OiU= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: bp.renesas.com X-MS-Exchange-CrossTenant-Network-Message-Id: bf92f894-656c-424d-4479-08d6a865ceb6 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Mar 2019 10:14:12.3222 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: OSBPR01MB4632 Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org Hi Shimoda-San, Thanks for the feedback. > Subject: RE: [PATCH v2 2/7] dt-bindings: usb: renesas_usb3: add usb-role- > switch property >=20 > Hi Biju-san, >=20 > > From: Biju Das, Sent: Thursday, March 14, 2019 5:40 PM > > > > Add support for renesas_usb3 to support dual role switch using usb > > role switch class framework. > > > > Signed-off-by: Biju Das > > --- > > V1-->V2 > > * Added usb-role-switch-property > > * Updated the example with usb-role-switch property. > > --- > > .../devicetree/bindings/usb/renesas_usb3.txt | 22 > ++++++++++++++++++++++ > > 1 file changed, 22 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/usb/renesas_usb3.txt > > b/Documentation/devicetree/bindings/usb/renesas_usb3.txt > > index 35039e7..eecaf4c 100644 > > --- a/Documentation/devicetree/bindings/usb/renesas_usb3.txt > > +++ b/Documentation/devicetree/bindings/usb/renesas_usb3.txt > > @@ -22,6 +22,7 @@ Required properties: > > Optional properties: > > - phys: phandle + phy specifier pair > > - phy-names: must be "usb" > > + - usb-role-switch: use USB role switch to support dual-role switch >=20 > I don't think we can add such a property. At least, we have to add "renes= as," > prefix. usb_role_switch_get api uses "usb-role-switch" property to get role swi= tch linked with the device. HD3SS3220 port controller driver gets role switch handle linked with the de= vice using usb_role_switch_get api. =20 That is the reason, I have added " usb-role-switch" property here. Do you have any other suggestion to get usb role switch handle? Please correct me if I am wrong.=20 =20 > > Example of R-Car H3 ES1.x: > > usb3_peri0: usb@ee020000 { > > @@ -39,3 +40,24 @@ Example of R-Car H3 ES1.x: > > interrupts =3D ; > > clocks =3D <&cpg CPG_MOD 327>; > > }; > > + > > +Example of RZ/G2E: > > + usb3_peri0: usb@ee020000 { > > + compatible =3D "renesas,r8a774c0-usb3-peri", > > + "renesas,rcar-gen3-usb3-peri"; > > + reg =3D <0 0xee020000 0 0x400>; > > + interrupts =3D ; > > + clocks =3D <&cpg CPG_MOD 328>; > > + companion =3D <&xhci0>; > > + usb-role-switch; > > + > > + port { > > + #address-cells =3D <1>; > > + #size-cells =3D <0>; > > + > > + usb3peri_role_switch: endpoint@0 { > > + reg =3D <0>; > > + remote-endpoint =3D <&hd3ss3220_ep>; > > + }; > > + }; > > + }; > > -- > > 2.7.4 Regards, Biju From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v2,2/7] dt-bindings: usb: renesas_usb3: add usb-role-switch property From: Biju Das Message-Id: Date: Thu, 14 Mar 2019 10:14:12 +0000 To: Yoshihiro Shimoda , Rob Herring , Mark Rutland Cc: Greg Kroah-Hartman , Heikki Krogerus , Felipe Balbi , "linux-usb@vger.kernel.org" , "devicetree@vger.kernel.org" , Simon Horman , Geert Uytterhoeven , Chris Paterson , Fabrizio Castro , "linux-renesas-soc@vger.kernel.org" List-ID: SGkgU2hpbW9kYS1TYW4sCgpUaGFua3MgZm9yIHRoZSBmZWVkYmFjay4KCj4gU3ViamVjdDogUkU6 IFtQQVRDSCB2MiAyLzddIGR0LWJpbmRpbmdzOiB1c2I6IHJlbmVzYXNfdXNiMzogYWRkIHVzYi1y b2xlLQo+IHN3aXRjaCBwcm9wZXJ0eQo+IAo+IEhpIEJpanUtc2FuLAo+IAo+ID4gRnJvbTogQmlq dSBEYXMsIFNlbnQ6IFRodXJzZGF5LCBNYXJjaCAxNCwgMjAxOSA1OjQwIFBNCj4gPgo+ID4gQWRk IHN1cHBvcnQgZm9yIHJlbmVzYXNfdXNiMyB0byBzdXBwb3J0IGR1YWwgcm9sZSBzd2l0Y2ggdXNp bmcgdXNiCj4gPiByb2xlIHN3aXRjaCBjbGFzcyBmcmFtZXdvcmsuCj4gPgo+ID4gU2lnbmVkLW9m Zi1ieTogQmlqdSBEYXMgPGJpanUuZGFzQGJwLnJlbmVzYXMuY29tPgo+ID4gLS0tCj4gPiAgVjEt LT5WMgo+ID4gICAqIEFkZGVkIHVzYi1yb2xlLXN3aXRjaC1wcm9wZXJ0eQo+ID4gICAqIFVwZGF0 ZWQgdGhlIGV4YW1wbGUgd2l0aCB1c2Itcm9sZS1zd2l0Y2ggcHJvcGVydHkuCj4gPiAtLS0KPiA+ ICAuLi4vZGV2aWNldHJlZS9iaW5kaW5ncy91c2IvcmVuZXNhc191c2IzLnR4dCAgICAgICB8IDIy Cj4gKysrKysrKysrKysrKysrKysrKysrKwo+ID4gIDEgZmlsZSBjaGFuZ2VkLCAyMiBpbnNlcnRp b25zKCspCj4gPgo+ID4gZGlmZiAtLWdpdCBhL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5k aW5ncy91c2IvcmVuZXNhc191c2IzLnR4dAo+ID4gYi9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUv YmluZGluZ3MvdXNiL3JlbmVzYXNfdXNiMy50eHQKPiA+IGluZGV4IDM1MDM5ZTcuLmVlY2FmNGMg MTAwNjQ0Cj4gPiAtLS0gYS9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvdXNiL3Jl bmVzYXNfdXNiMy50eHQKPiA+ICsrKyBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5n cy91c2IvcmVuZXNhc191c2IzLnR4dAo+ID4gQEAgLTIyLDYgKzIyLDcgQEAgUmVxdWlyZWQgcHJv cGVydGllczoKPiA+ICBPcHRpb25hbCBwcm9wZXJ0aWVzOgo+ID4gICAgLSBwaHlzOiBwaGFuZGxl ICsgcGh5IHNwZWNpZmllciBwYWlyCj4gPiAgICAtIHBoeS1uYW1lczogbXVzdCBiZSAidXNiIgo+ ID4gKyAgLSB1c2Itcm9sZS1zd2l0Y2g6IHVzZSBVU0Igcm9sZSBzd2l0Y2ggdG8gc3VwcG9ydCBk dWFsLXJvbGUgc3dpdGNoCj4gCj4gSSBkb24ndCB0aGluayB3ZSBjYW4gYWRkIHN1Y2ggYSBwcm9w ZXJ0eS4gQXQgbGVhc3QsIHdlIGhhdmUgdG8gYWRkICJyZW5lc2FzLCIKPiBwcmVmaXguCgp1c2Jf cm9sZV9zd2l0Y2hfZ2V0ICAgYXBpIHVzZXMgICJ1c2Itcm9sZS1zd2l0Y2giICBwcm9wZXJ0eSB0 byBnZXQgcm9sZSBzd2l0Y2ggbGlua2VkIHdpdGggdGhlIGRldmljZS4KCkhEM1NTMzIyMCBwb3J0 IGNvbnRyb2xsZXIgZHJpdmVyIGdldHMgcm9sZSBzd2l0Y2ggaGFuZGxlIGxpbmtlZCB3aXRoIHRo ZSBkZXZpY2UgdXNpbmcgdXNiX3JvbGVfc3dpdGNoX2dldCAgYXBpLiAgClRoYXQgaXMgdGhlIHJl YXNvbiwgSSBoYXZlIGFkZGVkICIgdXNiLXJvbGUtc3dpdGNoIiBwcm9wZXJ0eSBoZXJlLgoKRG8g eW91IGhhdmUgYW55IG90aGVyIHN1Z2dlc3Rpb24gdG8gZ2V0IHVzYiByb2xlIHN3aXRjaCBoYW5k bGU/CgpQbGVhc2UgY29ycmVjdCBtZSBpZiBJIGFtIHdyb25nLiAKIAo+ID4gIEV4YW1wbGUgb2Yg Ui1DYXIgSDMgRVMxLng6Cj4gPiAgCXVzYjNfcGVyaTA6IHVzYkBlZTAyMDAwMCB7Cj4gPiBAQCAt MzksMyArNDAsMjQgQEAgRXhhbXBsZSBvZiBSLUNhciBIMyBFUzEueDoKPiA+ICAJCWludGVycnVw dHMgPSA8R0lDX1NQSSAxMDAgSVJRX1RZUEVfTEVWRUxfSElHSD47Cj4gPiAgCQljbG9ja3MgPSA8 JmNwZyBDUEdfTU9EIDMyNz47Cj4gPiAgCX07Cj4gPiArCj4gPiArRXhhbXBsZSBvZiBSWi9HMkU6 Cj4gPiArCXVzYjNfcGVyaTA6IHVzYkBlZTAyMDAwMCB7Cj4gPiArCQljb21wYXRpYmxlID0gInJl bmVzYXMscjhhNzc0YzAtdXNiMy1wZXJpIiwKPiA+ICsJCQkgICAgICJyZW5lc2FzLHJjYXItZ2Vu My11c2IzLXBlcmkiOwo+ID4gKwkJcmVnID0gPDAgMHhlZTAyMDAwMCAwIDB4NDAwPjsKPiA+ICsJ CWludGVycnVwdHMgPSA8R0lDX1NQSSAxMDQgSVJRX1RZUEVfTEVWRUxfSElHSD47Cj4gPiArCQlj bG9ja3MgPSA8JmNwZyBDUEdfTU9EIDMyOD47Cj4gPiArCQljb21wYW5pb24gPSA8JnhoY2kwPjsK PiA+ICsJCXVzYi1yb2xlLXN3aXRjaDsKPiA+ICsKPiA+ICsJCXBvcnQgewo+ID4gKwkJCSNhZGRy ZXNzLWNlbGxzID0gPDE+Owo+ID4gKwkJCSNzaXplLWNlbGxzID0gPDA+Owo+ID4gKwo+ID4gKwkJ CXVzYjNwZXJpX3JvbGVfc3dpdGNoOiBlbmRwb2ludEAwIHsKPiA+ICsJCQkJcmVnID0gPDA+Owo+ ID4gKwkJCQlyZW1vdGUtZW5kcG9pbnQgPSA8JmhkM3NzMzIyMF9lcD47Cj4gPiArCQkJfTsKPiA+ ICsJCX07Cj4gPiArCX07Cj4gPiAtLQo+ID4gMi43LjQKClJlZ2FyZHMsCkJpanUK