From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-eopbgr1410104.outbound.protection.outlook.com ([40.107.141.104]:1568 "EHLO JPN01-OS2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725779AbfC1NEP (ORCPT ); Thu, 28 Mar 2019 09:04:15 -0400 From: Biju Das Subject: RE: [PATCH 2/9] dt-bindings: usb: renesas_usb3: add extcon support Date: Thu, 28 Mar 2019 13:04:06 +0000 Message-ID: References: <1551863246-11656-1-git-send-email-biju.das@bp.renesas.com> <1551863246-11656-3-git-send-email-biju.das@bp.renesas.com> <20190327232802.GA28701@bogus> In-Reply-To: <20190327232802.GA28701@bogus> Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Sender: devicetree-owner@vger.kernel.org To: Rob Herring Cc: Mark Rutland , Greg Kroah-Hartman , Heikki Krogerus , Felipe Balbi , "linux-usb@vger.kernel.org" , "devicetree@vger.kernel.org" , Simon Horman , Yoshihiro Shimoda , Geert Uytterhoeven , Chris Paterson , Fabrizio Castro , "linux-renesas-soc@vger.kernel.org" List-ID: Hi Rob, Thanks for the feedback. > Subject: Re: [PATCH 2/9] dt-bindings: usb: renesas_usb3: add extcon suppo= rt >=20 > On Wed, Mar 06, 2019 at 09:07:19AM +0000, Biju Das wrote: > > Add support for renesas_usb3 to receive connect and disconnect > > notification using extcon framework. > > > > Signed-off-by: Biju Das > > --- > > Documentation/devicetree/bindings/usb/renesas_usb3.txt | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/usb/renesas_usb3.txt > > b/Documentation/devicetree/bindings/usb/renesas_usb3.txt > > index d366555..ae35674 100644 > > --- a/Documentation/devicetree/bindings/usb/renesas_usb3.txt > > +++ b/Documentation/devicetree/bindings/usb/renesas_usb3.txt > > @@ -21,6 +21,8 @@ Required properties: > > Optional properties: > > - phys: phandle + phy specifier pair > > - phy-names: must be "usb" > > + - extcon: phandle for the extcon device renesas usb3 uses to detect > > + connect/disconnect events. >=20 > Please don't use extcon and use usb-connector binding instead. I have switched to usb role switch framework instead of extcon and sent V2= based on the below feedback. https://patchwork.kernel.org/patch/10840659/ On V2, I have sent a patch series which uses " usb-connector " binding [1]= and "usb-role-switch" property[2] [1] https://patchwork.kernel.org/patch/10852495/ [2] https://patchwork.kernel.org/patch/10852497/ Support for "usb-role-switch" compatible can be found in the below patch = set https://patchwork.kernel.org/project/linux-usb/list/?series=3D97707 Please can you comment, is this approach is acceptable or not? Regards, Biju=20 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35E20C43381 for ; Thu, 28 Mar 2019 13:04:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E91FE206BA for ; Thu, 28 Mar 2019 13:04:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=renesasgroup.onmicrosoft.com header.i=@renesasgroup.onmicrosoft.com header.b="ZthFUs5B" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726334AbfC1NEP (ORCPT ); Thu, 28 Mar 2019 09:04:15 -0400 Received: from mail-eopbgr1410104.outbound.protection.outlook.com ([40.107.141.104]:1568 "EHLO JPN01-OS2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725779AbfC1NEP (ORCPT ); Thu, 28 Mar 2019 09:04:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=renesasgroup.onmicrosoft.com; s=selector1-bp-renesas-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dz0mSNHD2YFrjC4Ll+M0q7u1lcG+n13MvhTDZvCHW74=; b=ZthFUs5Bz9R35aEtDkFGE8qy14OnnksdZucLMWmEsa/rGXLRBHMV8fFRt8Y66gT/sn1cwp6b9l+yTNI+4UyAhAY1DeDj5qFrHC6iakasYACQ7d5MPZIz9meSbfDGU0PBbRxIc71XN1i/isBoTQdkMiAym3pFwROLvdn/09dpjB0= Received: from OSBPR01MB2103.jpnprd01.prod.outlook.com (52.134.242.17) by OSBPR01MB4630.jpnprd01.prod.outlook.com (20.179.182.203) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1750.16; Thu, 28 Mar 2019 13:04:07 +0000 Received: from OSBPR01MB2103.jpnprd01.prod.outlook.com ([fe80::9c06:60ec:8c9a:2888]) by OSBPR01MB2103.jpnprd01.prod.outlook.com ([fe80::9c06:60ec:8c9a:2888%4]) with mapi id 15.20.1750.014; Thu, 28 Mar 2019 13:04:07 +0000 From: Biju Das To: Rob Herring CC: Mark Rutland , Greg Kroah-Hartman , Heikki Krogerus , Felipe Balbi , "linux-usb@vger.kernel.org" , "devicetree@vger.kernel.org" , Simon Horman , Yoshihiro Shimoda , Geert Uytterhoeven , Chris Paterson , Fabrizio Castro , "linux-renesas-soc@vger.kernel.org" Subject: RE: [PATCH 2/9] dt-bindings: usb: renesas_usb3: add extcon support Thread-Topic: [PATCH 2/9] dt-bindings: usb: renesas_usb3: add extcon support Thread-Index: AQHU0/zZ6gf28HwQbk24vS3imN8dmKYgQXcAgADdedA= Date: Thu, 28 Mar 2019 13:04:06 +0000 Message-ID: References: <1551863246-11656-1-git-send-email-biju.das@bp.renesas.com> <1551863246-11656-3-git-send-email-biju.das@bp.renesas.com> <20190327232802.GA28701@bogus> In-Reply-To: <20190327232802.GA28701@bogus> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=biju.das@bp.renesas.com; x-originating-ip: [193.141.220.21] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2071c705-9bd2-4755-e96a-08d6b37ddc77 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(4618075)(2017052603328)(7153060)(7193020);SRVR:OSBPR01MB4630; x-ms-traffictypediagnostic: OSBPR01MB4630: x-ms-exchange-purlcount: 4 x-microsoft-antispam-prvs: x-forefront-prvs: 0990C54589 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(346002)(136003)(396003)(39860400002)(376002)(366004)(51914003)(199004)(189003)(305945005)(102836004)(71200400001)(74316002)(55016002)(71190400001)(66066001)(7416002)(26005)(7696005)(7736002)(5660300002)(105586002)(106356001)(6506007)(52536014)(229853002)(6436002)(76176011)(966005)(8676002)(478600001)(8936002)(86362001)(68736007)(81166006)(81156014)(14454004)(25786009)(3846002)(486006)(4326008)(11346002)(33656002)(476003)(186003)(44832011)(6306002)(6116002)(99286004)(2906002)(316002)(6246003)(53936002)(14444005)(6916009)(97736004)(9686003)(446003)(54906003)(256004);DIR:OUT;SFP:1102;SCL:1;SRVR:OSBPR01MB4630;H:OSBPR01MB2103.jpnprd01.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:0;MX:1; received-spf: None (protection.outlook.com: bp.renesas.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: Q4JuqU8/6xMHTfg//LNmKf9EOek7FlLh9vO8Lcy+u5fvjCRrJtYwZTqJPYPkWXhBSk1fXTamMz82S/AlTQbo10IyK02Fm3pBdAU2uAsSYSQ+gNhYPUCbpaz2fuejhyvwyBiJH1lW3dQXCXzEATB5BBU/kmkFP1h/uRaoO7kTbtBBdMynPWD1hz0WPtC8zY9s/+yAuQwa+lpB06M7SDzLwvN5eHT+I4SX9w6PPl67BTecraZIfb9ob0DsRikeJaOqZdYOTtkthJA6VIoXKW0UBgkefVrLPH91uWus0+OtumYFVZvKyQI/X+aLmL9kRUtmMHlryO251jbO28A6NCY+MLb6uKBZ1zTVJz7m5ZSlXGVsecDOWlh+CFT2hd4q9IJXUmkuLDps5Fj0yusSEmLg47y+dX6zSmWNE+iD4g2A1oc= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: bp.renesas.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2071c705-9bd2-4755-e96a-08d6b37ddc77 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Mar 2019 13:04:06.9012 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: OSBPR01MB4630 Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org Hi Rob, Thanks for the feedback. > Subject: Re: [PATCH 2/9] dt-bindings: usb: renesas_usb3: add extcon suppo= rt >=20 > On Wed, Mar 06, 2019 at 09:07:19AM +0000, Biju Das wrote: > > Add support for renesas_usb3 to receive connect and disconnect > > notification using extcon framework. > > > > Signed-off-by: Biju Das > > --- > > Documentation/devicetree/bindings/usb/renesas_usb3.txt | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/usb/renesas_usb3.txt > > b/Documentation/devicetree/bindings/usb/renesas_usb3.txt > > index d366555..ae35674 100644 > > --- a/Documentation/devicetree/bindings/usb/renesas_usb3.txt > > +++ b/Documentation/devicetree/bindings/usb/renesas_usb3.txt > > @@ -21,6 +21,8 @@ Required properties: > > Optional properties: > > - phys: phandle + phy specifier pair > > - phy-names: must be "usb" > > + - extcon: phandle for the extcon device renesas usb3 uses to detect > > + connect/disconnect events. >=20 > Please don't use extcon and use usb-connector binding instead. I have switched to usb role switch framework instead of extcon and sent V2= based on the below feedback. https://patchwork.kernel.org/patch/10840659/ On V2, I have sent a patch series which uses " usb-connector " binding [1]= and "usb-role-switch" property[2] [1] https://patchwork.kernel.org/patch/10852495/ [2] https://patchwork.kernel.org/patch/10852497/ Support for "usb-role-switch" compatible can be found in the below patch = set https://patchwork.kernel.org/project/linux-usb/list/?series=3D97707 Please can you comment, is this approach is acceptable or not? Regards, Biju=20 From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [2/9] dt-bindings: usb: renesas_usb3: add extcon support From: Biju Das Message-Id: Date: Thu, 28 Mar 2019 13:04:06 +0000 To: Rob Herring Cc: Mark Rutland , Greg Kroah-Hartman , Heikki Krogerus , Felipe Balbi , "linux-usb@vger.kernel.org" , "devicetree@vger.kernel.org" , Simon Horman , Yoshihiro Shimoda , Geert Uytterhoeven , Chris Paterson , Fabrizio Castro , "linux-renesas-soc@vger.kernel.org" List-ID: SGkgUm9iLAoKVGhhbmtzIGZvciB0aGUgZmVlZGJhY2suCgo+IFN1YmplY3Q6IFJlOiBbUEFUQ0gg Mi85XSBkdC1iaW5kaW5nczogdXNiOiByZW5lc2FzX3VzYjM6IGFkZCBleHRjb24gc3VwcG9ydAo+ IAo+IE9uIFdlZCwgTWFyIDA2LCAyMDE5IGF0IDA5OjA3OjE5QU0gKzAwMDAsIEJpanUgRGFzIHdy b3RlOgo+ID4gQWRkIHN1cHBvcnQgZm9yIHJlbmVzYXNfdXNiMyB0byByZWNlaXZlIGNvbm5lY3Qg YW5kIGRpc2Nvbm5lY3QKPiA+IG5vdGlmaWNhdGlvbiB1c2luZyBleHRjb24gZnJhbWV3b3JrLgo+ ID4KPiA+IFNpZ25lZC1vZmYtYnk6IEJpanUgRGFzIDxiaWp1LmRhc0BicC5yZW5lc2FzLmNvbT4K PiA+IC0tLQo+ID4gIERvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy91c2IvcmVuZXNh c191c2IzLnR4dCB8IDIgKysKPiA+ICAxIGZpbGUgY2hhbmdlZCwgMiBpbnNlcnRpb25zKCspCj4g Pgo+ID4gZGlmZiAtLWdpdCBhL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy91c2Iv cmVuZXNhc191c2IzLnR4dAo+ID4gYi9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3Mv dXNiL3JlbmVzYXNfdXNiMy50eHQKPiA+IGluZGV4IGQzNjY1NTUuLmFlMzU2NzQgMTAwNjQ0Cj4g PiAtLS0gYS9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvdXNiL3JlbmVzYXNfdXNi My50eHQKPiA+ICsrKyBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy91c2IvcmVu ZXNhc191c2IzLnR4dAo+ID4gQEAgLTIxLDYgKzIxLDggQEAgUmVxdWlyZWQgcHJvcGVydGllczoK PiA+ICBPcHRpb25hbCBwcm9wZXJ0aWVzOgo+ID4gICAgLSBwaHlzOiBwaGFuZGxlICsgcGh5IHNw ZWNpZmllciBwYWlyCj4gPiAgICAtIHBoeS1uYW1lczogbXVzdCBiZSAidXNiIgo+ID4gKyAgLSBl eHRjb246IHBoYW5kbGUgZm9yIHRoZSBleHRjb24gZGV2aWNlIHJlbmVzYXMgdXNiMyB1c2VzIHRv IGRldGVjdAo+ID4gKwkgICAgY29ubmVjdC9kaXNjb25uZWN0IGV2ZW50cy4KPiAKPiBQbGVhc2Ug ZG9uJ3QgdXNlIGV4dGNvbiBhbmQgdXNlIHVzYi1jb25uZWN0b3IgYmluZGluZyBpbnN0ZWFkLgoK SSBoYXZlIHN3aXRjaGVkIHRvIHVzYiByb2xlIHN3aXRjaCBmcmFtZXdvcmsgIGluc3RlYWQgb2Yg ZXh0Y29uIGFuZCBzZW50IFYyIGJhc2VkIG9uIHRoZSBiZWxvdyBmZWVkYmFjay4KaHR0cHM6Ly9w YXRjaHdvcmsua2VybmVsLm9yZy9wYXRjaC8xMDg0MDY1OS8KCk9uIFYyLCBJIGhhdmUgc2VudCAg YSBwYXRjaCBzZXJpZXMgd2hpY2ggdXNlcyAiIHVzYi1jb25uZWN0b3IgIiBiaW5kaW5nIFsxXSAg IGFuZCAidXNiLXJvbGUtc3dpdGNoIiBwcm9wZXJ0eVsyXQpbMV0gaHR0cHM6Ly9wYXRjaHdvcmsu a2VybmVsLm9yZy9wYXRjaC8xMDg1MjQ5NS8KWzJdIGh0dHBzOi8vcGF0Y2h3b3JrLmtlcm5lbC5v cmcvcGF0Y2gvMTA4NTI0OTcvCgpTdXBwb3J0IGZvciAgInVzYi1yb2xlLXN3aXRjaCIgY29tcGF0 aWJsZSBjYW4gYmUgIGZvdW5kIGluIHRoZSBiZWxvdyBwYXRjaCBzZXQKaHR0cHM6Ly9wYXRjaHdv cmsua2VybmVsLm9yZy9wcm9qZWN0L2xpbnV4LXVzYi9saXN0Lz9zZXJpZXM9OTc3MDcKClBsZWFz ZSBjYW4geW91IGNvbW1lbnQsIGlzIHRoaXMgYXBwcm9hY2ggaXMgYWNjZXB0YWJsZSBvciBub3Q/ CgpSZWdhcmRzLApCaWp1Cg==