All of lore.kernel.org
 help / color / mirror / Atom feed
From: Xiaoxiao Liu <xiaoxiao.liu-1@cn.alps.com>
To: "Pali Rohár" <pali.rohar@gmail.com>
Cc: XiaoXiao Liu <sliuuxiaonxiao@gmail.com>,
	"dmitry.torokhov@gmail.com" <dmitry.torokhov@gmail.com>,
	"peter.hutterer@who-t.net" <peter.hutterer@who-t.net>,
	"hui.wang@canonical.com" <hui.wang@canonical.com>,
	"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Xiaojian Cao <xiaojian.cao@cn.alps.com>,
	"zhangfp1@lenovo.com" <zhangfp1@lenovo.com>,
	Naoki Saito <naoki.saito@alpsalpine.com>,
	Hideo Kawase <hideo.kawase@alpsalpine.com>
Subject: 答复: 答复: [PATCH] input: alps-fix the issue alps cs19 trackstick do not work.
Date: Tue, 28 May 2019 07:55:12 +0000	[thread overview]
Message-ID: <OSBPR01MB48556FD88D7F7D5F91CB5579DA1E0@OSBPR01MB4855.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <20190528071824.jimhixhtsynzwixe@pali>

Add Kawase-san.

-----邮件原件-----
发件人: Pali Rohár <pali.rohar@gmail.com> 
发送时间: Tuesday, May 28, 2019 3:18 PM
收件人: 劉 曉曉 Xiaoxiao Liu <xiaoxiao.liu-1@cn.alps.com>
抄送: XiaoXiao Liu <sliuuxiaonxiao@gmail.com>; dmitry.torokhov@gmail.com; peter.hutterer@who-t.net; hui.wang@canonical.com; linux-input@vger.kernel.org; linux-kernel@vger.kernel.org; 曹 曉建 Xiaojian Cao <xiaojian.cao@cn.alps.com>; zhangfp1@lenovo.com; 斉藤 直樹 Naoki Saito <naoki.saito@alpsalpine.com>
主题: Re: 答复: [PATCH] input: alps-fix the issue alps cs19 trackstick do not work.

On Tuesday 28 May 2019 01:37:14 Xiaoxiao Liu wrote:
> Add Saito-san.
> 
> Hi Hui,
> Does it mean that your device (reported to kernel) sends only trackstick packets and not touchpad?
>    	-> Yes.

Ok, I think this answers all questions.

So your patch is not correct as it registers "fake" touchpad device even there is no touchpad at all.

You should fix your patch to not register touchpad input device, in your case it should register only trackstick device. I suggest to add some flag which would indicate such device (e.g. ALPS_ONLY_TRACKSTICK).

Also currently kernel exports following names when device has both trackstick and touchpad: "DualPoint Stick" and "DualPoint TouchPad".
And it exports name "GlidePoint" for touchpad-only device. So to be consistent you need to also modify this code for trackstick-only device.

--
Pali Rohár
pali.rohar@gmail.com

  reply	other threads:[~2019-05-28  7:55 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-27  9:44 [PATCH] input: alps-fix the issue alps cs19 trackstick do not work XiaoXiao Liu
2019-05-27 10:09 ` Pali Rohár
2019-05-28  1:37   ` 答复: " Xiaoxiao Liu
2019-05-28  7:18     ` Pali Rohár
2019-05-28  7:55       ` Xiaoxiao Liu [this message]
2019-06-10  9:20         ` 答复: " Xiaoxiao Liu
2019-06-10 10:03           ` Xiaoxiao Liu
2019-06-10 10:03             ` Xiaoxiao Liu
2019-06-10 10:43             ` Pali Rohár
2019-06-11  3:05               ` 答复: " Xiaoxiao Liu
2019-06-11  3:23                 ` Hui Wang
2019-06-11  4:32                   ` Hui Wang
2019-06-11  7:23                     ` Pali Rohár
2019-06-11 17:07                       ` dmitry.torokhov
2019-06-11 17:17                         ` Pali Rohár
2019-06-11 17:32                           ` dmitry.torokhov
2019-06-11 17:38                             ` Pali Rohár
2019-06-11 17:45                               ` dmitry.torokhov
2019-06-17  1:29                               ` 答复: " Xiaoxiao Liu
2019-06-17  7:49                                 ` Pali Rohár
2019-06-18  8:19                                   ` Hui Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=OSBPR01MB48556FD88D7F7D5F91CB5579DA1E0@OSBPR01MB4855.jpnprd01.prod.outlook.com \
    --to=xiaoxiao.liu-1@cn.alps.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=hideo.kawase@alpsalpine.com \
    --cc=hui.wang@canonical.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=naoki.saito@alpsalpine.com \
    --cc=pali.rohar@gmail.com \
    --cc=peter.hutterer@who-t.net \
    --cc=sliuuxiaonxiao@gmail.com \
    --cc=xiaojian.cao@cn.alps.com \
    --cc=zhangfp1@lenovo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.