[PATCH 0/4] USB host support for TQMa8MPxL + MBa8MPxL

[PATCH 0/4] USB host support for TQMa8MPxL + MBa8MPxL

[Alexander Stein]

Hi everybody,

this is a series based on the RFC at [1] for USB host support on TQMa8MPxL +
MBa8MPxL. The main difference is that USB DR support has already been added and
has been removed from this series.

The DT configuration itself (patch 4) is rather straight forward, but leads to
the following dmesg errors regarding superspeed ports:
> [    8.549243] hub 2-1:1.0: hub_ext_port_status failed (err = -110)
> [   22.885263] usb 2-1: Failed to suspend device, error -110

This hardware works fine using the downstream kernel, because for imx8mp this
ITP sync feature is enabled conditionally [2] & [3].
Hacking this into mainline resulted in a working superspeed setup as well. I
also noticed that on some android kernel [4] depending in IP core version either
GCTL.SOFTITPSYNC or GFLADJ.GFLADJ_REFCLK_LPM_SEL is enabled unconditionally.
So I opted for the latter one using some quirk (patch 1-3).

I have to admit I do not know what this is actually about, nor why my setup
does not work without this change or why this fixed my problem. So maybe
someone with more knowledge can say if this is the way to go or what this is
about.

I also added snps,dis_u3_susphy_quirk to the board level as for some reason
USB Superspeed U3 does not work. Detecting the onboard hub takes much longer
and once all devices are diconnected from the hub it is put into runtime
suspend (U3) and new attached devices are not detected at all. Until the cause
is known and fixed runtime suspend has to be disabled.

Thanks and best regards,
Alexander

[1] https://lore.kernel.org/all/20220622130440.955465-1-alexander.stein@ew.tq-group.com/
[2] https://source.codeaurora.org/external/imx/linux-imx/tree/drivers/usb/dwc3/dwc3-imx8mp.c?h=lf-5.10.y#n134
[3] https://source.codeaurora.org/external/imx/linux-imx/tree/drivers/usb/dwc3/core.c?h=lf-5.10.y#n333
[4] https://android.googlesource.com/kernel/msm/+/87a6b154766907020cc74c7726e8a68aaa9d7f6b%5E%21/#F0

Alexander Stein (4):
  dt-bindings: usb: dwc3: Add gfladj-refclk-lpm-sel-quirk
  usb: dwc3: core: add gfladj_refclk_lpm_sel quirk
  arm64: dts: imx8mp: Add snps,gfladj-refclk-lpm-sel quirk to USB nodes
  arm64: dts: tqma8mpql: add support for 2nd USB (host) interface

 .../devicetree/bindings/usb/snps,dwc3.yaml    |  5 +++
 .../freescale/imx8mp-tqma8mpql-mba8mpxl.dts   | 42 +++++++++++++++++++
 arch/arm64/boot/dts/freescale/imx8mp.dtsi     |  2 +
 drivers/usb/dwc3/core.c                       |  8 +++-
 drivers/usb/dwc3/core.h                       |  2 +
 5 files changed, 58 insertions(+), 1 deletion(-)

-- 
2.25.1

[PATCH 1/4] dt-bindings: usb: dwc3: Add gfladj-refclk-lpm-sel-quirk

[Alexander Stein]

This selects SOF/ITP to be running on ref_clk.

Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
 Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
index 1779d08ba1c0..2a54d0bb0b15 100644
--- a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
+++ b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
@@ -234,6 +234,11 @@ properties:
       avoid -EPROTO errors with usbhid on some devices (Hikey 970).
     type: boolean
 
+  snps,gfladj-refclk-lpm-sel-quirk:
+    description:
+      When set, run the SOF/ITP counter based on ref_clk.
+    type: boolean
+
   snps,is-utmi-l1-suspend:
     description:
       True when DWC3 asserts output signal utmi_l1_suspend_n, false when
-- 
2.25.1

[PATCH 2/4] usb: dwc3: core: add gfladj_refclk_lpm_sel quirk

[Alexander Stein]

This selects the SOF/ITP counter be running on ref_clk. As documented
U2_FREECLK_EXISTS has to be set to 0 as well.

Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
 drivers/usb/dwc3/core.c | 8 +++++++-
 drivers/usb/dwc3/core.h | 2 ++
 2 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
index 8c8e32651473..12e8e7d34cb8 100644
--- a/drivers/usb/dwc3/core.c
+++ b/drivers/usb/dwc3/core.c
@@ -408,6 +408,10 @@ static void dwc3_ref_clk_period(struct dwc3 *dwc)
 	reg |= FIELD_PREP(DWC3_GFLADJ_REFCLK_FLADJ_MASK, fladj)
 	    |  FIELD_PREP(DWC3_GFLADJ_240MHZDECR, decr >> 1)
 	    |  FIELD_PREP(DWC3_GFLADJ_240MHZDECR_PLS1, decr & 1);
+
+	if (dwc->gfladj_refclk_lpm_sel)
+		reg |=  DWC3_GFLADJ_REFCLK_LPM_SEL;
+
 	dwc3_writel(dwc->regs, DWC3_GFLADJ, reg);
 }
 
@@ -789,7 +793,7 @@ static int dwc3_phy_setup(struct dwc3 *dwc)
 	else
 		reg |= DWC3_GUSB2PHYCFG_ENBLSLPM;
 
-	if (dwc->dis_u2_freeclk_exists_quirk)
+	if (dwc->dis_u2_freeclk_exists_quirk || dwc->gfladj_refclk_lpm_sel)
 		reg &= ~DWC3_GUSB2PHYCFG_U2_FREECLK_EXISTS;
 
 	dwc3_writel(dwc->regs, DWC3_GUSB2PHYCFG(0), reg);
@@ -1525,6 +1529,8 @@ static void dwc3_get_properties(struct dwc3 *dwc)
 				"snps,dis-tx-ipgap-linecheck-quirk");
 	dwc->parkmode_disable_ss_quirk = device_property_read_bool(dev,
 				"snps,parkmode-disable-ss-quirk");
+	dwc->gfladj_refclk_lpm_sel = device_property_read_bool(dev,
+				"snps,gfladj-refclk-lpm-sel-quirk");
 
 	dwc->tx_de_emphasis_quirk = device_property_read_bool(dev,
 				"snps,tx_de_emphasis_quirk");
diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
index 4fe4287dc934..11975a03316f 100644
--- a/drivers/usb/dwc3/core.h
+++ b/drivers/usb/dwc3/core.h
@@ -391,6 +391,7 @@
 #define DWC3_GFLADJ_30MHZ_SDBND_SEL		BIT(7)
 #define DWC3_GFLADJ_30MHZ_MASK			0x3f
 #define DWC3_GFLADJ_REFCLK_FLADJ_MASK		GENMASK(21, 8)
+#define DWC3_GFLADJ_REFCLK_LPM_SEL		BIT(23)
 #define DWC3_GFLADJ_240MHZDECR			GENMASK(30, 24)
 #define DWC3_GFLADJ_240MHZDECR_PLS1		BIT(31)
 
@@ -1312,6 +1313,7 @@ struct dwc3 {
 	unsigned		dis_del_phy_power_chg_quirk:1;
 	unsigned		dis_tx_ipgap_linecheck_quirk:1;
 	unsigned		parkmode_disable_ss_quirk:1;
+	unsigned		gfladj_refclk_lpm_sel:1;
 
 	unsigned		tx_de_emphasis_quirk:1;
 	unsigned		tx_de_emphasis:2;
-- 
2.25.1

[PATCH 3/4] arm64: dts: imx8mp: Add snps,gfladj-refclk-lpm-sel quirk to USB nodes

[Alexander Stein]

With this set the SOF/ITP counter is based on ref_clk when 2.0 ports are
suspended.

Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
 arch/arm64/boot/dts/freescale/imx8mp.dtsi | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
index 53493dc7d976..0e7f5842a3e4 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
@@ -1300,6 +1300,7 @@ usb_dwc3_0: usb@38100000 {
 				phys = <&usb3_phy0>, <&usb3_phy0>;
 				phy-names = "usb2-phy", "usb3-phy";
 				snps,dis-u2-freeclk-exists-quirk;
+				snps,gfladj-refclk-lpm-sel-quirk;
 			};
 
 		};
@@ -1342,6 +1343,7 @@ usb_dwc3_1: usb@38200000 {
 				phys = <&usb3_phy1>, <&usb3_phy1>;
 				phy-names = "usb2-phy", "usb3-phy";
 				snps,dis-u2-freeclk-exists-quirk;
+				snps,gfladj-refclk-lpm-sel-quirk;
 			};
 		};
 
-- 
2.25.1

[PATCH 4/4] arm64: dts: tqma8mpql: add support for 2nd USB (host) interface

[Alexander Stein]

The on-board USB hub has a single reset line which needs to be enabled.

Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
 .../freescale/imx8mp-tqma8mpql-mba8mpxl.dts   | 42 +++++++++++++++++++
 1 file changed, 42 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mpxl.dts b/arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mpxl.dts
index 0091430f6154..09c80ffae4b6 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mpxl.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mpxl.dts
@@ -459,11 +459,23 @@ &usb3_0 {
 	status = "okay";
 };
 
+&usb3_1 {
+	fsl,disable-port-power-control;
+	fsl,permanently-attached;
+	dr_mode = "host";
+	status = "okay";
+};
+
 &usb3_phy0 {
 	vbus-supply = <&reg_vcc_5v0>;
 	status = "okay";
 };
 
+&usb3_phy1 {
+	vbus-supply = <&reg_vcc_5v0>;
+	status = "okay";
+};
+
 &usb_dwc3_0 {
 	/* dual role is implemented, but not a full featured OTG */
 	hnp-disable;
@@ -484,6 +496,32 @@ connector {
 	};
 };
 
+&usb_dwc3_1 {
+	dr_mode = "host";
+	#address-cells = <1>;
+	#size-cells = <0>;
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_usbhub>;
+	snps,dis_u3_susphy_quirk;
+	status = "okay";
+
+	hub_2_0: hub@1 {
+		compatible = "usb451,8142";
+		reg = <1>;
+		peer-hub = <&hub_3_0>;
+		reset-gpios = <&gpio1 11 GPIO_ACTIVE_LOW>;
+		vdd-supply = <&reg_vcc_3v3>;
+	};
+
+	hub_3_0: hub@2 {
+		compatible = "usb451,8140";
+		reg = <2>;
+		peer-hub = <&hub_2_0>;
+		reset-gpios = <&gpio1 11 GPIO_ACTIVE_LOW>;
+		vdd-supply = <&reg_vcc_3v3>;
+	};
+};
+
 &usdhc2 {
 	pinctrl-names = "default", "state_100mhz", "state_200mhz";
 	pinctrl-0 = <&pinctrl_usdhc2>, <&pinctrl_usdhc2_gpio>;
@@ -714,6 +752,10 @@ pinctrl_usbcon0: usb0congrp {
 		fsl,pins = <MX8MP_IOMUXC_GPIO1_IO10__GPIO1_IO10		0x1c0>;
 	};
 
+	pinctrl_usbhub: usbhubgrp {
+		fsl,pins = <MX8MP_IOMUXC_GPIO1_IO11__GPIO1_IO11		0x10>;
+	};
+
 	pinctrl_usdhc2: usdhc2grp {
 		fsl,pins = <MX8MP_IOMUXC_SD2_CLK__USDHC2_CLK		0x192>,
 			   <MX8MP_IOMUXC_SD2_CMD__USDHC2_CMD		0x1d2>,
-- 
2.25.1

RE: [PATCH 0/4] USB host support for TQMa8MPxL + MBa8MPxL

[Jun Li]

Hi

> -----Original Message-----
> From: Alexander Stein <alexander.stein@ew.tq-group.com>
> Sent: Wednesday, September 7, 2022 10:46 PM
> To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>; Rob Herring
> <robh+dt@kernel.org>; Krzysztof Kozlowski
> <krzysztof.kozlowski+dt@linaro.org>; Shawn Guo <shawnguo@kernel.org>;
> Sascha Hauer <s.hauer@pengutronix.de>; Pengutronix Kernel Team
> <kernel@pengutronix.de>; Fabio Estevam <festevam@gmail.com>; dl-linux-imx
> <linux-imx@nxp.com>; Jun Li <jun.li@nxp.com>
> Cc: Alexander Stein <alexander.stein@ew.tq-group.com>;
> linux-usb@vger.kernel.org; devicetree@vger.kernel.org;
> linux-kernel@vger.kernel.org
> Subject: [PATCH 0/4] USB host support for TQMa8MPxL + MBa8MPxL
> 
> Hi everybody,
> 
> this is a series based on the RFC at [1] for USB host support on TQMa8MPxL
> + MBa8MPxL. The main difference is that USB DR support has already been added
> and has been removed from this series.
> 
> The DT configuration itself (patch 4) is rather straight forward, but leads
> to the following dmesg errors regarding superspeed ports:
> > [    8.549243] hub 2-1:1.0: hub_ext_port_status failed (err = -110)
> > [   22.885263] usb 2-1: Failed to suspend device, error -110
> 
> This hardware works fine using the downstream kernel, because for imx8mp
> this ITP sync feature is enabled conditionally [2] & [3].
> Hacking this into mainline resulted in a working superspeed setup as well.
> I also noticed that on some android kernel [4] depending in IP core version
> either GCTL.SOFTITPSYNC or GFLADJ.GFLADJ_REFCLK_LPM_SEL is enabled
> unconditionally.
> So I opted for the latter one using some quirk (patch 1-3).
> 
> I have to admit I do not know what this is actually about, nor why my setup
> does not work without this change or why this fixed my problem. So maybe
> someone with more knowledge can say if this is the way to go or what this
> is about.

This can be updated:)

> 
> I also added snps,dis_u3_susphy_quirk to the board level as for some reason
> USB Superspeed U3 does not work. Detecting the onboard hub takes much longer
> and once all devices are diconnected from the hub it is put into runtime
> suspend (U3) and new attached devices are not detected at all. Until the
> cause is known and fixed runtime suspend has to be disabled.

For this issue you are reporting, I am not sure if this is caused by a USB
clock change merged on v5.19, if you use latest kernel, can you try with
below patches applied to see if U3 can work for you?

[1] https://patchwork.kernel.org/project/linux-arm-kernel/patch/1662547028-22279-1-git-send-email-jun.li@nxp.com/
[2] https://patchwork.kernel.org/project/linux-arm-kernel/patch/1662547028-22279-2-git-send-email-jun.li@nxp.com/
[3] https://patchwork.kernel.org/project/linux-arm-kernel/patch/1661328612-3932-1-git-send-email-jun.li@nxp.com/

Li Jun
> 
> Thanks and best regards,
> Alexander
> 
> [1]
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.
> kernel.org%2Fall%2F20220622130440.955465-1-alexander.stein%40ew.tq-grou
> p.com%2F&amp;data=05%7C01%7Cjun.li%40nxp.com%7Cd1bdfb58b364464e957d08da
> 90dfc29f%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C63798158796971424
> 0%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6I
> k1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=WSQHERVO9SCWk%2B%2Fmq8g
> K78yluy5VE7T%2BhUaDMlNhbWk%3D&amp;reserved=0
> [2]
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fsourc
> e.codeaurora.org%2Fexternal%2Fimx%2Flinux-imx%2Ftree%2Fdrivers%2Fusb%2F
> dwc3%2Fdwc3-imx8mp.c%3Fh%3Dlf-5.10.y%23n134&amp;data=05%7C01%7Cjun.li%4
> 0nxp.com%7Cd1bdfb58b364464e957d08da90dfc29f%7C686ea1d3bc2b4c6fa92cd99c5
> c301635%7C0%7C0%7C637981587969870477%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC
> 4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7
> C&amp;sdata=9%2FxYZoZSelekGcWIZZNwRQqy8LTGPnnn13Rf4L5a0iY%3D&amp;reserv
> ed=0
> [3]
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fsourc
> e.codeaurora.org%2Fexternal%2Fimx%2Flinux-imx%2Ftree%2Fdrivers%2Fusb%2F
> dwc3%2Fcore.c%3Fh%3Dlf-5.10.y%23n333&amp;data=05%7C01%7Cjun.li%40nxp.co
> m%7Cd1bdfb58b364464e957d08da90dfc29f%7C686ea1d3bc2b4c6fa92cd99c5c301635
> %7C0%7C0%7C637981587969870477%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwM
> DAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;s
> data=Or9hvtM%2F9DhPZbfv%2BKzwAm8QTyXg4y0ddVbMFqOM67Q%3D&amp;reserved=0
> [4]
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fandro
> id.googlesource.com%2Fkernel%2Fmsm%2F%2B%2F87a6b154766907020cc74c7726e8
> a68aaa9d7f6b%255E%2521%2F%23F0&amp;data=05%7C01%7Cjun.li%40nxp.com%7Cd1
> bdfb58b364464e957d08da90dfc29f%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7
> C0%7C637981587969870477%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJ
> QIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=3
> tjAzUL81SwFkaoUh56CND%2B27FHqdo6TbY7Z66ldE8Q%3D&amp;reserved=0
> 
> Alexander Stein (4):
>   dt-bindings: usb: dwc3: Add gfladj-refclk-lpm-sel-quirk
>   usb: dwc3: core: add gfladj_refclk_lpm_sel quirk
>   arm64: dts: imx8mp: Add snps,gfladj-refclk-lpm-sel quirk to USB nodes
>   arm64: dts: tqma8mpql: add support for 2nd USB (host) interface
> 
>  .../devicetree/bindings/usb/snps,dwc3.yaml    |  5 +++
>  .../freescale/imx8mp-tqma8mpql-mba8mpxl.dts   | 42 +++++++++++++++++++
>  arch/arm64/boot/dts/freescale/imx8mp.dtsi     |  2 +
>  drivers/usb/dwc3/core.c                       |  8 +++-
>  drivers/usb/dwc3/core.h                       |  2 +
>  5 files changed, 58 insertions(+), 1 deletion(-)
> 
> --
> 2.25.1

RE: [PATCH 0/4] USB host support for TQMa8MPxL + MBa8MPxL

[Alexander Stein]

Hi,

Am Mittwoch, 7. September 2022, 18:08:25 CEST schrieb Jun Li:
> Hi
> 
> > -----Original Message-----
> > From: Alexander Stein <alexander.stein@ew.tq-group.com>
> > Sent: Wednesday, September 7, 2022 10:46 PM
> > To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>; Rob Herring
> > <robh+dt@kernel.org>; Krzysztof Kozlowski
> > <krzysztof.kozlowski+dt@linaro.org>; Shawn Guo <shawnguo@kernel.org>;
> > Sascha Hauer <s.hauer@pengutronix.de>; Pengutronix Kernel Team
> > <kernel@pengutronix.de>; Fabio Estevam <festevam@gmail.com>; dl-linux-imx
> > <linux-imx@nxp.com>; Jun Li <jun.li@nxp.com>
> > Cc: Alexander Stein <alexander.stein@ew.tq-group.com>;
> > linux-usb@vger.kernel.org; devicetree@vger.kernel.org;
> > linux-kernel@vger.kernel.org
> > Subject: [PATCH 0/4] USB host support for TQMa8MPxL + MBa8MPxL
> > 
> > Hi everybody,
> > 
> > this is a series based on the RFC at [1] for USB host support on TQMa8MPxL
> > + MBa8MPxL. The main difference is that USB DR support has already been
> > added and has been removed from this series.
> > 
> > The DT configuration itself (patch 4) is rather straight forward, but
> > leads
> > 
> > to the following dmesg errors regarding superspeed ports:
> > > [    8.549243] hub 2-1:1.0: hub_ext_port_status failed (err = -110)
> > > [   22.885263] usb 2-1: Failed to suspend device, error -110
> > 
> > This hardware works fine using the downstream kernel, because for imx8mp
> > this ITP sync feature is enabled conditionally [2] & [3].
> > Hacking this into mainline resulted in a working superspeed setup as well.
> > I also noticed that on some android kernel [4] depending in IP core
> > version
> > either GCTL.SOFTITPSYNC or GFLADJ.GFLADJ_REFCLK_LPM_SEL is enabled
> > unconditionally.
> > So I opted for the latter one using some quirk (patch 1-3).
> > 
> > I have to admit I do not know what this is actually about, nor why my
> > setup
> > does not work without this change or why this fixed my problem. So maybe
> > someone with more knowledge can say if this is the way to go or what this
> > is about.
> 
> This can be updated:)
> 
> > I also added snps,dis_u3_susphy_quirk to the board level as for some
> > reason
> > USB Superspeed U3 does not work. Detecting the onboard hub takes much
> > longer and once all devices are diconnected from the hub it is put into
> > runtime suspend (U3) and new attached devices are not detected at all.
> > Until the cause is known and fixed runtime suspend has to be disabled.
> 
> For this issue you are reporting, I am not sure if this is caused by a USB
> clock change merged on v5.19, if you use latest kernel, can you try with
> below patches applied to see if U3 can work for you?

Awesome, This does the trick!
I was already running with patches [1] & [2], but was missing patch [3]. With 
all of them applied, USB detects a newly attached superspeed device when the 
HUB is in runtime suspend (U3).

I forgot: thanks for checking with synopsis regarding soft ITP sync feature.

Best regards,
Alexander

> [1]
> https://patchwork.kernel.org/project/linux-arm-kernel/patch/1662547028-2227
> 9-1-git-send-email-jun.li@nxp.com/ [2]
> https://patchwork.kernel.org/project/linux-arm-kernel/patch/1662547028-2227
> 9-2-git-send-email-jun.li@nxp.com/ [3]
> https://patchwork.kernel.org/project/linux-arm-kernel/patch/1661328612-3932
> -1-git-send-email-jun.li@nxp.com/
>
> Li Jun
> 
> > Thanks and best regards,
> > Alexander
> > 
> > [1]
> > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.
> > kernel.org%2Fall%2F20220622130440.955465-1-alexander.stein%40ew.tq-grou
> > p.com%2F&amp;data=05%7C01%7Cjun.li%40nxp.com%7Cd1bdfb58b364464e957d08da
> > 90dfc29f%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C63798158796971424
> > 0%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6I
> > k1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=WSQHERVO9SCWk%2B%2Fmq8g
> > K78yluy5VE7T%2BhUaDMlNhbWk%3D&amp;reserved=0
> > [2]
> > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fsourc
> > e.codeaurora.org%2Fexternal%2Fimx%2Flinux-imx%2Ftree%2Fdrivers%2Fusb%2F
> > dwc3%2Fdwc3-imx8mp.c%3Fh%3Dlf-5.10.y%23n134&amp;data=05%7C01%7Cjun.li%4
> > 0nxp.com%7Cd1bdfb58b364464e957d08da90dfc29f%7C686ea1d3bc2b4c6fa92cd99c5
> > c301635%7C0%7C0%7C637981587969870477%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC
> > 4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7
> > C&amp;sdata=9%2FxYZoZSelekGcWIZZNwRQqy8LTGPnnn13Rf4L5a0iY%3D&amp;reserv
> > ed=0
> > [3]
> > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fsourc
> > e.codeaurora.org%2Fexternal%2Fimx%2Flinux-imx%2Ftree%2Fdrivers%2Fusb%2F
> > dwc3%2Fcore.c%3Fh%3Dlf-5.10.y%23n333&amp;data=05%7C01%7Cjun.li%40nxp.co
> > m%7Cd1bdfb58b364464e957d08da90dfc29f%7C686ea1d3bc2b4c6fa92cd99c5c301635
> > %7C0%7C0%7C637981587969870477%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwM
> > DAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;s
> > data=Or9hvtM%2F9DhPZbfv%2BKzwAm8QTyXg4y0ddVbMFqOM67Q%3D&amp;reserved=0
> > [4]
> > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fandro
> > id.googlesource.com%2Fkernel%2Fmsm%2F%2B%2F87a6b154766907020cc74c7726e8
> > a68aaa9d7f6b%255E%2521%2F%23F0&amp;data=05%7C01%7Cjun.li%40nxp.com%7Cd1
> > bdfb58b364464e957d08da90dfc29f%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7
> > C0%7C637981587969870477%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJ
> > QIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=3
> > tjAzUL81SwFkaoUh56CND%2B27FHqdo6TbY7Z66ldE8Q%3D&amp;reserved=0
> > 
> > Alexander Stein (4):
> >   dt-bindings: usb: dwc3: Add gfladj-refclk-lpm-sel-quirk
> >   usb: dwc3: core: add gfladj_refclk_lpm_sel quirk
> >   arm64: dts: imx8mp: Add snps,gfladj-refclk-lpm-sel quirk to USB nodes
> >   arm64: dts: tqma8mpql: add support for 2nd USB (host) interface
> >  
> >  .../devicetree/bindings/usb/snps,dwc3.yaml    |  5 +++
> >  .../freescale/imx8mp-tqma8mpql-mba8mpxl.dts   | 42 +++++++++++++++++++
> >  arch/arm64/boot/dts/freescale/imx8mp.dtsi     |  2 +
> >  drivers/usb/dwc3/core.c                       |  8 +++-
> >  drivers/usb/dwc3/core.h                       |  2 +
> >  5 files changed, 58 insertions(+), 1 deletion(-)
> > 
> > --
> > 2.25.1

Re: [PATCH 1/4] dt-bindings: usb: dwc3: Add gfladj-refclk-lpm-sel-quirk

[Krzysztof Kozlowski]

On 07/09/2022 16:46, Alexander Stein wrote:
> This selects SOF/ITP to be running on ref_clk.
> 
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
>  Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 5 +++++
>  1 file changed, 5 insertions(+)
> 


Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

RE: [PATCH 0/4] USB host support for TQMa8MPxL + MBa8MPxL

[Jun Li]

Hi,

> -----Original Message-----
> From: Alexander Stein <alexander.stein@ew.tq-group.com>
> Sent: Thursday, September 8, 2022 1:50 PM
> To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>; Rob Herring
> <robh+dt@kernel.org>; Krzysztof Kozlowski
> <krzysztof.kozlowski+dt@linaro.org>; Shawn Guo <shawnguo@kernel.org>;
> Sascha Hauer <s.hauer@pengutronix.de>; Pengutronix Kernel Team
> <kernel@pengutronix.de>; Fabio Estevam <festevam@gmail.com>; dl-linux-imx
> <linux-imx@nxp.com>; Jun Li <jun.li@nxp.com>
> Cc: linux-usb@vger.kernel.org; devicetree@vger.kernel.org;
> linux-kernel@vger.kernel.org
> Subject: RE: [PATCH 0/4] USB host support for TQMa8MPxL + MBa8MPxL
> 
> Hi,
> 
> Am Mittwoch, 7. September 2022, 18:08:25 CEST schrieb Jun Li:
> > Hi
> >
> > > -----Original Message-----
> > > From: Alexander Stein <alexander.stein@ew.tq-group.com>
> > > Sent: Wednesday, September 7, 2022 10:46 PM
> > > To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>; Rob Herring
> > > <robh+dt@kernel.org>; Krzysztof Kozlowski
> > > <krzysztof.kozlowski+dt@linaro.org>; Shawn Guo
> > > <shawnguo@kernel.org>; Sascha Hauer <s.hauer@pengutronix.de>;
> > > Pengutronix Kernel Team <kernel@pengutronix.de>; Fabio Estevam
> > > <festevam@gmail.com>; dl-linux-imx <linux-imx@nxp.com>; Jun Li
> > > <jun.li@nxp.com>
> > > Cc: Alexander Stein <alexander.stein@ew.tq-group.com>;
> > > linux-usb@vger.kernel.org; devicetree@vger.kernel.org;
> > > linux-kernel@vger.kernel.org
> > > Subject: [PATCH 0/4] USB host support for TQMa8MPxL + MBa8MPxL
> > >
> > > Hi everybody,
> > >
> > > this is a series based on the RFC at [1] for USB host support on
> > > TQMa8MPxL
> > > + MBa8MPxL. The main difference is that USB DR support has already
> > > + been
> > > added and has been removed from this series.
> > >
> > > The DT configuration itself (patch 4) is rather straight forward,
> > > but leads
> > >
> > > to the following dmesg errors regarding superspeed ports:
> > > > [    8.549243] hub 2-1:1.0: hub_ext_port_status failed (err = -110)
> > > > [   22.885263] usb 2-1: Failed to suspend device, error -110
> > >
> > > This hardware works fine using the downstream kernel, because for
> > > imx8mp this ITP sync feature is enabled conditionally [2] & [3].
> > > Hacking this into mainline resulted in a working superspeed setup as
> well.
> > > I also noticed that on some android kernel [4] depending in IP core
> > > version either GCTL.SOFTITPSYNC or GFLADJ.GFLADJ_REFCLK_LPM_SEL is
> > > enabled unconditionally.
> > > So I opted for the latter one using some quirk (patch 1-3).
> > >
> > > I have to admit I do not know what this is actually about, nor why
> > > my setup does not work without this change or why this fixed my
> > > problem. So maybe someone with more knowledge can say if this is the
> > > way to go or what this is about.
> >
> > This can be updated:)
> >
> > > I also added snps,dis_u3_susphy_quirk to the board level as for some
> > > reason USB Superspeed U3 does not work. Detecting the onboard hub
> > > takes much longer and once all devices are diconnected from the hub
> > > it is put into runtime suspend (U3) and new attached devices are not
> > > detected at all.
> > > Until the cause is known and fixed runtime suspend has to be disabled.
> >
> > For this issue you are reporting, I am not sure if this is caused by a
> > USB clock change merged on v5.19, if you use latest kernel, can you
> > try with below patches applied to see if U3 can work for you?
> 
> Awesome, This does the trick!
> I was already running with patches [1] & [2], but was missing patch [3].
> With all of them applied, USB detects a newly attached superspeed device
> when the HUB is in runtime suspend (U3).

Yes, patch[3] needs to apply with patches [1]&[2], I am applying the
same tag to make sure the 3 patches land on the same target release
as they will go through diff maintainer's trees.

> 
> I forgot: thanks for checking with synopsis regarding soft ITP sync feature.
> 

Welcome.

Li Jun

RE: [PATCH 2/4] usb: dwc3: core: add gfladj_refclk_lpm_sel quirk

[Jun Li]

> -----Original Message-----
> From: Alexander Stein <alexander.stein@ew.tq-group.com>
> Sent: Wednesday, September 7, 2022 10:46 PM
> To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>; Rob Herring
> <robh+dt@kernel.org>; Krzysztof Kozlowski
> <krzysztof.kozlowski+dt@linaro.org>; Shawn Guo <shawnguo@kernel.org>;
> Sascha Hauer <s.hauer@pengutronix.de>; Pengutronix Kernel Team
> <kernel@pengutronix.de>; Fabio Estevam <festevam@gmail.com>; dl-linux-imx
> <linux-imx@nxp.com>; Jun Li <jun.li@nxp.com>
> Cc: Alexander Stein <alexander.stein@ew.tq-group.com>;
> linux-usb@vger.kernel.org; devicetree@vger.kernel.org;
> linux-kernel@vger.kernel.org
> Subject: [PATCH 2/4] usb: dwc3: core: add gfladj_refclk_lpm_sel quirk
> 
> This selects the SOF/ITP counter be running on ref_clk. As documented
> U2_FREECLK_EXISTS has to be set to 0 as well.
> 
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>

Reviewed-by: Li Jun <jun.li@nxp.com>

> ---
>  drivers/usb/dwc3/core.c | 8 +++++++-
>  drivers/usb/dwc3/core.h | 2 ++
>  2 files changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c index
> 8c8e32651473..12e8e7d34cb8 100644
> --- a/drivers/usb/dwc3/core.c
> +++ b/drivers/usb/dwc3/core.c
> @@ -408,6 +408,10 @@ static void dwc3_ref_clk_period(struct dwc3 *dwc)
>  	reg |= FIELD_PREP(DWC3_GFLADJ_REFCLK_FLADJ_MASK, fladj)
>  	    |  FIELD_PREP(DWC3_GFLADJ_240MHZDECR, decr >> 1)
>  	    |  FIELD_PREP(DWC3_GFLADJ_240MHZDECR_PLS1, decr & 1);
> +
> +	if (dwc->gfladj_refclk_lpm_sel)
> +		reg |=  DWC3_GFLADJ_REFCLK_LPM_SEL;
> +
>  	dwc3_writel(dwc->regs, DWC3_GFLADJ, reg);  }
> 
> @@ -789,7 +793,7 @@ static int dwc3_phy_setup(struct dwc3 *dwc)
>  	else
>  		reg |= DWC3_GUSB2PHYCFG_ENBLSLPM;
> 
> -	if (dwc->dis_u2_freeclk_exists_quirk)
> +	if (dwc->dis_u2_freeclk_exists_quirk || dwc->gfladj_refclk_lpm_sel)
>  		reg &= ~DWC3_GUSB2PHYCFG_U2_FREECLK_EXISTS;
> 
>  	dwc3_writel(dwc->regs, DWC3_GUSB2PHYCFG(0), reg); @@ -1525,6 +1529,8
> @@ static void dwc3_get_properties(struct dwc3 *dwc)
>  				"snps,dis-tx-ipgap-linecheck-quirk");
>  	dwc->parkmode_disable_ss_quirk = device_property_read_bool(dev,
>  				"snps,parkmode-disable-ss-quirk");
> +	dwc->gfladj_refclk_lpm_sel = device_property_read_bool(dev,
> +				"snps,gfladj-refclk-lpm-sel-quirk");
> 
>  	dwc->tx_de_emphasis_quirk = device_property_read_bool(dev,
>  				"snps,tx_de_emphasis_quirk");
> diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h index
> 4fe4287dc934..11975a03316f 100644
> --- a/drivers/usb/dwc3/core.h
> +++ b/drivers/usb/dwc3/core.h
> @@ -391,6 +391,7 @@
>  #define DWC3_GFLADJ_30MHZ_SDBND_SEL		BIT(7)
>  #define DWC3_GFLADJ_30MHZ_MASK			0x3f
>  #define DWC3_GFLADJ_REFCLK_FLADJ_MASK		GENMASK(21, 8)
> +#define DWC3_GFLADJ_REFCLK_LPM_SEL		BIT(23)
>  #define DWC3_GFLADJ_240MHZDECR			GENMASK(30, 24)
>  #define DWC3_GFLADJ_240MHZDECR_PLS1		BIT(31)
> 
> @@ -1312,6 +1313,7 @@ struct dwc3 {
>  	unsigned		dis_del_phy_power_chg_quirk:1;
>  	unsigned		dis_tx_ipgap_linecheck_quirk:1;
>  	unsigned		parkmode_disable_ss_quirk:1;
> +	unsigned		gfladj_refclk_lpm_sel:1;
> 
>  	unsigned		tx_de_emphasis_quirk:1;
>  	unsigned		tx_de_emphasis:2;
> --
> 2.25.1

RE: [PATCH 3/4] arm64: dts: imx8mp: Add snps,gfladj-refclk-lpm-sel quirk to USB nodes

[Jun Li]

> -----Original Message-----
> From: Alexander Stein <alexander.stein@ew.tq-group.com>
> Sent: Wednesday, September 7, 2022 10:46 PM
> To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>; Rob Herring
> <robh+dt@kernel.org>; Krzysztof Kozlowski
> <krzysztof.kozlowski+dt@linaro.org>; Shawn Guo <shawnguo@kernel.org>;
> Sascha Hauer <s.hauer@pengutronix.de>; Pengutronix Kernel Team
> <kernel@pengutronix.de>; Fabio Estevam <festevam@gmail.com>; dl-linux-imx
> <linux-imx@nxp.com>; Jun Li <jun.li@nxp.com>
> Cc: Alexander Stein <alexander.stein@ew.tq-group.com>;
> linux-usb@vger.kernel.org; devicetree@vger.kernel.org;
> linux-kernel@vger.kernel.org
> Subject: [PATCH 3/4] arm64: dts: imx8mp: Add snps,gfladj-refclk-lpm-sel
> quirk to USB nodes
> 
> With this set the SOF/ITP counter is based on ref_clk when 2.0 ports are
> suspended.
> 
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
>  arch/arm64/boot/dts/freescale/imx8mp.dtsi | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> index 53493dc7d976..0e7f5842a3e4 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> @@ -1300,6 +1300,7 @@ usb_dwc3_0: usb@38100000 {
>  				phys = <&usb3_phy0>, <&usb3_phy0>;
>  				phy-names = "usb2-phy", "usb3-phy";
>  				snps,dis-u2-freeclk-exists-quirk;

So this property can be removed?

> +				snps,gfladj-refclk-lpm-sel-quirk;
>  			};
> 
>  		};
> @@ -1342,6 +1343,7 @@ usb_dwc3_1: usb@38200000 {
>  				phys = <&usb3_phy1>, <&usb3_phy1>;
>  				phy-names = "usb2-phy", "usb3-phy";
>  				snps,dis-u2-freeclk-exists-quirk;

Ditto.

Li Jun
> +				snps,gfladj-refclk-lpm-sel-quirk;
>  			};
>  		};
> 
> --
> 2.25.1

RE: [PATCH 3/4] arm64: dts: imx8mp: Add snps, gfladj-refclk-lpm-sel quirk to USB nodes

[Alexander Stein]

Am Donnerstag, 8. September 2022, 11:12:23 CEST schrieb Jun Li:
> > -----Original Message-----
> > From: Alexander Stein <alexander.stein@ew.tq-group.com>
> > Sent: Wednesday, September 7, 2022 10:46 PM
> > To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>; Rob Herring
> > <robh+dt@kernel.org>; Krzysztof Kozlowski
> > <krzysztof.kozlowski+dt@linaro.org>; Shawn Guo <shawnguo@kernel.org>;
> > Sascha Hauer <s.hauer@pengutronix.de>; Pengutronix Kernel Team
> > <kernel@pengutronix.de>; Fabio Estevam <festevam@gmail.com>; dl-linux-imx
> > <linux-imx@nxp.com>; Jun Li <jun.li@nxp.com>
> > Cc: Alexander Stein <alexander.stein@ew.tq-group.com>;
> > linux-usb@vger.kernel.org; devicetree@vger.kernel.org;
> > linux-kernel@vger.kernel.org
> > Subject: [PATCH 3/4] arm64: dts: imx8mp: Add snps,gfladj-refclk-lpm-sel
> > quirk to USB nodes
> > 
> > With this set the SOF/ITP counter is based on ref_clk when 2.0 ports are
> > suspended.
> > 
> > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> > ---
> > 
> >  arch/arm64/boot/dts/freescale/imx8mp.dtsi | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> > b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> > index 53493dc7d976..0e7f5842a3e4 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> > @@ -1300,6 +1300,7 @@ usb_dwc3_0: usb@38100000 {
> > 
> >  				phys = <&usb3_phy0>, <&usb3_phy0>;
> >  				phy-names = "usb2-phy", "usb3-
phy";
> >  				snps,dis-u2-freeclk-exists-quirk;
> 
> So this property can be removed?

I'm not so sure about this one, as the description is talking about USB2 PHY 
providing a free-running PHY clock. I don't know the details if this is true 
or not.
But removing snps,dis-u2-freeclk-exists-quirk from both USB device nodes, USB 
devices attachments are still detected when the USB hub is suspended, both 
super-speed and high-speed ports.

Best regards,
Alexander

> > +				snps,gfladj-refclk-lpm-sel-quirk;
> > 
> >  			};
> >  		
> >  		};
> > 
> > @@ -1342,6 +1343,7 @@ usb_dwc3_1: usb@38200000 {
> > 
> >  				phys = <&usb3_phy1>, <&usb3_phy1>;
> >  				phy-names = "usb2-phy", "usb3-
phy";
> >  				snps,dis-u2-freeclk-exists-quirk;
> 
> Ditto.
> 
> Li Jun
> 
> > +				snps,gfladj-refclk-lpm-sel-quirk;
> > 
> >  			};
> >  		
> >  		};
> > 
> > --
> > 2.25.1

RE: [PATCH 3/4] arm64: dts: imx8mp: Add snps, gfladj-refclk-lpm-sel quirk to USB nodes

[Jun Li]

> -----Original Message-----
> From: Alexander Stein <alexander.stein@ew.tq-group.com>
> Sent: Thursday, September 8, 2022 5:39 PM
> To: Jun Li <jun.li@nxp.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>; Rob Herring
> <robh+dt@kernel.org>; Krzysztof Kozlowski
> <krzysztof.kozlowski+dt@linaro.org>; Shawn Guo <shawnguo@kernel.org>;
> Sascha Hauer <s.hauer@pengutronix.de>; Pengutronix Kernel Team
> <kernel@pengutronix.de>; Fabio Estevam <festevam@gmail.com>; dl-linux-imx
> <linux-imx@nxp.com>; linux-usb@vger.kernel.org;
> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: RE: [PATCH 3/4] arm64: dts: imx8mp: Add snps, gfladj-refclk-lpm-sel
> quirk to USB nodes
> 
> Am Donnerstag, 8. September 2022, 11:12:23 CEST schrieb Jun Li:
> > > -----Original Message-----
> > > From: Alexander Stein <alexander.stein@ew.tq-group.com>
> > > Sent: Wednesday, September 7, 2022 10:46 PM
> > > To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>; Rob Herring
> > > <robh+dt@kernel.org>; Krzysztof Kozlowski
> > > <krzysztof.kozlowski+dt@linaro.org>; Shawn Guo
> > > <shawnguo@kernel.org>; Sascha Hauer <s.hauer@pengutronix.de>;
> > > Pengutronix Kernel Team <kernel@pengutronix.de>; Fabio Estevam
> > > <festevam@gmail.com>; dl-linux-imx <linux-imx@nxp.com>; Jun Li
> > > <jun.li@nxp.com>
> > > Cc: Alexander Stein <alexander.stein@ew.tq-group.com>;
> > > linux-usb@vger.kernel.org; devicetree@vger.kernel.org;
> > > linux-kernel@vger.kernel.org
> > > Subject: [PATCH 3/4] arm64: dts: imx8mp: Add
> > > snps,gfladj-refclk-lpm-sel quirk to USB nodes
> > >
> > > With this set the SOF/ITP counter is based on ref_clk when 2.0 ports
> > > are suspended.
> > >
> > > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> > > ---
> > >
> > >  arch/arm64/boot/dts/freescale/imx8mp.dtsi | 2 ++
> > >  1 file changed, 2 insertions(+)
> > >
> > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> > > b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> > > index 53493dc7d976..0e7f5842a3e4 100644
> > > --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> > > +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> > > @@ -1300,6 +1300,7 @@ usb_dwc3_0: usb@38100000 {
> > >
> > >  				phys = <&usb3_phy0>, <&usb3_phy0>;
> > >  				phy-names = "usb2-phy", "usb3-
> phy";
> > >  				snps,dis-u2-freeclk-exists-quirk;
> >
> > So this property can be removed?
> 
> I'm not so sure about this one, as the description is talking about USB2
> PHY providing a free-running PHY clock. I don't know the details if this
> is true or not.
> But removing snps,dis-u2-freeclk-exists-quirk from both USB device nodes,
> USB devices attachments are still detected when the USB hub is suspended,
> both super-speed and high-speed ports.

With below change in driver:

-	if (dwc->dis_u2_freeclk_exists_quirk)
+	if (dwc->dis_u2_freeclk_exists_quirk || dwc->gfladj_refclk_lpm_sel)
 		reg &= ~DWC3_GUSB2PHYCFG_U2_FREECLK_EXISTS;

DWC3_GUSB2PHYCFG_U2_FREECLK_EXISTS bit can be cleared by new property
snps,gfladj-refclk-lpm-sel-quirk

Li Jun

> 
> Best regards,
> Alexander
> 
> > > +				snps,gfladj-refclk-lpm-sel-quirk;
> > >
> > >  			};
> > >
> > >  		};
> > >
> > > @@ -1342,6 +1343,7 @@ usb_dwc3_1: usb@38200000 {
> > >
> > >  				phys = <&usb3_phy1>, <&usb3_phy1>;
> > >  				phy-names = "usb2-phy", "usb3-
> phy";
> > >  				snps,dis-u2-freeclk-exists-quirk;
> >
> > Ditto.
> >
> > Li Jun
> >
> > > +				snps,gfladj-refclk-lpm-sel-quirk;
> > >
> > >  			};
> > >
> > >  		};
> > >
> > > --
> > > 2.25.1
> 
> 
> 

Re: [PATCH 0/4] USB host support for TQMa8MPxL + MBa8MPxL

[Greg Kroah-Hartman]

On Thu, Sep 08, 2022 at 09:07:06AM +0000, Jun Li wrote:
> Hi,
> 
> > -----Original Message-----
> > From: Alexander Stein <alexander.stein@ew.tq-group.com>
> > Sent: Thursday, September 8, 2022 1:50 PM
> > To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>; Rob Herring
> > <robh+dt@kernel.org>; Krzysztof Kozlowski
> > <krzysztof.kozlowski+dt@linaro.org>; Shawn Guo <shawnguo@kernel.org>;
> > Sascha Hauer <s.hauer@pengutronix.de>; Pengutronix Kernel Team
> > <kernel@pengutronix.de>; Fabio Estevam <festevam@gmail.com>; dl-linux-imx
> > <linux-imx@nxp.com>; Jun Li <jun.li@nxp.com>
> > Cc: linux-usb@vger.kernel.org; devicetree@vger.kernel.org;
> > linux-kernel@vger.kernel.org
> > Subject: RE: [PATCH 0/4] USB host support for TQMa8MPxL + MBa8MPxL
> > 
> > Hi,
> > 
> > Am Mittwoch, 7. September 2022, 18:08:25 CEST schrieb Jun Li:
> > > Hi
> > >
> > > > -----Original Message-----
> > > > From: Alexander Stein <alexander.stein@ew.tq-group.com>
> > > > Sent: Wednesday, September 7, 2022 10:46 PM
> > > > To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>; Rob Herring
> > > > <robh+dt@kernel.org>; Krzysztof Kozlowski
> > > > <krzysztof.kozlowski+dt@linaro.org>; Shawn Guo
> > > > <shawnguo@kernel.org>; Sascha Hauer <s.hauer@pengutronix.de>;
> > > > Pengutronix Kernel Team <kernel@pengutronix.de>; Fabio Estevam
> > > > <festevam@gmail.com>; dl-linux-imx <linux-imx@nxp.com>; Jun Li
> > > > <jun.li@nxp.com>
> > > > Cc: Alexander Stein <alexander.stein@ew.tq-group.com>;
> > > > linux-usb@vger.kernel.org; devicetree@vger.kernel.org;
> > > > linux-kernel@vger.kernel.org
> > > > Subject: [PATCH 0/4] USB host support for TQMa8MPxL + MBa8MPxL
> > > >
> > > > Hi everybody,
> > > >
> > > > this is a series based on the RFC at [1] for USB host support on
> > > > TQMa8MPxL
> > > > + MBa8MPxL. The main difference is that USB DR support has already
> > > > + been
> > > > added and has been removed from this series.
> > > >
> > > > The DT configuration itself (patch 4) is rather straight forward,
> > > > but leads
> > > >
> > > > to the following dmesg errors regarding superspeed ports:
> > > > > [    8.549243] hub 2-1:1.0: hub_ext_port_status failed (err = -110)
> > > > > [   22.885263] usb 2-1: Failed to suspend device, error -110
> > > >
> > > > This hardware works fine using the downstream kernel, because for
> > > > imx8mp this ITP sync feature is enabled conditionally [2] & [3].
> > > > Hacking this into mainline resulted in a working superspeed setup as
> > well.
> > > > I also noticed that on some android kernel [4] depending in IP core
> > > > version either GCTL.SOFTITPSYNC or GFLADJ.GFLADJ_REFCLK_LPM_SEL is
> > > > enabled unconditionally.
> > > > So I opted for the latter one using some quirk (patch 1-3).
> > > >
> > > > I have to admit I do not know what this is actually about, nor why
> > > > my setup does not work without this change or why this fixed my
> > > > problem. So maybe someone with more knowledge can say if this is the
> > > > way to go or what this is about.
> > >
> > > This can be updated:)
> > >
> > > > I also added snps,dis_u3_susphy_quirk to the board level as for some
> > > > reason USB Superspeed U3 does not work. Detecting the onboard hub
> > > > takes much longer and once all devices are diconnected from the hub
> > > > it is put into runtime suspend (U3) and new attached devices are not
> > > > detected at all.
> > > > Until the cause is known and fixed runtime suspend has to be disabled.
> > >
> > > For this issue you are reporting, I am not sure if this is caused by a
> > > USB clock change merged on v5.19, if you use latest kernel, can you
> > > try with below patches applied to see if U3 can work for you?
> > 
> > Awesome, This does the trick!
> > I was already running with patches [1] & [2], but was missing patch [3].
> > With all of them applied, USB detects a newly attached superspeed device
> > when the HUB is in runtime suspend (U3).
> 
> Yes, patch[3] needs to apply with patches [1]&[2], I am applying the
> same tag to make sure the 3 patches land on the same target release
> as they will go through diff maintainer's trees.

What "tag"?

And I'm confused as to the status of all of these, please resend the
series once you have a new version with the proper acked and reviewed-by
added.

thanks,

greg k-h

RE: [PATCH 0/4] USB host support for TQMa8MPxL + MBa8MPxL

[Jun Li]

Hi

> -----Original Message-----
> From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Sent: Friday, September 9, 2022 3:28 PM
> To: Jun Li <jun.li@nxp.com>
> Cc: Alexander Stein <alexander.stein@ew.tq-group.com>; Rob Herring
> <robh+dt@kernel.org>; Krzysztof Kozlowski
> <krzysztof.kozlowski+dt@linaro.org>; Shawn Guo <shawnguo@kernel.org>;
> Sascha Hauer <s.hauer@pengutronix.de>; Pengutronix Kernel Team
> <kernel@pengutronix.de>; Fabio Estevam <festevam@gmail.com>; dl-linux-imx
> <linux-imx@nxp.com>; linux-usb@vger.kernel.org;
> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH 0/4] USB host support for TQMa8MPxL + MBa8MPxL
> 
> On Thu, Sep 08, 2022 at 09:07:06AM +0000, Jun Li wrote:
> > Hi,
> >
> > > -----Original Message-----
> > > From: Alexander Stein <alexander.stein@ew.tq-group.com>
> > > Sent: Thursday, September 8, 2022 1:50 PM
> > > To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>; Rob Herring
> > > <robh+dt@kernel.org>; Krzysztof Kozlowski
> > > <krzysztof.kozlowski+dt@linaro.org>; Shawn Guo
> > > <shawnguo@kernel.org>; Sascha Hauer <s.hauer@pengutronix.de>;
> > > Pengutronix Kernel Team <kernel@pengutronix.de>; Fabio Estevam
> > > <festevam@gmail.com>; dl-linux-imx <linux-imx@nxp.com>; Jun Li
> > > <jun.li@nxp.com>
> > > Cc: linux-usb@vger.kernel.org; devicetree@vger.kernel.org;
> > > linux-kernel@vger.kernel.org
> > > Subject: RE: [PATCH 0/4] USB host support for TQMa8MPxL + MBa8MPxL
> > >
> > > Hi,
> > >
> > > Am Mittwoch, 7. September 2022, 18:08:25 CEST schrieb Jun Li:
> > > > Hi
> > > >
> > > > > -----Original Message-----
> > > > > From: Alexander Stein <alexander.stein@ew.tq-group.com>
> > > > > Sent: Wednesday, September 7, 2022 10:46 PM
> > > > > To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>; Rob Herring
> > > > > <robh+dt@kernel.org>; Krzysztof Kozlowski
> > > > > <krzysztof.kozlowski+dt@linaro.org>; Shawn Guo
> > > > > <shawnguo@kernel.org>; Sascha Hauer <s.hauer@pengutronix.de>;
> > > > > Pengutronix Kernel Team <kernel@pengutronix.de>; Fabio Estevam
> > > > > <festevam@gmail.com>; dl-linux-imx <linux-imx@nxp.com>; Jun Li
> > > > > <jun.li@nxp.com>
> > > > > Cc: Alexander Stein <alexander.stein@ew.tq-group.com>;
> > > > > linux-usb@vger.kernel.org; devicetree@vger.kernel.org;
> > > > > linux-kernel@vger.kernel.org
> > > > > Subject: [PATCH 0/4] USB host support for TQMa8MPxL + MBa8MPxL
> > > > >
> > > > > Hi everybody,
> > > > >
> > > > > this is a series based on the RFC at [1] for USB host support on
> > > > > TQMa8MPxL
> > > > > + MBa8MPxL. The main difference is that USB DR support has
> > > > > + already been
> > > > > added and has been removed from this series.
> > > > >
> > > > > The DT configuration itself (patch 4) is rather straight
> > > > > forward, but leads
> > > > >
> > > > > to the following dmesg errors regarding superspeed ports:
> > > > > > [    8.549243] hub 2-1:1.0: hub_ext_port_status failed (err = -110)
> > > > > > [   22.885263] usb 2-1: Failed to suspend device, error -110
> > > > >
> > > > > This hardware works fine using the downstream kernel, because
> > > > > for imx8mp this ITP sync feature is enabled conditionally [2] & [3].
> > > > > Hacking this into mainline resulted in a working superspeed
> > > > > setup as
> > > well.
> > > > > I also noticed that on some android kernel [4] depending in IP
> > > > > core version either GCTL.SOFTITPSYNC or
> > > > > GFLADJ.GFLADJ_REFCLK_LPM_SEL is enabled unconditionally.
> > > > > So I opted for the latter one using some quirk (patch 1-3).
> > > > >
> > > > > I have to admit I do not know what this is actually about, nor
> > > > > why my setup does not work without this change or why this fixed
> > > > > my problem. So maybe someone with more knowledge can say if this
> > > > > is the way to go or what this is about.
> > > >
> > > > This can be updated:)
> > > >
> > > > > I also added snps,dis_u3_susphy_quirk to the board level as for
> > > > > some reason USB Superspeed U3 does not work. Detecting the
> > > > > onboard hub takes much longer and once all devices are
> > > > > diconnected from the hub it is put into runtime suspend (U3) and
> > > > > new attached devices are not detected at all.
> > > > > Until the cause is known and fixed runtime suspend has to be disabled.
> > > >
> > > > For this issue you are reporting, I am not sure if this is caused
> > > > by a USB clock change merged on v5.19, if you use latest kernel,
> > > > can you try with below patches applied to see if U3 can work for you?
> > >
> > > Awesome, This does the trick!
> > > I was already running with patches [1] & [2], but was missing patch [3].
> > > With all of them applied, USB detects a newly attached superspeed
> > > device when the HUB is in runtime suspend (U3).
> >
> > Yes, patch[3] needs to apply with patches [1]&[2], I am applying the
> > same tag to make sure the 3 patches land on the same target release as
> > they will go through diff maintainer's trees.
> 
> What "tag"?

Sorry for the confusion, the "tag" mentioned here is not for this patch
set, but for another patch set sent from me, which can resolve one issue
this patch set reported.

I think Alexander will send a new version because at least one of patch(4/4 dts)
should be updated.

Li Jun
 
> 
> And I'm confused as to the status of all of these, please resend the series
> once you have a new version with the proper acked and reviewed-by added.
> 
> thanks,
> 
> greg k-h