RE: [EXT] [PATCH v2 12/38] media: platform: amphion: move config to its own file

[Shijie Qin <shijie.qin@nxp.com>]

> -----Original Message-----
> From: Mauro Carvalho Chehab <mchehab@kernel.org>
> Sent: Friday, March 11, 2022 10:07 PM
> Cc: Mauro Carvalho Chehab <mchehab@kernel.org>; Niklas Söderlund
> <niklas.soderlund+renesas@ragnatech.se>; Dmitry Osipenko
> <digetx@gmail.com>; Hans Verkuil <hverkuil-cisco@xs4all.nl>; Laurent
> Pinchart <laurent.pinchart@ideasonboard.com>; Ming Qian
> <ming.qian@nxp.com>; Shijie Qin <shijie.qin@nxp.com>; Eagle Zhou
> <eagle.zhou@nxp.com>; linux-kernel@vger.kernel.org; linux-
> media@vger.kernel.org
> Subject: [EXT] [PATCH v2 12/38] media: platform: amphion: move config to its
> own file
> 
> Caution: EXT Email
> 
> In order to better organize the platform/Kconfig, place amphion-specific
> config stuff on a separate Kconfig file.
> 
> Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
> Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
   Reviewed-by: Shijie Qin <shijie.qin@nxp.com>

> ---
> 
> To avoid mailbombing on a large number of people, only mailing lists were
> C/C on the cover.
> See [PATCH v2 00/38] at:
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.k
> ernel.org%2Fall%2Fcover.1647006877.git.mchehab%40kernel.org%2F&amp;d
> ata=04%7C01%7Cshijie.qin%40nxp.com%7C00b6f167648a4f003f8908da0368c
> 7c6%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637826045803762
> 164%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2lu
> MzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&amp;sdata=RHvKEtSj%2B9
> sffB4enxmXoP1FD3%2FQj0MPlDe2WjrjgLQ%3D&amp;reserved=0
> 
>  drivers/media/platform/Kconfig         | 21 +--------------------
>  drivers/media/platform/amphion/Kconfig | 20 ++++++++++++++++++++
>  2 files changed, 21 insertions(+), 20 deletions(-)  create mode 100644
> drivers/media/platform/amphion/Kconfig
> 
> diff --git a/drivers/media/platform/Kconfig
> b/drivers/media/platform/Kconfig index e795a0862841..25cfda75e625
> 100644
> --- a/drivers/media/platform/Kconfig
> +++ b/drivers/media/platform/Kconfig
> @@ -47,6 +47,7 @@ source "drivers/media/platform/marvell-ccic/Kconfig"
> 
>  source "drivers/media/platform/via/Kconfig"
> 
> +source "drivers/media/platform/amphion/Kconfig"
>  source "drivers/media/platform/cadence/Kconfig"
> 
>  source "drivers/media/platform/davinci/Kconfig"
> @@ -535,26 +536,6 @@ config VIDEO_TEGRA_VDE
>            Support for the NVIDIA Tegra video decoder unit.
>            To compile this driver as a module choose m here.
> 
> -config VIDEO_AMPHION_VPU
> -       tristate "Amphion VPU (Video Processing Unit) Codec IP"
> -       depends on V4L_MEM2MEM_DRIVERS
> -       depends on ARCH_MXC || COMPILE_TEST
> -       depends on MEDIA_SUPPORT
> -       depends on VIDEO_DEV
> -       depends on VIDEO_V4L2
> -       select MEDIA_CONTROLLER
> -       select V4L2_MEM2MEM_DEV
> -       select VIDEOBUF2_DMA_CONTIG
> -       select VIDEOBUF2_VMALLOC
> -       help
> -         Amphion VPU Codec IP contains two parts: Windsor and Malone.
> -         Windsor is encoder that supports H.264, and Malone is decoder
> -         that supports H.264, HEVC, and other video formats.
> -         This is a V4L2 driver for NXP MXC 8Q video accelerator hardware.
> -         It accelerates encoding and decoding operations on
> -         various NXP SoCs.
> -         To compile this driver as a module choose m here.
> -
>  # TI VIDEO PORT Helper Modules
>  # These will be selected by VPE and VIP  config VIDEO_TI_VPDMA diff --git
> a/drivers/media/platform/amphion/Kconfig
> b/drivers/media/platform/amphion/Kconfig
> new file mode 100644
> index 000000000000..13899649f766
> --- /dev/null
> +++ b/drivers/media/platform/amphion/Kconfig
> @@ -0,0 +1,20 @@
> +# SPDX-License-Identifier: GPL-2.0-only config VIDEO_AMPHION_VPU
> +       tristate "Amphion VPU (Video Processing Unit) Codec IP"
> +       depends on V4L_MEM2MEM_DRIVERS
> +       depends on ARCH_MXC || COMPILE_TEST
> +       depends on MEDIA_SUPPORT
> +       depends on VIDEO_DEV
> +       depends on VIDEO_V4L2
> +       select MEDIA_CONTROLLER
> +       select V4L2_MEM2MEM_DEV
> +       select VIDEOBUF2_DMA_CONTIG
> +       select VIDEOBUF2_VMALLOC
> +       help
> +         Amphion VPU Codec IP contains two parts: Windsor and Malone.
> +         Windsor is encoder that supports H.264, and Malone is decoder
> +         that supports H.264, HEVC, and other video formats.
> +         This is a V4L2 driver for NXP MXC 8Q video accelerator hardware.
> +         It accelerates encoding and decoding operations on
> +         various NXP SoCs.
> +         To compile this driver as a module choose m here.
> --
> 2.35.1