From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA0B6C07E9E for ; Thu, 8 Jul 2021 11:57:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7D45061184 for ; Thu, 8 Jul 2021 11:57:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231433AbhGHMAV (ORCPT ); Thu, 8 Jul 2021 08:00:21 -0400 Received: from mail-co1nam11on2068.outbound.protection.outlook.com ([40.107.220.68]:7137 "EHLO NAM11-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S231347AbhGHMAU (ORCPT ); Thu, 8 Jul 2021 08:00:20 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=G2zG1eTOhetsc9gwd/eKSZpjszvlX/NnWp1Iu015lkg4b97kV3iGRZjFl/Ho12x8lLY9nrA+PJP3gDBFCGb5H3z9n1KJrbPMWP7wVsl/abKgbsp/5l1qZ2tK4rRAFbsx367OydurA91N1owI3zib1SF7soVyJVqDqgn/oQKqn+w6btQq2/b7YV9+O6h686dlHthfq06M+hiQaFpKP9d6AwKpEGfR8TGS9ZCxJ7gq7zXhdwnDCRbOzQGkakFHfs78vrbN2rFYQva5b868BU0Hh1FS/H/R1rSBKHIc05UkdDWMvq4hMXXqNQfkvsP+L5jg2/e7QQE/RgHgSmF64m7Nyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5CYLwSl0IjE+IELV6toVTN9lSkCt20i9KJqwoJ4/E0Y=; b=Uj7msGVitvfZYldzkvs4/eaomWsZt4ffsgLhzyvUapJcPFZ1VIhCHtC8Qi0ASRg0M4VUtBo+A0O/lb6xev+Wh/3xrJ4dKjZ4E/dm2Zv2enqkdsKbA88RMyP7nLaECl8IZH6g5Q1ccfL81ryaXxFrS5aKqdvsWc9GbLVcVHYFo4k2R+JPIo1Kpi98IHtJbLaeUcVYE0VtgreEhHyl+MT1Av6P+sIBENbnylt8jEBt8o5pDyVg7B6SJK8iNyXiohNLvnLIrMYXj86X//Ts2C5io6jwcWvJp7AVJIC7MC1bBpEEddct0Pm16Xc3L68pvm4/vel+uSjj43StU4bj43Ca5A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=xilinx.com; dmarc=pass action=none header.from=xilinx.com; dkim=pass header.d=xilinx.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5CYLwSl0IjE+IELV6toVTN9lSkCt20i9KJqwoJ4/E0Y=; b=R3Njf70NQU5r6OPc/4Sds6dlKvUZDhC9v9oxC8KjbmDV+SZkD12rVdyuCQVgl6Dlo3Yf0dxghu1t7CUmMrYd+OHtPcNLSZFqEcgpxaHHImAfouhEDdH274NlYayqTK4Tn9iPCmYKW4KQjEtTRxa+hytI7f4dFyASWq1M8mJWgHY= Received: from PH0PR02MB7336.namprd02.prod.outlook.com (2603:10b6:510:d::6) by PH0PR02MB7414.namprd02.prod.outlook.com (2603:10b6:510:1f::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4308.22; Thu, 8 Jul 2021 11:57:33 +0000 Received: from PH0PR02MB7336.namprd02.prod.outlook.com ([fe80::a8bd:e49f:7daf:fb1e]) by PH0PR02MB7336.namprd02.prod.outlook.com ([fe80::a8bd:e49f:7daf:fb1e%9]) with mapi id 15.20.4287.035; Thu, 8 Jul 2021 11:57:33 +0000 From: Nava kishore Manne To: Tom Rix , "robh+dt@kernel.org" , Michal Simek , "mdf@kernel.org" , "arnd@arndb.de" , Rajan Vaja , "gregkh@linuxfoundation.org" , Amit Sunil Dhamne , Tejas Patel , "zou_wei@huawei.com" , Sai Krishna Potthuri , Ravi Patel , "iwamatsu@nigauri.org" , Jiaying Liang , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-fpga@vger.kernel.org" , git , "chinnikishore369@gmail.com" CC: Appana Durga Kedareswara Rao Subject: RE: [PATCH v8 5/5] fpga: versal-fpga: Add versal fpga manager driver Thread-Topic: [PATCH v8 5/5] fpga: versal-fpga: Add versal fpga manager driver Thread-Index: AQHXaqNsfadVFn7cU0OetyaN3QeZd6s2iBUAgAJ6vaA= Date: Thu, 8 Jul 2021 11:57:33 +0000 Message-ID: References: <20210626155248.5004-1-nava.manne@xilinx.com> <20210626155248.5004-6-nava.manne@xilinx.com> <4429c722-52f3-2e16-3a53-910345507d3e@redhat.com> In-Reply-To: <4429c722-52f3-2e16-3a53-910345507d3e@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-TNEF-Correlator: authentication-results: redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=xilinx.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 340f7c7c-e483-4f86-ebb9-08d942079213 x-ms-traffictypediagnostic: PH0PR02MB7414: x-ld-processed: 657af505-d5df-48d0-8300-c31994686c5c,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3173; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 3BCkJuWXebAS/smEd3VcUN20nDymo9E0K/ZbYc6V704jJH5JhYi7svmUv8WaNxevyVdEbWlxBdtNVK3HBMeulXMuubdAhIRnnL73LTeRU6ppGvUpXsnadiy4RMLhccdjAuChPop72RplBWGy5G0UcptKCpkz2qXzNjoTbU9VtMWwrsILDM2sdqT9FojQ9Gi/P3+CyyYAHVR/lHspJ0ejXHD0qRsfdp7kk2q4ESXj2WNhPJIBuvrd3jwPexgNuCqubmUOr6d3PDhGiLojTg7QPw+B05R9MjYw9sz+3dl2kT0uzH09DcDgdPSJTi8IUNGUm6dndFrPctov5ubyt2Nl0QeVoyn6DIFA4C7P1Hitde9MDCCh86yPcuKgNT6mNXS/EMc0e7Q7bIW2RbmJW4vT+3QuvMfF44qFLmTjDKsch6eKi5bPKPxrXaUjRXCG7TFpJDjo60lCpTsa/QYZIYJbDN912GfPtLpOGf6+RNNGq2ihIBZc7USPy1xYORIu3z82AluTnbuSkJQK1yDpueM5NGSVaUSLOJbi8UryV7uLkD4LKsgxOCQlNHqmswMmkhtYea/FvA1Z/Dl88aFrtJvFvhcqpdNxLIIgYkBZPdySPKKSloxThMnX5uOizj8S3lhfPTF0LmfSc5E+LRrrUbCR8JO7uUyy8x/1kb9WPw0HitC41CxjY/M4pnU84X/LiykTGkNOP5KM8Ymon2JqEX97aQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR02MB7336.namprd02.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(39860400002)(366004)(136003)(376002)(346002)(2906002)(8676002)(55016002)(8936002)(76116006)(122000001)(921005)(71200400001)(38100700002)(5660300002)(186003)(9686003)(6506007)(53546011)(26005)(52536014)(478600001)(83380400001)(86362001)(66446008)(66556008)(110136005)(4326008)(7696005)(64756008)(66946007)(66476007)(33656002)(107886003)(7416002)(316002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?SGoxQ2NzV21yZzE4Qis0TXRCNUtvWnQ0M2N1MUhRQTQ5SXB5THBVc1c0Sk1G?= =?utf-8?B?M2xDY2w1TlhYZlNiZW16bU5TdnI5QnFHYnFmMDlDQUZtYkZOKzJJRXR1RFR2?= =?utf-8?B?dG5CWWdDb0pzWGZBV21HZm9reWFMemNpeG1zWlBiVXo3a2prMi84SHNFcUhy?= =?utf-8?B?bW9qYzAyRkt5NXRseDE3eEIyelFrMVVQUUNPdFVUZkxUN1BNT1VIWjZhWWxG?= =?utf-8?B?TXMyWWJOUE8zQnZ3U0ZuTEVEUXd5V3Awc0pZTGxRcTc5RmtibUxFdEtKUzl3?= =?utf-8?B?dnpLTEdIMkd6bEl0bUFHbUljTlExSlg0UUYyY1U5RmVhRDJ1Rnpqc1lMTURu?= =?utf-8?B?djdzZmIrTmdBcFMweGNJN1BZY0NJUXJRSDhXNnBnMUVRd3hVSlQ2Ry9jSmNm?= =?utf-8?B?SmVIYXJGenIxaER0UmtCVk5COVRMVGVmYmdMUG1CaGdyTmVTeXN4ckJwL1Zz?= =?utf-8?B?NFg0U0VMcWg4eTExU2k2VVlpRU84NG9QaHBwT0VKekhwTkQ3RUNmenhPM3Ev?= =?utf-8?B?L1NENDA5c2U4UzhWRTRaK1BPc2Y3ZDhTSUtkUjdQYXYraXVwcm5sVGVHaXA3?= =?utf-8?B?RmFXYTdsUW5QODRqNXZjOFB5NjRGdXU2R1JVWHI5MFJ3ZkVCR01vMVZOakpU?= =?utf-8?B?ODZpTENVQ0pzYnc5dVM5OFNLS0tjT0xZMTU5SzdOd0huQTRCWk5wZ1ZOM2JO?= =?utf-8?B?UE9sakZXK0xuYS9HVlp5NnZsci9jczdaM0JQK25DYjJkT3oyWjErT0VLcmdL?= =?utf-8?B?V0R2b01DQWg2TG5KRU03TzFhNGwxdHcyWk4rcWJ6ZjZDajg1SjVVTm8xcXo4?= =?utf-8?B?bTdZcjZJVWFRZlZNODFZTWkwNmNCY1NWUWRoYXYxalFUaHd6a1ovdnpXQTc5?= =?utf-8?B?ZEc3K0hCbThUYzRZTHc5SXVEbStNMkVQTytsOTJYSHlXajdLZVkyQXpPWUUz?= =?utf-8?B?OWViSFRGQlhEOCtRRzVoL0FCQ2JGQlpLQ1BpVEVkUVFXNGZtK3RBdmVLVmdi?= =?utf-8?B?UkNzOUdvbldRS3F3SklxV3ZJdWVKclpyd1pEdDNCb0p5NGpicmkwemp2SXJh?= =?utf-8?B?RlBFdmVWWGo0c1BZRzBkUnNUS3F6bC92NVJTRGhpb1FqUEQwZzFlRlljT2g3?= =?utf-8?B?M1hSalFHZ3VnNnRQTkRDdmxKdG44bnQxTENBZW9YY2xDeERKbUFOLzl6akRF?= =?utf-8?B?cHpTcDAyMVJ0RmJTQjhXNkdIMmFxTm9pSGdaN2g4WWxsbC8rSVVnUEYrQkJD?= =?utf-8?B?QVNwbXhwWTZpejA1ZXdRRkM0YWZOOGxVTVhEM2t4UE5yc2tNWjRmNVp1Skt1?= =?utf-8?B?MVZZUy9jcm1BYWU4T0ZPL0Z4QTJObDZFWGVkSW5IeHY1VnIwT0VnQWlvVWp2?= =?utf-8?B?ZWY2cm1xNmFNeEFTMGhqbVlxRVhXdHVsWFJxMG9sM1lJaFo4dURRWkw1YzFi?= =?utf-8?B?dERmVVFjMFNITHlUQm0wRWE1VzlpemVCdUxFZWxId240WkFTREE2SVptUEVw?= =?utf-8?B?d1Fhb0hJVnZwVzAzbjJUTVVSRm45cDlkaUQ0NzBrUFdmVm9Bclg1alZySkhh?= =?utf-8?B?L2dnakNYbkhxWGdhYkxKNFNCN05FSGxDRXFkZnJEanZiU2F2THJsU2xKUnI4?= =?utf-8?B?akdCMEhGUjMrQ2I3UUlRcEVpTzJaRndtMlpwc1N3eGFtYUhTb1E2c1NrTjlt?= =?utf-8?B?VDUrdnBsbGREQmwvWmUvaC93WTNTUFFiOW8wa1ZZOWRrOFY5NlFaR1lxdkdN?= =?utf-8?Q?0d6loeTqa1ln4XeI3Thauto51jwtr/606hXviWG?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7336.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 340f7c7c-e483-4f86-ebb9-08d942079213 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Jul 2021 11:57:33.0707 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Q/rdFijLvZotD4VL3QS52q7twvL18kT0j9MCxSVpe5hctmWEJzeq3jFvsHSH4f98FY/hkkzPvq5p0OupPa6sbw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR02MB7414 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org SGkgVG9tLA0KDQoJUGxlYXNlIGZpbmQgbXkgcmVzcG9uc2UgaW5saW5lLg0KDQo+IC0tLS0tT3Jp Z2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IFRvbSBSaXggPHRyaXhAcmVkaGF0LmNvbT4NCj4g U2VudDogV2VkbmVzZGF5LCBKdWx5IDcsIDIwMjEgMzowNCBBTQ0KPiBUbzogTmF2YSBraXNob3Jl IE1hbm5lIDxuYXZhbUB4aWxpbnguY29tPjsgcm9iaCtkdEBrZXJuZWwub3JnOyBNaWNoYWwNCj4g U2ltZWsgPG1pY2hhbHNAeGlsaW54LmNvbT47IG1kZkBrZXJuZWwub3JnOyBhcm5kQGFybmRiLmRl OyBSYWphbiBWYWphDQo+IDxSQUpBTlZAeGlsaW54LmNvbT47IGdyZWdraEBsaW51eGZvdW5kYXRp b24ub3JnOyBBbWl0IFN1bmlsIERoYW1uZQ0KPiA8YW1pdHN1bmlAeGxueC54aWxpbnguY29tPjsg VGVqYXMgUGF0ZWwgPHRlamFzcEB4bG54LnhpbGlueC5jb20+Ow0KPiB6b3Vfd2VpQGh1YXdlaS5j b207IFNhaSBLcmlzaG5hIFBvdHRodXJpIDxsYWtzaG1pc0B4aWxpbnguY29tPjsgUmF2aQ0KPiBQ YXRlbCA8cmF2aXBhdGVAeGxueC54aWxpbnguY29tPjsgaXdhbWF0c3VAbmlnYXVyaS5vcmc7IEpp YXlpbmcgTGlhbmcNCj4gPGpsaWFuZ0B4aWxpbnguY29tPjsgZGV2aWNldHJlZUB2Z2VyLmtlcm5l bC5vcmc7IGxpbnV4LWFybS0NCj4ga2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmc7IGxpbnV4LWtl cm5lbEB2Z2VyLmtlcm5lbC5vcmc7IGxpbnV4LQ0KPiBmcGdhQHZnZXIua2VybmVsLm9yZzsgZ2l0 IDxnaXRAeGlsaW54LmNvbT47IGNoaW5uaWtpc2hvcmUzNjlAZ21haWwuY29tDQo+IENjOiBBcHBh bmEgRHVyZ2EgS2VkYXJlc3dhcmEgUmFvIDxhcHBhbmFkQHhpbGlueC5jb20+DQo+IFN1YmplY3Q6 IFJlOiBbUEFUQ0ggdjggNS81XSBmcGdhOiB2ZXJzYWwtZnBnYTogQWRkIHZlcnNhbCBmcGdhIG1h bmFnZXIgZHJpdmVyDQo+IA0KPiANCj4gT24gNi8yNi8yMSA4OjUyIEFNLCBOYXZhIGtpc2hvcmUg TWFubmUgd3JvdGU6DQo+ID4gQWRkIHN1cHBvcnQgZm9yIFhpbGlueCBWZXJzYWwgRlBHQSBtYW5h Z2VyLg0KPiA+DQo+ID4gUERJIHNvdXJjZSB0eXBlIGNhbiBiZSBERFIsIE9DTSwgUVNQSSBmbGFz aCBldGMuLg0KPiA+IEJ1dCBkcml2ZXIgYWxsb2NhdGVzIG1lbW9yeSBhbHdheXMgZnJvbSBERFIs IFNpbmNlIGRyaXZlciBzdXBwb3J0cw0KPiA+IG9ubHkgRERSIHNvdXJjZSB0eXBlLg0KPiA+DQo+ ID4gU2lnbmVkLW9mZi1ieTogQXBwYW5hIER1cmdhIEtlZGFyZXN3YXJhIHJhbw0KPiA+IDxhcHBh bmEuZHVyZ2EucmFvQHhpbGlueC5jb20+DQo+ID4gU2lnbmVkLW9mZi1ieTogTmF2YSBraXNob3Jl IE1hbm5lIDxuYXZhLm1hbm5lQHhpbGlueC5jb20+DQo+ID4gUmV2aWV3ZWQtYnk6IE1vcml0eiBG aXNjaGVyIDxtZGZAa2VybmVsLm9yZz4NCj4gPiAtLS0NCj4gPiBDaGFuZ2VzIGZvciB2MjoNCj4g PiAgICAgICAgICAgICAgICAtVXBkYXRlZCB0aGUgRnBnYSBNZ3IgcmVnaXN0cmF0aW9ucyBjYWxs J3MNCj4gPiAgICAgICAgICAgICAgICAgdG8gNS4xMQ0KPiA+ICAgICAgICAgICAgICAgIC1GaXhl ZCBzb21lIG1pbm9yIGNvZGluZyBpc3N1ZXMgYXMgc3VnZ2VzdGVkIGJ5DQo+ID4gICAgICAgICAg ICAgICAgIE1vcml0ei4NCj4gPg0KPiA+IENoYW5nZXMgZm9yIHYzOg0KPiA+ICAgICAgICAgICAg ICAgIC1SZXdyaXR0ZW4gdGhlIFZlcnNhbCBmcGdhIEtjb25maWcgY29udGVudHMuDQo+ID4NCj4g PiBDaGFuZ2VzIGZvciB2NDoNCj4gPiAgICAgICAgICAgICAgICAtUmViYXNlZCB0aGUgY2hhbmdl cyBvbiBsaW51eC1uZXh0Lg0KPiA+ICAgICAgICAgICAgICAgICBObyBmdW5jdGlvbmFsIGNoYW5n ZXMuDQo+ID4NCj4gPiBDaGFuZ2VzIGZvciB2NToNCj4gPiAgICAgICAgICAgICAgICAtTm9uZS4N Cj4gPg0KPiA+IENoYW5nZXMgZm9yIHY2Og0KPiA+ICAgICAgICAgICAgICAgIC1Ob25lLg0KPiA+ DQo+ID4gQ2hhbmdlcyBmb3Igdjc6DQo+ID4gICAgICAgICAgICAgICAgLVVwZGF0ZWQgZHJpdmVy IHRvIHJlbW92ZSB1bndhdGVkIHByaXYgc3RydWN0IGRlcGVuZGVuY3kuDQo+ID4NCj4gPiBDaGFu Z2VzIGZvciB2ODoNCj4gPiAgICAgICAgICAgICAgICAtTm9uZS4NCj4gPg0KPiA+ICAgZHJpdmVy cy9mcGdhL0tjb25maWcgICAgICAgfCAgOSArKysrDQo+ID4gICBkcml2ZXJzL2ZwZ2EvTWFrZWZp bGUgICAgICB8ICAxICsNCj4gPiAgIGRyaXZlcnMvZnBnYS92ZXJzYWwtZnBnYS5jIHwgOTYNCj4g KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysNCj4gPiAgIDMgZmlsZXMgY2hh bmdlZCwgMTA2IGluc2VydGlvbnMoKykNCj4gPiAgIGNyZWF0ZSBtb2RlIDEwMDY0NCBkcml2ZXJz L2ZwZ2EvdmVyc2FsLWZwZ2EuYw0KPiA+DQo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZnBnYS9L Y29uZmlnIGIvZHJpdmVycy9mcGdhL0tjb25maWcgaW5kZXgNCj4gPiA4Y2Q0NTRlZTIwYzAuLjE2 NzkzYmZjMmJiNCAxMDA2NDQNCj4gPiAtLS0gYS9kcml2ZXJzL2ZwZ2EvS2NvbmZpZw0KPiA+ICsr KyBiL2RyaXZlcnMvZnBnYS9LY29uZmlnDQo+ID4gQEAgLTIzNCw0ICsyMzQsMTMgQEAgY29uZmln IEZQR0FfTUdSX1pZTlFNUF9GUEdBDQo+ID4gICAJICB0byBjb25maWd1cmUgdGhlIHByb2dyYW1t YWJsZSBsb2dpYyhQTCkgdGhyb3VnaCBQUw0KPiA+ICAgCSAgb24gWnlucU1QIFNvQy4NCj4gPg0K PiA+ICtjb25maWcgRlBHQV9NR1JfVkVSU0FMX0ZQR0ENCj4gPiArCXRyaXN0YXRlICJYaWxpbngg VmVyc2FsIEZQR0EiDQo+ID4gKwlkZXBlbmRzIG9uIEFSQ0hfWllOUU1QIHx8IENPTVBJTEVfVEVT VA0KPiBTaG91bGRuJ3QgdGhpcyBkZXBlbmQgb24gWllOUU1QX0ZJUk1XQVJFID8NCg0KWWVzIGl0 IGhhcyBhIGRlcGVuZGVuY3ksIHdpbGwgZml4DQoNCj4gPiArCWhlbHANCj4gPiArCSAgU2VsZWN0 IHRoaXMgb3B0aW9uIHRvIGVuYWJsZSBGUEdBIG1hbmFnZXIgZHJpdmVyIHN1cHBvcnQgZm9yDQo+ ID4gKwkgIFhpbGlueCBWZXJzYWwgU29DLiBUaGlzIGRyaXZlciB1c2VzIHRoZSBmaXJtd2FyZSBp bnRlcmZhY2UgdG8NCj4gPiArCSAgY29uZmlndXJlIHRoZSBwcm9ncmFtbWFibGUgbG9naWMoUEwp Lg0KPiA+ICsNCj4gPiArCSAgVG8gY29tcGlsZSB0aGlzIGFzIGEgbW9kdWxlLCBjaG9vc2UgTSBo ZXJlLg0KPiA+ICAgZW5kaWYgIyBGUEdBDQo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZnBnYS9N YWtlZmlsZSBiL2RyaXZlcnMvZnBnYS9NYWtlZmlsZSBpbmRleA0KPiA+IDE4ZGM5ODg1ODgzYS4u MGJmZjc4M2QxYjYxIDEwMDY0NA0KPiA+IC0tLSBhL2RyaXZlcnMvZnBnYS9NYWtlZmlsZQ0KPiA+ ICsrKyBiL2RyaXZlcnMvZnBnYS9NYWtlZmlsZQ0KPiA+IEBAIC0xOCw2ICsxOCw3IEBAIG9iai0k KENPTkZJR19GUEdBX01HUl9UUzczWFgpCQkrPQ0KPiB0czczeHgtZnBnYS5vDQo+ID4gICBvYmot JChDT05GSUdfRlBHQV9NR1JfWElMSU5YX1NQSSkJKz0geGlsaW54LXNwaS5vDQo+ID4gICBvYmot JChDT05GSUdfRlBHQV9NR1JfWllOUV9GUEdBKQkrPSB6eW5xLWZwZ2Eubw0KPiA+ICAgb2JqLSQo Q09ORklHX0ZQR0FfTUdSX1pZTlFNUF9GUEdBKQkrPSB6eW5xbXAtZnBnYS5vDQo+ID4gK29iai0k KENPTkZJR19GUEdBX01HUl9WRVJTQUxfRlBHQSkgICAgICArPSB2ZXJzYWwtZnBnYS5vDQo+IFRo ZSBvdGhlciBDT05GSUdfRlBHQV9NR1IqIGNvbmZpZ3MgYXJlIGFscGhhYmV0aWNhbCwgdmVyc2Fs IHNob3VsZA0KPiBmb2xsb3cuDQoNCldpbGwgZml4Lg0KDQo+ID4gICBvYmotJChDT05GSUdfQUxU RVJBX1BSX0lQX0NPUkUpICAgICAgICAgKz0gYWx0ZXJhLXByLWlwLWNvcmUubw0KPiA+ICAgb2Jq LSQoQ09ORklHX0FMVEVSQV9QUl9JUF9DT1JFX1BMQVQpICAgICs9IGFsdGVyYS1wci1pcC1jb3Jl LXBsYXQubw0KPiA+DQo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZnBnYS92ZXJzYWwtZnBnYS5j IGIvZHJpdmVycy9mcGdhL3ZlcnNhbC1mcGdhLmMNCj4gPiBuZXcgZmlsZSBtb2RlIDEwMDY0NCBp bmRleCAwMDAwMDAwMDAwMDAuLjFiZDMxMmEzMWIyMw0KPiA+IC0tLSAvZGV2L251bGwNCj4gPiAr KysgYi9kcml2ZXJzL2ZwZ2EvdmVyc2FsLWZwZ2EuYw0KPiA+IEBAIC0wLDAgKzEsOTYgQEANCj4g PiArLy8gU1BEWC1MaWNlbnNlLUlkZW50aWZpZXI6IEdQTC0yLjANCj4gPiArLyoNCj4gPiArICog Q29weXJpZ2h0IChDKSAyMDE5LTIwMjEgWGlsaW54LCBJbmMuDQo+ID4gKyAqLw0KPiA+ICsNCj4g PiArI2luY2x1ZGUgPGxpbnV4L2RtYS1tYXBwaW5nLmg+DQo+ID4gKyNpbmNsdWRlIDxsaW51eC9m cGdhL2ZwZ2EtbWdyLmg+DQo+ID4gKyNpbmNsdWRlIDxsaW51eC9pby5oPg0KPiA+ICsjaW5jbHVk ZSA8bGludXgva2VybmVsLmg+DQo+ID4gKyNpbmNsdWRlIDxsaW51eC9tb2R1bGUuaD4NCj4gPiAr I2luY2x1ZGUgPGxpbnV4L29mX2FkZHJlc3MuaD4NCj4gPiArI2luY2x1ZGUgPGxpbnV4L3N0cmlu Zy5oPg0KPiA+ICsjaW5jbHVkZSA8bGludXgvZmlybXdhcmUveGxueC16eW5xbXAuaD4NCj4gPiAr DQo+ID4gK3N0YXRpYyBpbnQgdmVyc2FsX2ZwZ2Ffb3BzX3dyaXRlX2luaXQoc3RydWN0IGZwZ2Ff bWFuYWdlciAqbWdyLA0KPiA+ICsJCQkJICAgICAgc3RydWN0IGZwZ2FfaW1hZ2VfaW5mbyAqaW5m bywNCj4gPiArCQkJCSAgICAgIGNvbnN0IGNoYXIgKmJ1Ziwgc2l6ZV90IHNpemUpIHsNCj4gPiAr CXJldHVybiAwOw0KPiA+ICt9DQo+ID4gKw0KPiBUaGVzZSBlbXB0eSBvcHMgc2hvdWxkIGdvIGF3 YXkgd2l0aCBteSB3cmFwcGVycyBwYXRjaHNldA0KDQpPbmNlIHlvdXIgcGF0Y2hlcyBnb3QgaW50 ZWdyYXRlZCB3aWxsIHBvc3Qgb25lIG1vcmUgcGF0Y2ggdG8gcmVtb3ZlIHRoaXMgZW1wdHkgb3Bz Lg0KDQo+ID4gK3N0YXRpYyBpbnQgdmVyc2FsX2ZwZ2Ffb3BzX3dyaXRlKHN0cnVjdCBmcGdhX21h bmFnZXIgKm1nciwNCj4gPiArCQkJCSBjb25zdCBjaGFyICpidWYsIHNpemVfdCBzaXplKQ0KPiA+ ICt7DQo+ID4gKwlkbWFfYWRkcl90IGRtYV9hZGRyID0gMDsNCj4gPiArCWNoYXIgKmtidWY7DQo+ ID4gKwlpbnQgcmV0Ow0KPiA+ICsNCj4gPiArCWtidWYgPSBkbWFfYWxsb2NfY29oZXJlbnQobWdy LT5kZXYucGFyZW50LCBzaXplLCAmZG1hX2FkZHIsDQo+IEdGUF9LRVJORUwpOw0KPiA+ICsJaWYg KCFrYnVmKQ0KPiA+ICsJCXJldHVybiAtRU5PTUVNOw0KPiA+ICsNCj4gPiArCW1lbWNweShrYnVm LCBidWYsIHNpemUpOw0KPiA+ICsJcmV0ID0genlucW1wX3BtX2xvYWRfcGRpKFBESV9TUkNfRERS LCBkbWFfYWRkcik7DQo+IHdoeSBpc24ndCB0aGUgc2l6ZSBwYXNzZWQgPw0KDQoNClNpemUgaXMg cGFydCBvZiBQREkgaW1hZ2VzIGhlYWRlciB1c2VycyBubyBuZWVkIHRvIHBhc3MgdGhpcyBpbmZv IGV4cGxpY2l0bHkuDQoNCj4gPiArCWRtYV9mcmVlX2NvaGVyZW50KG1nci0+ZGV2LnBhcmVudCwg c2l6ZSwga2J1ZiwgZG1hX2FkZHIpOw0KPiA+ICsNCj4gPiArCXJldHVybiByZXQ7DQo+ID4gK30N Cj4gPiArDQo+ID4gK3N0YXRpYyBpbnQgdmVyc2FsX2ZwZ2Ffb3BzX3dyaXRlX2NvbXBsZXRlKHN0 cnVjdCBmcGdhX21hbmFnZXIgKm1nciwNCj4gPiArCQkJCQkgIHN0cnVjdCBmcGdhX2ltYWdlX2lu Zm8gKmluZm8pDQo+ID4gK3sNCj4gPiArCXJldHVybiAwOw0KPiA+ICt9DQo+ID4gKw0KPiA+ICtz dGF0aWMgZW51bSBmcGdhX21ncl9zdGF0ZXMgdmVyc2FsX2ZwZ2Ffb3BzX3N0YXRlKHN0cnVjdCBm cGdhX21hbmFnZXINCj4gPiArKm1ncikgew0KPiA+ICsJcmV0dXJuIEZQR0FfTUdSX1NUQVRFX1VO S05PV047DQo+ID4gK30NCj4gPiArDQo+ID4gK3N0YXRpYyBjb25zdCBzdHJ1Y3QgZnBnYV9tYW5h Z2VyX29wcyB2ZXJzYWxfZnBnYV9vcHMgPSB7DQo+ID4gKwkuc3RhdGUgPSB2ZXJzYWxfZnBnYV9v cHNfc3RhdGUsDQo+ID4gKwkud3JpdGVfaW5pdCA9IHZlcnNhbF9mcGdhX29wc193cml0ZV9pbml0 LA0KPiA+ICsJLndyaXRlID0gdmVyc2FsX2ZwZ2Ffb3BzX3dyaXRlLA0KPiA+ICsJLndyaXRlX2Nv bXBsZXRlID0gdmVyc2FsX2ZwZ2Ffb3BzX3dyaXRlX2NvbXBsZXRlLCB9Ow0KPiA+ICsNCj4gPiAr c3RhdGljIGludCB2ZXJzYWxfZnBnYV9wcm9iZShzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2 KSB7DQo+ID4gKwlzdHJ1Y3QgZGV2aWNlICpkZXYgPSAmcGRldi0+ZGV2Ow0KPiA+ICsJc3RydWN0 IGZwZ2FfbWFuYWdlciAqbWdyOw0KPiA+ICsJaW50IHJldDsNCj4gPiArDQo+ID4gKwlyZXQgPSBk bWFfc2V0X21hc2tfYW5kX2NvaGVyZW50KCZwZGV2LT5kZXYsDQo+IERNQV9CSVRfTUFTSygzMikp Ow0KPiA+ICsJaWYgKHJldCA8IDApIHsNCj4gPiArCQlkZXZfZXJyKGRldiwgIm5vIHVzYWJsZSBE TUEgY29uZmlndXJhdGlvblxuIik7DQo+ID4gKwkJcmV0dXJuIHJldDsNCj4gPiArCX0NCj4gPiAr DQo+ID4gKwltZ3IgPSBkZXZtX2ZwZ2FfbWdyX2NyZWF0ZShkZXYsICJYaWxpbnggVmVyc2FsIEZQ R0EgTWFuYWdlciIsDQo+ID4gKwkJCQkgICAmdmVyc2FsX2ZwZ2Ffb3BzLCBOVUxMKTsNCj4gPiAr CWlmICghbWdyKQ0KPiA+ICsJCXJldHVybiAtRU5PTUVNOw0KPiA+ICsNCj4gPiArCXJldHVybiBk ZXZtX2ZwZ2FfbWdyX3JlZ2lzdGVyKGRldiwgbWdyKTsgfQ0KPiA+ICsNCj4gPiArc3RhdGljIGNv bnN0IHN0cnVjdCBvZl9kZXZpY2VfaWQgdmVyc2FsX2ZwZ2Ffb2ZfbWF0Y2hbXSA9IHsNCj4gPiAr CXsgLmNvbXBhdGlibGUgPSAieGxueCx2ZXJzYWwtZnBnYSIsIH0sDQo+ID4gKwl7fSwNCj4gPiAr fTsNCj4gPiArTU9EVUxFX0RFVklDRV9UQUJMRShvZiwgdmVyc2FsX2ZwZ2Ffb2ZfbWF0Y2gpOw0K PiBuZWVkcyAjaWYgZGVmaW5lZChDT05GSUdfT0YpIHdyYXBwZXINCg0KV2lsbCBmaXguDQoNCj4g PiArDQo+ID4gK3N0YXRpYyBzdHJ1Y3QgcGxhdGZvcm1fZHJpdmVyIHZlcnNhbF9mcGdhX2RyaXZl ciA9IHsNCj4gPiArCS5wcm9iZSA9IHZlcnNhbF9mcGdhX3Byb2JlLA0KPiA+ICsJLmRyaXZlciA9 IHsNCj4gPiArCQkubmFtZSA9ICJ2ZXJzYWxfZnBnYV9tYW5hZ2VyIiwNCj4gPiArCQkub2ZfbWF0 Y2hfdGFibGUgPSBvZl9tYXRjaF9wdHIodmVyc2FsX2ZwZ2Ffb2ZfbWF0Y2gpLA0KPiA+ICsJfSwN Cj4gPiArfTsNCj4gPiArbW9kdWxlX3BsYXRmb3JtX2RyaXZlcih2ZXJzYWxfZnBnYV9kcml2ZXIp Ow0KPiA+ICsNCj4gPiArTU9EVUxFX0FVVEhPUigiTmF2YSBraXNob3JlIE1hbm5lIDxuYXZhLm1h bm5lQHhpbGlueC5jb20+Iik7DQo+ID4gK01PRFVMRV9BVVRIT1IoIkFwcGFuYSBEdXJnYSBLZWRh cmVzd2FyYSByYW8NCj4gPiArPGFwcGFuYWQuZHVyZ2EucmFvQHhpbGlueC5jb20+Iik7DQo+IA0K PiBSYW8gLSBuZWVkcyB0byBiZSBjYXBpdGFsaXplZCA/DQo+IA0KDQpXaWxsIGZpeC4NCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82CDEC07E96 for ; Thu, 8 Jul 2021 11:59:23 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4E56F61184 for ; Thu, 8 Jul 2021 11:59:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4E56F61184 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=xilinx.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vfWzya3Os5PQzcJysB/z1/nxUCSbRc1y1WszpWfNi3s=; b=LMpFih70rKJaw9 bQq5+z5lLnGBG77jivGoKaTaN1OKmP7I79U2/2oI+P/EPMldYcAwPnVBr8cgEMOUGANoh5rZYbRFr A18snssyUBN3qZhqUMzTngHmKExHcDABj5l1uoW5l4J7SqlVWh+DKjij0bmoEFJhOqqKvdm8u97VU WCkhU469ZdEdcb53a8f4EBqXr5Z6oaglCQa5DT6l4KOAnuBZgGO00sGbkUeBDcWh1eXDg5XccNB7T ES4/a9YgCJldGvLOqotc9koiEeNEH9QYafBWyKE4bNQRm8+Z4qTOWN1yDSBpNxC5gP9Y5++uX1qeU gp1LsxABgfMy9kCcWv0A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m1Sf1-00Go7C-4h; Thu, 08 Jul 2021 11:57:43 +0000 Received: from mail-co1nam11on2053.outbound.protection.outlook.com ([40.107.220.53] helo=NAM11-CO1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m1Sex-00Go6J-0L for linux-arm-kernel@lists.infradead.org; Thu, 08 Jul 2021 11:57:40 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=G2zG1eTOhetsc9gwd/eKSZpjszvlX/NnWp1Iu015lkg4b97kV3iGRZjFl/Ho12x8lLY9nrA+PJP3gDBFCGb5H3z9n1KJrbPMWP7wVsl/abKgbsp/5l1qZ2tK4rRAFbsx367OydurA91N1owI3zib1SF7soVyJVqDqgn/oQKqn+w6btQq2/b7YV9+O6h686dlHthfq06M+hiQaFpKP9d6AwKpEGfR8TGS9ZCxJ7gq7zXhdwnDCRbOzQGkakFHfs78vrbN2rFYQva5b868BU0Hh1FS/H/R1rSBKHIc05UkdDWMvq4hMXXqNQfkvsP+L5jg2/e7QQE/RgHgSmF64m7Nyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5CYLwSl0IjE+IELV6toVTN9lSkCt20i9KJqwoJ4/E0Y=; b=Uj7msGVitvfZYldzkvs4/eaomWsZt4ffsgLhzyvUapJcPFZ1VIhCHtC8Qi0ASRg0M4VUtBo+A0O/lb6xev+Wh/3xrJ4dKjZ4E/dm2Zv2enqkdsKbA88RMyP7nLaECl8IZH6g5Q1ccfL81ryaXxFrS5aKqdvsWc9GbLVcVHYFo4k2R+JPIo1Kpi98IHtJbLaeUcVYE0VtgreEhHyl+MT1Av6P+sIBENbnylt8jEBt8o5pDyVg7B6SJK8iNyXiohNLvnLIrMYXj86X//Ts2C5io6jwcWvJp7AVJIC7MC1bBpEEddct0Pm16Xc3L68pvm4/vel+uSjj43StU4bj43Ca5A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=xilinx.com; dmarc=pass action=none header.from=xilinx.com; dkim=pass header.d=xilinx.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5CYLwSl0IjE+IELV6toVTN9lSkCt20i9KJqwoJ4/E0Y=; b=R3Njf70NQU5r6OPc/4Sds6dlKvUZDhC9v9oxC8KjbmDV+SZkD12rVdyuCQVgl6Dlo3Yf0dxghu1t7CUmMrYd+OHtPcNLSZFqEcgpxaHHImAfouhEDdH274NlYayqTK4Tn9iPCmYKW4KQjEtTRxa+hytI7f4dFyASWq1M8mJWgHY= Received: from PH0PR02MB7336.namprd02.prod.outlook.com (2603:10b6:510:d::6) by PH0PR02MB7414.namprd02.prod.outlook.com (2603:10b6:510:1f::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4308.22; Thu, 8 Jul 2021 11:57:33 +0000 Received: from PH0PR02MB7336.namprd02.prod.outlook.com ([fe80::a8bd:e49f:7daf:fb1e]) by PH0PR02MB7336.namprd02.prod.outlook.com ([fe80::a8bd:e49f:7daf:fb1e%9]) with mapi id 15.20.4287.035; Thu, 8 Jul 2021 11:57:33 +0000 From: Nava kishore Manne To: Tom Rix , "robh+dt@kernel.org" , Michal Simek , "mdf@kernel.org" , "arnd@arndb.de" , Rajan Vaja , "gregkh@linuxfoundation.org" , Amit Sunil Dhamne , Tejas Patel , "zou_wei@huawei.com" , Sai Krishna Potthuri , Ravi Patel , "iwamatsu@nigauri.org" , Jiaying Liang , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-fpga@vger.kernel.org" , git , "chinnikishore369@gmail.com" CC: Appana Durga Kedareswara Rao Subject: RE: [PATCH v8 5/5] fpga: versal-fpga: Add versal fpga manager driver Thread-Topic: [PATCH v8 5/5] fpga: versal-fpga: Add versal fpga manager driver Thread-Index: AQHXaqNsfadVFn7cU0OetyaN3QeZd6s2iBUAgAJ6vaA= Date: Thu, 8 Jul 2021 11:57:33 +0000 Message-ID: References: <20210626155248.5004-1-nava.manne@xilinx.com> <20210626155248.5004-6-nava.manne@xilinx.com> <4429c722-52f3-2e16-3a53-910345507d3e@redhat.com> In-Reply-To: <4429c722-52f3-2e16-3a53-910345507d3e@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-TNEF-Correlator: authentication-results: redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=xilinx.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 340f7c7c-e483-4f86-ebb9-08d942079213 x-ms-traffictypediagnostic: PH0PR02MB7414: x-ld-processed: 657af505-d5df-48d0-8300-c31994686c5c,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3173; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 3BCkJuWXebAS/smEd3VcUN20nDymo9E0K/ZbYc6V704jJH5JhYi7svmUv8WaNxevyVdEbWlxBdtNVK3HBMeulXMuubdAhIRnnL73LTeRU6ppGvUpXsnadiy4RMLhccdjAuChPop72RplBWGy5G0UcptKCpkz2qXzNjoTbU9VtMWwrsILDM2sdqT9FojQ9Gi/P3+CyyYAHVR/lHspJ0ejXHD0qRsfdp7kk2q4ESXj2WNhPJIBuvrd3jwPexgNuCqubmUOr6d3PDhGiLojTg7QPw+B05R9MjYw9sz+3dl2kT0uzH09DcDgdPSJTi8IUNGUm6dndFrPctov5ubyt2Nl0QeVoyn6DIFA4C7P1Hitde9MDCCh86yPcuKgNT6mNXS/EMc0e7Q7bIW2RbmJW4vT+3QuvMfF44qFLmTjDKsch6eKi5bPKPxrXaUjRXCG7TFpJDjo60lCpTsa/QYZIYJbDN912GfPtLpOGf6+RNNGq2ihIBZc7USPy1xYORIu3z82AluTnbuSkJQK1yDpueM5NGSVaUSLOJbi8UryV7uLkD4LKsgxOCQlNHqmswMmkhtYea/FvA1Z/Dl88aFrtJvFvhcqpdNxLIIgYkBZPdySPKKSloxThMnX5uOizj8S3lhfPTF0LmfSc5E+LRrrUbCR8JO7uUyy8x/1kb9WPw0HitC41CxjY/M4pnU84X/LiykTGkNOP5KM8Ymon2JqEX97aQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR02MB7336.namprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(39860400002)(366004)(136003)(376002)(346002)(2906002)(8676002)(55016002)(8936002)(76116006)(122000001)(921005)(71200400001)(38100700002)(5660300002)(186003)(9686003)(6506007)(53546011)(26005)(52536014)(478600001)(83380400001)(86362001)(66446008)(66556008)(110136005)(4326008)(7696005)(64756008)(66946007)(66476007)(33656002)(107886003)(7416002)(316002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?SGoxQ2NzV21yZzE4Qis0TXRCNUtvWnQ0M2N1MUhRQTQ5SXB5THBVc1c0Sk1G?= =?utf-8?B?M2xDY2w1TlhYZlNiZW16bU5TdnI5QnFHYnFmMDlDQUZtYkZOKzJJRXR1RFR2?= =?utf-8?B?dG5CWWdDb0pzWGZBV21HZm9reWFMemNpeG1zWlBiVXo3a2prMi84SHNFcUhy?= =?utf-8?B?bW9qYzAyRkt5NXRseDE3eEIyelFrMVVQUUNPdFVUZkxUN1BNT1VIWjZhWWxG?= =?utf-8?B?TXMyWWJOUE8zQnZ3U0ZuTEVEUXd5V3Awc0pZTGxRcTc5RmtibUxFdEtKUzl3?= =?utf-8?B?dnpLTEdIMkd6bEl0bUFHbUljTlExSlg0UUYyY1U5RmVhRDJ1Rnpqc1lMTURu?= =?utf-8?B?djdzZmIrTmdBcFMweGNJN1BZY0NJUXJRSDhXNnBnMUVRd3hVSlQ2Ry9jSmNm?= =?utf-8?B?SmVIYXJGenIxaER0UmtCVk5COVRMVGVmYmdMUG1CaGdyTmVTeXN4ckJwL1Zz?= =?utf-8?B?NFg0U0VMcWg4eTExU2k2VVlpRU84NG9QaHBwT0VKekhwTkQ3RUNmenhPM3Ev?= =?utf-8?B?L1NENDA5c2U4UzhWRTRaK1BPc2Y3ZDhTSUtkUjdQYXYraXVwcm5sVGVHaXA3?= =?utf-8?B?RmFXYTdsUW5QODRqNXZjOFB5NjRGdXU2R1JVWHI5MFJ3ZkVCR01vMVZOakpU?= =?utf-8?B?ODZpTENVQ0pzYnc5dVM5OFNLS0tjT0xZMTU5SzdOd0huQTRCWk5wZ1ZOM2JO?= =?utf-8?B?UE9sakZXK0xuYS9HVlp5NnZsci9jczdaM0JQK25DYjJkT3oyWjErT0VLcmdL?= =?utf-8?B?V0R2b01DQWg2TG5KRU03TzFhNGwxdHcyWk4rcWJ6ZjZDajg1SjVVTm8xcXo4?= =?utf-8?B?bTdZcjZJVWFRZlZNODFZTWkwNmNCY1NWUWRoYXYxalFUaHd6a1ovdnpXQTc5?= =?utf-8?B?ZEc3K0hCbThUYzRZTHc5SXVEbStNMkVQTytsOTJYSHlXajdLZVkyQXpPWUUz?= =?utf-8?B?OWViSFRGQlhEOCtRRzVoL0FCQ2JGQlpLQ1BpVEVkUVFXNGZtK3RBdmVLVmdi?= =?utf-8?B?UkNzOUdvbldRS3F3SklxV3ZJdWVKclpyd1pEdDNCb0p5NGpicmkwemp2SXJh?= =?utf-8?B?RlBFdmVWWGo0c1BZRzBkUnNUS3F6bC92NVJTRGhpb1FqUEQwZzFlRlljT2g3?= =?utf-8?B?M1hSalFHZ3VnNnRQTkRDdmxKdG44bnQxTENBZW9YY2xDeERKbUFOLzl6akRF?= =?utf-8?B?cHpTcDAyMVJ0RmJTQjhXNkdIMmFxTm9pSGdaN2g4WWxsbC8rSVVnUEYrQkJD?= =?utf-8?B?QVNwbXhwWTZpejA1ZXdRRkM0YWZOOGxVTVhEM2t4UE5yc2tNWjRmNVp1Skt1?= =?utf-8?B?MVZZUy9jcm1BYWU4T0ZPL0Z4QTJObDZFWGVkSW5IeHY1VnIwT0VnQWlvVWp2?= =?utf-8?B?ZWY2cm1xNmFNeEFTMGhqbVlxRVhXdHVsWFJxMG9sM1lJaFo4dURRWkw1YzFi?= =?utf-8?B?dERmVVFjMFNITHlUQm0wRWE1VzlpemVCdUxFZWxId240WkFTREE2SVptUEVw?= =?utf-8?B?d1Fhb0hJVnZwVzAzbjJUTVVSRm45cDlkaUQ0NzBrUFdmVm9Bclg1alZySkhh?= =?utf-8?B?L2dnakNYbkhxWGdhYkxKNFNCN05FSGxDRXFkZnJEanZiU2F2THJsU2xKUnI4?= =?utf-8?B?akdCMEhGUjMrQ2I3UUlRcEVpTzJaRndtMlpwc1N3eGFtYUhTb1E2c1NrTjlt?= =?utf-8?B?VDUrdnBsbGREQmwvWmUvaC93WTNTUFFiOW8wa1ZZOWRrOFY5NlFaR1lxdkdN?= =?utf-8?Q?0d6loeTqa1ln4XeI3Thauto51jwtr/606hXviWG?= MIME-Version: 1.0 X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7336.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 340f7c7c-e483-4f86-ebb9-08d942079213 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Jul 2021 11:57:33.0707 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Q/rdFijLvZotD4VL3QS52q7twvL18kT0j9MCxSVpe5hctmWEJzeq3jFvsHSH4f98FY/hkkzPvq5p0OupPa6sbw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR02MB7414 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210708_045739_207297_79D9D1DF X-CRM114-Status: GOOD ( 29.58 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Tom, Please find my response inline. > -----Original Message----- > From: Tom Rix > Sent: Wednesday, July 7, 2021 3:04 AM > To: Nava kishore Manne ; robh+dt@kernel.org; Michal > Simek ; mdf@kernel.org; arnd@arndb.de; Rajan Vaja > ; gregkh@linuxfoundation.org; Amit Sunil Dhamne > ; Tejas Patel ; > zou_wei@huawei.com; Sai Krishna Potthuri ; Ravi > Patel ; iwamatsu@nigauri.org; Jiaying Liang > ; devicetree@vger.kernel.org; linux-arm- > kernel@lists.infradead.org; linux-kernel@vger.kernel.org; linux- > fpga@vger.kernel.org; git ; chinnikishore369@gmail.com > Cc: Appana Durga Kedareswara Rao > Subject: Re: [PATCH v8 5/5] fpga: versal-fpga: Add versal fpga manager driver > > > On 6/26/21 8:52 AM, Nava kishore Manne wrote: > > Add support for Xilinx Versal FPGA manager. > > > > PDI source type can be DDR, OCM, QSPI flash etc.. > > But driver allocates memory always from DDR, Since driver supports > > only DDR source type. > > > > Signed-off-by: Appana Durga Kedareswara rao > > > > Signed-off-by: Nava kishore Manne > > Reviewed-by: Moritz Fischer > > --- > > Changes for v2: > > -Updated the Fpga Mgr registrations call's > > to 5.11 > > -Fixed some minor coding issues as suggested by > > Moritz. > > > > Changes for v3: > > -Rewritten the Versal fpga Kconfig contents. > > > > Changes for v4: > > -Rebased the changes on linux-next. > > No functional changes. > > > > Changes for v5: > > -None. > > > > Changes for v6: > > -None. > > > > Changes for v7: > > -Updated driver to remove unwated priv struct dependency. > > > > Changes for v8: > > -None. > > > > drivers/fpga/Kconfig | 9 ++++ > > drivers/fpga/Makefile | 1 + > > drivers/fpga/versal-fpga.c | 96 > ++++++++++++++++++++++++++++++++++++++ > > 3 files changed, 106 insertions(+) > > create mode 100644 drivers/fpga/versal-fpga.c > > > > diff --git a/drivers/fpga/Kconfig b/drivers/fpga/Kconfig index > > 8cd454ee20c0..16793bfc2bb4 100644 > > --- a/drivers/fpga/Kconfig > > +++ b/drivers/fpga/Kconfig > > @@ -234,4 +234,13 @@ config FPGA_MGR_ZYNQMP_FPGA > > to configure the programmable logic(PL) through PS > > on ZynqMP SoC. > > > > +config FPGA_MGR_VERSAL_FPGA > > + tristate "Xilinx Versal FPGA" > > + depends on ARCH_ZYNQMP || COMPILE_TEST > Shouldn't this depend on ZYNQMP_FIRMWARE ? Yes it has a dependency, will fix > > + help > > + Select this option to enable FPGA manager driver support for > > + Xilinx Versal SoC. This driver uses the firmware interface to > > + configure the programmable logic(PL). > > + > > + To compile this as a module, choose M here. > > endif # FPGA > > diff --git a/drivers/fpga/Makefile b/drivers/fpga/Makefile index > > 18dc9885883a..0bff783d1b61 100644 > > --- a/drivers/fpga/Makefile > > +++ b/drivers/fpga/Makefile > > @@ -18,6 +18,7 @@ obj-$(CONFIG_FPGA_MGR_TS73XX) += > ts73xx-fpga.o > > obj-$(CONFIG_FPGA_MGR_XILINX_SPI) += xilinx-spi.o > > obj-$(CONFIG_FPGA_MGR_ZYNQ_FPGA) += zynq-fpga.o > > obj-$(CONFIG_FPGA_MGR_ZYNQMP_FPGA) += zynqmp-fpga.o > > +obj-$(CONFIG_FPGA_MGR_VERSAL_FPGA) += versal-fpga.o > The other CONFIG_FPGA_MGR* configs are alphabetical, versal should > follow. Will fix. > > obj-$(CONFIG_ALTERA_PR_IP_CORE) += altera-pr-ip-core.o > > obj-$(CONFIG_ALTERA_PR_IP_CORE_PLAT) += altera-pr-ip-core-plat.o > > > > diff --git a/drivers/fpga/versal-fpga.c b/drivers/fpga/versal-fpga.c > > new file mode 100644 index 000000000000..1bd312a31b23 > > --- /dev/null > > +++ b/drivers/fpga/versal-fpga.c > > @@ -0,0 +1,96 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > +/* > > + * Copyright (C) 2019-2021 Xilinx, Inc. > > + */ > > + > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > + > > +static int versal_fpga_ops_write_init(struct fpga_manager *mgr, > > + struct fpga_image_info *info, > > + const char *buf, size_t size) { > > + return 0; > > +} > > + > These empty ops should go away with my wrappers patchset Once your patches got integrated will post one more patch to remove this empty ops. > > +static int versal_fpga_ops_write(struct fpga_manager *mgr, > > + const char *buf, size_t size) > > +{ > > + dma_addr_t dma_addr = 0; > > + char *kbuf; > > + int ret; > > + > > + kbuf = dma_alloc_coherent(mgr->dev.parent, size, &dma_addr, > GFP_KERNEL); > > + if (!kbuf) > > + return -ENOMEM; > > + > > + memcpy(kbuf, buf, size); > > + ret = zynqmp_pm_load_pdi(PDI_SRC_DDR, dma_addr); > why isn't the size passed ? Size is part of PDI images header users no need to pass this info explicitly. > > + dma_free_coherent(mgr->dev.parent, size, kbuf, dma_addr); > > + > > + return ret; > > +} > > + > > +static int versal_fpga_ops_write_complete(struct fpga_manager *mgr, > > + struct fpga_image_info *info) > > +{ > > + return 0; > > +} > > + > > +static enum fpga_mgr_states versal_fpga_ops_state(struct fpga_manager > > +*mgr) { > > + return FPGA_MGR_STATE_UNKNOWN; > > +} > > + > > +static const struct fpga_manager_ops versal_fpga_ops = { > > + .state = versal_fpga_ops_state, > > + .write_init = versal_fpga_ops_write_init, > > + .write = versal_fpga_ops_write, > > + .write_complete = versal_fpga_ops_write_complete, }; > > + > > +static int versal_fpga_probe(struct platform_device *pdev) { > > + struct device *dev = &pdev->dev; > > + struct fpga_manager *mgr; > > + int ret; > > + > > + ret = dma_set_mask_and_coherent(&pdev->dev, > DMA_BIT_MASK(32)); > > + if (ret < 0) { > > + dev_err(dev, "no usable DMA configuration\n"); > > + return ret; > > + } > > + > > + mgr = devm_fpga_mgr_create(dev, "Xilinx Versal FPGA Manager", > > + &versal_fpga_ops, NULL); > > + if (!mgr) > > + return -ENOMEM; > > + > > + return devm_fpga_mgr_register(dev, mgr); } > > + > > +static const struct of_device_id versal_fpga_of_match[] = { > > + { .compatible = "xlnx,versal-fpga", }, > > + {}, > > +}; > > +MODULE_DEVICE_TABLE(of, versal_fpga_of_match); > needs #if defined(CONFIG_OF) wrapper Will fix. > > + > > +static struct platform_driver versal_fpga_driver = { > > + .probe = versal_fpga_probe, > > + .driver = { > > + .name = "versal_fpga_manager", > > + .of_match_table = of_match_ptr(versal_fpga_of_match), > > + }, > > +}; > > +module_platform_driver(versal_fpga_driver); > > + > > +MODULE_AUTHOR("Nava kishore Manne "); > > +MODULE_AUTHOR("Appana Durga Kedareswara rao > > +"); > > Rao - needs to be capitalized ? > Will fix. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel