From: Ross Lagerwall <ross.lagerwall@citrix.com>
To: Roger Pau Monne <roger.pau@citrix.com>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: "konrad.wilk@oracle.com" <konrad.wilk@oracle.com>,
"doebel@amazon.de" <doebel@amazon.de>,
"julien@xen.org" <julien@xen.org>,
"Andrew Cooper" <Andrew.Cooper3@citrix.com>,
"Roger Pau Monné" <roger.pau@citrrix.com>
Subject: Re: [PATCH 2/4] livepatch: improve rune for fetching of Build ID
Date: Tue, 8 Mar 2022 13:47:48 +0000 [thread overview]
Message-ID: <PH0PR03MB6382F60EB5D712C1343799AFF0099@PH0PR03MB6382.namprd03.prod.outlook.com> (raw)
In-Reply-To: <20220302142711.38953-3-roger.pau@citrix.com>
> From: Roger Pau Monne <roger.pau@citrix.com>
> Sent: Wednesday, March 2, 2022 2:27 PM
> To: xen-devel@lists.xenproject.org <xen-devel@lists.xenproject.org>
> Cc: Ross Lagerwall <ross.lagerwall@citrix.com>; konrad.wilk@oracle.com <konrad.wilk@oracle.com>; doebel@amazon.de <doebel@amazon.de>; julien@xen.org <julien@xen.org>; Andrew Cooper <Andrew.Cooper3@citrix.com>; Roger Pau Monne <roger.pau@citrix.com>; Roger Pau Monné <roger.pau@citrrix.com>
> Subject: [PATCH 2/4] livepatch: improve rune for fetching of Build ID
>
> The current one is broken with my version of readelf and returns
> 'NT_GNU_BUILD_ID'.
>
> Signed-off-by: Roger Pau Monné <roger.pau@citrrix.com>
> ---
> README.md | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/README.md b/README.md
> index b48a3df..948a7de 100644
> --- a/README.md
> +++ b/README.md
> @@ -16,7 +16,7 @@ $ cp -r ~/src/xen ~/src/xenbuild
> $ cd ~/src/xen/xen
> $ make nconfig # Make sure to set CONFIG_LIVEPATCH=y
> $ make
> -$ BUILDID=$(readelf -Wn xen-syms | awk '/Build ID:/ {print $3}')
> +$ BUILDID=$(readelf -Wn xen-syms | sed -n -e 's/^.*Build ID: //p')
> ```
>
> Next, build a live patch, using a patch and the source, build ID, and
> --
> 2.34.1
Reviewed-by: Ross Lagerwall <ross.lagerwall@citrix.com>
next prev parent reply other threads:[~2022-03-08 13:48 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-02 14:27 [PATCH 0/4] livepatch: fixes for patch generation Roger Pau Monne
2022-03-02 14:27 ` [PATCH 1/4] livepatch: update readme to mention --xen-depends Roger Pau Monne
2022-03-02 15:32 ` Doebel, Bjoern
2022-03-08 13:36 ` Ross Lagerwall
2022-03-02 14:27 ` [PATCH 2/4] livepatch: improve rune for fetching of Build ID Roger Pau Monne
2022-03-02 15:33 ` Doebel, Bjoern
2022-03-08 13:47 ` Ross Lagerwall [this message]
2022-03-02 14:27 ` [PATCH 3/4] livepatch: do the initial build using CROSS_COMPILE Roger Pau Monne
2022-03-02 16:24 ` Doebel, Bjoern
2022-03-08 13:52 ` Ross Lagerwall
2022-03-02 14:27 ` [PATCH 4/4] livepatch: differentiate between old and new build systems Roger Pau Monne
2022-03-02 15:41 ` Doebel, Bjoern
2022-03-02 15:51 ` Roger Pau Monné
2022-03-02 15:55 ` Andrew Cooper
2022-03-02 16:25 ` Doebel, Bjoern
2022-03-08 13:58 ` Ross Lagerwall
2022-03-08 14:38 ` Andrew Cooper
2022-03-08 14:52 ` Roger Pau Monné
2022-03-10 18:01 ` Andrew Cooper
2022-03-11 8:33 ` Roger Pau Monné
2022-03-21 10:25 ` Roger Pau Monné
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH0PR03MB6382F60EB5D712C1343799AFF0099@PH0PR03MB6382.namprd03.prod.outlook.com \
--to=ross.lagerwall@citrix.com \
--cc=Andrew.Cooper3@citrix.com \
--cc=doebel@amazon.de \
--cc=julien@xen.org \
--cc=konrad.wilk@oracle.com \
--cc=roger.pau@citrix.com \
--cc=roger.pau@citrrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.