All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Thumshirn <Johannes.Thumshirn@wdc.com>
To: Naohiro Aota <Naohiro.Aota@wdc.com>,
	"fstests@vger.kernel.org" <fstests@vger.kernel.org>
Cc: "linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH 0/5] fstests: add checks for testing zoned btrfs
Date: Fri, 21 May 2021 11:06:06 +0000	[thread overview]
Message-ID: <PH0PR04MB7416870032582BC2A8FC5AD99B299@PH0PR04MB7416.namprd04.prod.outlook.com> (raw)
In-Reply-To: PH0PR04MB7416E64E9F3C70C39EA657BB9B299@PH0PR04MB7416.namprd04.prod.outlook.com

On 21/05/2021 12:17, Johannes Thumshirn wrote:
> On 21/05/2021 06:58, Naohiro Aota wrote:
>> Several tests are failing on zoned btrfs, but actually they are
>> invalid. There are two reasons of the failures. One is creating too
>> small filesystem. Since zoned btrfs needs at lease 5 zones (= 1.25 GB
>> if zone size = 256MB) to create a filesystem, tests creating e.g., 1
>> GB filesystem will fail.
>>
>> The other reason is lacking of zone support of some dm targets and
>> loop device. So, they need to skip the test if the testing device is
>> zoned.
>>
>> Patches 1 to 3 handle the too small file system failure.
>>
>> And, patches 4 and 5 add checks for tests requiring non-zoned devices.
>>
>> Naohiro Aota (5):
>>   common/rc: introduce minimal fs size check
>>   btrfs/057: use _scratch_mkfs_sized to set filesystem size
>>   btrfs: add minimal file system size check
>>   common: add zoned block device checks
>>   shared/032: add check for zoned block device
>>
>>  README            |  4 ++++
>>  common/dmerror    |  3 +++
>>  common/dmhugedisk |  3 +++
>>  common/rc         | 15 +++++++++++++++
>>  tests/btrfs/057   |  2 +-
>>  tests/btrfs/141   |  1 +
>>  tests/btrfs/142   |  1 +
>>  tests/btrfs/143   |  1 +
>>  tests/btrfs/150   |  1 +
>>  tests/btrfs/151   |  1 +
>>  tests/btrfs/156   |  1 +
>>  tests/btrfs/157   |  1 +
>>  tests/btrfs/158   |  1 +
>>  tests/btrfs/175   |  1 +
>>  tests/shared/032  |  2 ++
>>  15 files changed, 37 insertions(+), 1 deletion(-)
>>
> 
> For the whole series:
> Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
> Tested-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
> 

Spoke too early, I've only tested with a zoned device. I get the 
following splat with non zoned btrfs:

btrfs/146       - output mismatch (see /home/johannes/src/xfstests-dev/results//btrfs/146.out.bad)                                                                                                                                                                                                                                                                          
    --- tests/btrfs/146.out     2020-01-07 15:49:53.000000000 +0000                                                                                                                                                                                                                                                                                                         
    +++ /home/johannes/src/xfstests-dev/results//btrfs/146.out.bad      2021-05-21 09:56:43.963914581 +0000                                                                                                                                                                                                                                                                 
    @@ -1,3 +1,5 @@                                                                                                                                                                                                                                                                                                                                                         
     QA output created by 146                                                                                                                                                                                                                                                                                                                                               
     Format and mount                                                                                                                                                                                                                                                                                                                                                       
    +./common/dmerror: line 20: _require_non_zoned_device: command not found                                                                                                                                                                                                                                                                                                
    +./common/dmerror: line 20: _require_non_zoned_device: command not found                                                                                                                                                                                                                                                                                                
     Test passed!                                                                                                                                                                                                                                                                                                                                                           
    ...                                                                                                                                                                                                                                                                                                                                                                     
    (Run 'diff -u /home/johannes/src/xfstests-dev/tests/btrfs/146.out /home/johannes/src/xfstests-dev/results//btrfs/146.out.bad'  to see the entire diff)

      reply	other threads:[~2021-05-21 11:06 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-21  4:58 [PATCH 0/5] fstests: add checks for testing zoned btrfs Naohiro Aota
2021-05-21  4:58 ` [PATCH 1/5] common/rc: introduce minimal fs size check Naohiro Aota
2021-05-21  4:58 ` [PATCH 2/5] btrfs/057: use _scratch_mkfs_sized to set filesystem size Naohiro Aota
2021-05-21  4:58 ` [PATCH 3/5] btrfs: add minimal file system size check Naohiro Aota
2021-05-21  4:58 ` [PATCH 4/5] common: add zoned block device checks Naohiro Aota
2021-05-21  4:58 ` [PATCH 5/5] shared/032: add check for zoned block device Naohiro Aota
2021-05-21 10:17 ` [PATCH 0/5] fstests: add checks for testing zoned btrfs Johannes Thumshirn
2021-05-21 11:06   ` Johannes Thumshirn [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=PH0PR04MB7416870032582BC2A8FC5AD99B299@PH0PR04MB7416.namprd04.prod.outlook.com \
    --to=johannes.thumshirn@wdc.com \
    --cc=Naohiro.Aota@wdc.com \
    --cc=fstests@vger.kernel.org \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.