From: Johannes Thumshirn <Johannes.Thumshirn@wdc.com>
To: "dsterba@suse.cz" <dsterba@suse.cz>,
David Sterba <dsterba@suse.com>,
"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH 7/9] btrfs: rename io_failure_record::bio_flags to compress_type
Date: Mon, 2 May 2022 16:31:28 +0000 [thread overview]
Message-ID: <PH0PR04MB7416929D574A11EEF58AC3759BC19@PH0PR04MB7416.namprd04.prod.outlook.com> (raw)
In-Reply-To: 20220502162625.GL18596@twin.jikos.cz
On 02/05/2022 09:30, David Sterba wrote:
> On Mon, May 02, 2022 at 05:16:59PM +0200, David Sterba wrote:
>> On Sun, May 01, 2022 at 08:22:41PM +0000, Johannes Thumshirn wrote:
>>> On 29/04/2022 11:32, David Sterba wrote:
>>>> diff --git a/fs/btrfs/extent_io.h b/fs/btrfs/extent_io.h
>>>> index fdbfe801dbe2..1fa40ab561df 100644
>>>> --- a/fs/btrfs/extent_io.h
>>>> +++ b/fs/btrfs/extent_io.h
>>>> @@ -266,7 +266,7 @@ struct io_failure_record {
>>>> u64 start;
>>>> u64 len;
>>>> u64 logical;
>>>> - unsigned long bio_flags;
>>>> + unsigned int compress_type;
>>>> int this_mirror;
>>>> int failed_mirror;
>>>> };
>>>
>>>
>>> Why 'unsigned int' and not 'enum btrfs_compression_type'?
>>
>> Good point I'll change it, though it's not used almost anywhere else.
>
> I'll fix up the 2 following patches as well, the type switch in parameters.
>
Cool thanks, I was about to ask.
next prev parent reply other threads:[~2022-05-02 16:32 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-29 18:27 [PATCH 0/9] Structre and parameter cleanups David Sterba
2022-04-29 18:27 ` [PATCH 1/9] btrfs: sink parameter is_data to btrfs_set_disk_extent_flags David Sterba
2022-05-01 20:24 ` Johannes Thumshirn
2022-04-29 18:27 ` [PATCH 2/9] btrfs: remove btrfs_delayed_extent_op::is_data David Sterba
2022-05-01 20:24 ` Johannes Thumshirn
2022-04-29 18:27 ` [PATCH 3/9] btrfs: remove unused parameter bio_flags from btrfs_wq_submit_bio David Sterba
2022-05-01 20:25 ` Johannes Thumshirn
2022-04-29 18:27 ` [PATCH 4/9] btrfs: remove trivial helper update_nr_written David Sterba
2022-05-01 20:25 ` Johannes Thumshirn
2022-04-29 18:27 ` [PATCH 5/9] btrfs: simplify handling of bio_ctrl::bio_flags David Sterba
2022-05-01 20:26 ` Johannes Thumshirn
2022-04-29 18:27 ` [PATCH 6/9] btrfs: open code extent_set_compress_type helpers David Sterba
2022-05-01 20:27 ` Johannes Thumshirn
2022-04-29 18:27 ` [PATCH 7/9] btrfs: rename io_failure_record::bio_flags to compress_type David Sterba
2022-05-01 20:22 ` Johannes Thumshirn
2022-05-02 15:16 ` David Sterba
2022-05-02 16:26 ` David Sterba
2022-05-02 16:31 ` Johannes Thumshirn [this message]
2022-04-29 18:27 ` [PATCH 8/9] btrfs: rename bio_flags in parameters and switch type David Sterba
2022-04-29 18:27 ` [PATCH 9/9] btrfs: rename bio_ctrl::bio_flags to compress_type David Sterba
2022-05-03 7:57 ` [PATCH 0/9] Structre and parameter cleanups Nikolay Borisov
2022-05-09 19:56 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH0PR04MB7416929D574A11EEF58AC3759BC19@PH0PR04MB7416.namprd04.prod.outlook.com \
--to=johannes.thumshirn@wdc.com \
--cc=dsterba@suse.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.