From: Johannes Thumshirn <Johannes.Thumshirn@wdc.com>
To: Anand Jain <anand.jain@oracle.com>, David Sterba <dsterba@suse.cz>
Cc: "linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>,
Naohiro Aota <Naohiro.Aota@wdc.com>
Subject: Re: [PATCH] btrfs: zoned: remove fs_info->max_zone_append_size
Date: Mon, 28 Jun 2021 11:12:31 +0000 [thread overview]
Message-ID: <PH0PR04MB7416A143777E98CBB3A0B5689B039@PH0PR04MB7416.namprd04.prod.outlook.com> (raw)
In-Reply-To: c6e645b1-ceb1-bbd6-a58a-e6b696f6be8e@oracle.com
On 28/06/2021 12:39, Anand Jain wrote:
> On 28/6/21 5:13 pm, Johannes Thumshirn wrote:
>> Remove fs_info->max_zone_append_size, it doesn't serve any purpose.
>>
>
>
> Commit 862931c76327 (btrfs: introduce max_zone_append_size) add it.
> The purpose of it is to limit all IO append size. So now, we shall
> only track the max_zone_append_size in
> device->zone_info->max_zone_append_size, which is per device.
>
> btrfs_check_zoned_mode() found the lowest of these per device
> max_zone_append_size but it didn't do much about it.
Exactly. We don't do anything with it, so it's completely unneeded. Also
as the max_zone_append_size is per device it doesn't make much sense to
track it globally. It is basically set but never read.
next prev parent reply other threads:[~2021-06-28 11:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-28 9:13 [PATCH] btrfs: zoned: remove fs_info->max_zone_append_size Johannes Thumshirn
2021-06-28 10:38 ` Anand Jain
2021-06-28 11:12 ` Johannes Thumshirn [this message]
2021-06-28 11:42 ` Anand Jain
2021-06-28 11:45 ` [PATCH RFC] btrfs: drop check for lowest max_zone_append_size in btrfs_check_zoned_mode Anand Jain
2021-06-28 14:30 ` Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH0PR04MB7416A143777E98CBB3A0B5689B039@PH0PR04MB7416.namprd04.prod.outlook.com \
--to=johannes.thumshirn@wdc.com \
--cc=Naohiro.Aota@wdc.com \
--cc=anand.jain@oracle.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.