From: Johannes Thumshirn <Johannes.Thumshirn@wdc.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Dan Carpenter <dan.carpenter@oracle.com>,
Johannes Thumshirn <jth@kernel.org>
Subject: Re: [PATCH 2/3] mcb: fix error handling in mcb_alloc_bus()
Date: Tue, 15 Jun 2021 15:44:10 +0000 [thread overview]
Message-ID: <PH0PR04MB7416D67511F5DE1C78D6838A9B309@PH0PR04MB7416.namprd04.prod.outlook.com> (raw)
In-Reply-To: YMjKQnFRi0feSYiI@kroah.com
On 15/06/2021 17:42, Greg Kroah-Hartman wrote:
> On Tue, Jun 15, 2021 at 11:55:29PM +0900, Johannes Thumshirn wrote:
>> From: Dan Carpenter <dan.carpenter@oracle.com>
>>
>> There are two bugs:
>> 1) If ida_simple_get() fails then this code calls put_device(carrier)
>> but we haven't yet called get_device(carrier) and probably that
>> leads to a use after free.
>> 2) After device_initialize() then we need to use put_device() to
>> release the bus. This will free the internal resources tied to the
>> device and call mcb_free_bus() which will free the rest.
>>
>> Fixes: 5d9e2ab9fea4 ("mcb: Implement bus->dev.release callback")
>> Fixes: 18d288198099 ("mcb: Correctly initialize the bus's device")
>> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>> Signed-off-by: Johannes Thumshirn <jth@kernel.org>
>> ---
>> drivers/mcb/mcb-core.c | 12 ++++++------
>> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> Shouldn't this go to the stable kernels? Why not cc: stable in the
> signed-off-by lines?
Right, I'll add a cc stable
next prev parent reply other threads:[~2021-06-15 15:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-15 14:55 [PATCH 0/3] mcb changes for 5.14 Johannes Thumshirn
2021-06-15 14:55 ` [PATCH 1/3] mcb: Use DEFINE_RES_MEM() to simplify code Johannes Thumshirn
2021-06-15 15:42 ` Greg Kroah-Hartman
2021-06-16 1:31 ` Leizhen (ThunderTown)
2021-06-16 6:41 ` Greg Kroah-Hartman
2021-06-15 14:55 ` [PATCH 2/3] mcb: fix error handling in mcb_alloc_bus() Johannes Thumshirn
2021-06-15 15:41 ` Greg Kroah-Hartman
2021-06-15 15:44 ` Johannes Thumshirn [this message]
2021-06-15 14:55 ` [PATCH 3/3] mcb: Remove trailing semicolon in macros Johannes Thumshirn
2021-06-15 15:48 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH0PR04MB7416D67511F5DE1C78D6838A9B309@PH0PR04MB7416.namprd04.prod.outlook.com \
--to=johannes.thumshirn@wdc.com \
--cc=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=jth@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.